| 8 Oct 2023 |
Artturin | internal errors https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Aofborg-internal-error | 21:23:58 |
| 10 Oct 2023 |
| cafkafk changed their display name from Christina Sørensen to cafkafk. | 03:39:15 |
| cafkafk changed their profile picture. | 03:39:32 |
cafkafk | would it be possible to fast track changes that only touch maintainers/maintainer-list.nix? I've got no actual idea how ofborg works, but the checks on that probably aren't super expensive, could be nice if it could get those through faster. | 10:22:22 |
Alyssa Ross | in general changes that only touch maintainer-list.nix should be pretty rare | 10:23:02 |
Alyssa Ross | generally if somebody is adding themself to the maintainer list, it should be in the same PR where they are added as the maintainer of a package | 10:23:22 |
Alyssa Ross | (occasionally, as you've seen, it makes sense to separate it, if somebody new is adding two packages at once or something) | 10:23:37 |
Alyssa Ross | but OfBorg is like, a couple of hours max | 10:23:43 |
Lily Foster | In reply to @cafkafk:gitter.im would it be possible to fast track changes that only touch maintainers/maintainer-list.nix? I've got no actual idea how ofborg works, but the checks on that probably aren't super expensive, could be nice if it could get those through faster. What sort of "fast track" are you thinking, like skipping eval checks? | 10:23:51 |
cafkafk | more like scheduling them first... assuming eval checks don't take super long | 10:24:12 |
cafkafk | In reply to @qyliss:fairydust.space in general changes that only touch maintainer-list.nix should be pretty rare to add quantity to that, ~772 (https://github.com/NixOS/nixpkgs/pulls?q=maintainers+in%3Atitle) | 10:26:09 |
cafkafk | which is admittedly peanuts | 10:26:15 |
Lily Foster | In reply to @cafkafk:gitter.im more like scheduling them first... assuming eval checks don't take super long The most expensive parts of the eval checks by far are outpath calculation (with meta checks), which wouldn't be any less here. I do actually intend to make that less expensive in general because it's getting pretty obscene at this point, but I'm admittedly a bit scared to dive into what horrors lie in all that | 10:26:29 |
cafkafk | very understandable tbh >_> | 10:27:05 |