In reply to @raitobezarius:matrix.org
also I don't think we store the name of modules anywhere anyway

❯ hyperfine "nix-instantiate --eval '<nixpkgs/nixos>' --arg configuration '{}' -A config.meta.maintainers --strict --json" 
Benchmark 1: nix-instantiate --eval '<nixpkgs/nixos>' --arg configuration '{}' -A config.meta.maintainers --strict --json
  Time (mean ± σ):     621.8 ms ±  22.6 ms    [User: 524.8 ms, System: 91.2 ms]
  Range (min … max):   597.3 ms … 663.9 ms    10 runs

{
  "cpuTime": 0.49957001209259033,
  "envs": {
    "bytes": 12506824,
    "elements": 609381,
    "number": 476986
  },
  "gc": {
    "heapSize": 402915328,
    "totalBytes": 87726480
  },
  "list": {
    "bytes": 1933232,
    "concats": 13049,
    "elements": 241654
  },
  "nrAvoided": 488806,
  "nrFunctionCalls": 412021,
  "nrLookups": 240540,
  "nrOpUpdateValuesCopied": 1193821,
  "nrOpUpdates": 12482,
  "nrPrimOpCalls": 244606,
  "nrThunks": 691079,
  "sets": {
    "bytes": 29699424,
    "elements": 1702651,
    "number": 153563
  },
  "sizes": {
    "Attr": 16,
    "Bindings": 16,
    "Env": 16,
    "Value": 24
  },
  "symbols": {
    "bytes": 531386,
    "number": 45882
  },
  "values": {
    "bytes": 27441768,
    "number": 1143407
  }
}

Ofborg's ofborg-eval-package-list-no-aliases check is still missing a lot of alias usage (see https://github.com/NixOS/nixpkgs/pull/230188#pullrequestreview-1415772214)

I notice that adding --drv-path to the command here https://github.com/NixOS/ofborg/blob/0f34038feb9b0ae9959c865608700c91d57b2590/ofborg/src/tasks/eval/nixpkgs.rs#L455 lets it catch those, but obviously that makes it a more expensive eval (since it has to actually evaluate the entire drvs)

Is there a better way we can detect alias usage instead of having it pass PRs that fail with allowAliases = false?