| 9 Feb 2024 |
Artturin | https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-create-pull-requests 7. | 21:01:00 |
Artturin | In reply to @pinpox:matrix.org Artturin: I removed the merge but now it conflicts again * conflicts should be resolved by rebasing | 21:01:43 |
@pinpox:matrix.org | Artturin: got it fixed, thanks! | 21:06:35 |
@pinpox:matrix.org | * Artturin: got it fixed, thanks! Rebased and without conflicts now | 21:06:44 |
| 12 Feb 2024 |
@infinisil:matrix.org | Regarding https://github.com/NixOS/nixpkgs/pull/269403, I actually don't think it would improve ofborg speed at all | 00:53:17 |
@infinisil:matrix.org | * Regarding https://github.com/NixOS/nixpkgs/pull/269403, I actually don't think it would improve ofborg eval speed at all | 00:53:21 |
@infinisil:matrix.org | It gives a 5x speedup if you have 31 additional cores without anything to do | 00:53:55 |
@infinisil:matrix.org | Well I guess it depends on how booked-out ofborg generally is | 00:54:42 |
@infinisil:matrix.org | Because if it's already using 32 cores for 32 separate evaluations, that PR would not help at all (in fact it would make it a lot worse, because each parallel unit of work duplicates work..) | 00:55:42 |
cole-h | ofborg does not use 32 cores for 32 evaluations 😆
It only has enough memory to run 3 evaluations on one machine most times. (256GiB total, each eval-outpaths takes ~60+GiB of memory.) | 15:03:16 |
cole-h | So, provided there's no huge build taking place on the same box, the other cores are usually sitting around twiddling their thumbs. | 15:04:13 |
raitobezarius | In reply to @infinisil:matrix.org Because if it's already using 32 cores for 32 separate evaluations, that PR would not help at all (in fact it would make it a lot worse, because each parallel unit of work duplicates work..) well it's not like Nix is smart and knows how to deal with values appropriately | 15:51:22 |
raitobezarius | so not sure if that would be that wasteful | 15:51:26 |
raitobezarius | measurements are important here | 15:51:28 |
raitobezarius | because the GC is really in a bad shape | 15:51:36 |
@infinisil:matrix.org | I see, so it sounds like it would still help a bunch | 16:29:41 |