| 10 Sep 2023 |
Lily Foster | In reply to @cole-h:matrix.org (if only Nixpkgs eval was faster) (one day I'll get annoyed enough to dive into that...) | 14:52:19 |
| 11 Sep 2023 |
| @asymmetric:matrix.dapp.org.uk left the room. | 12:04:13 |
| 12 Sep 2023 |
@infinisil:matrix.org | Lily Foster: Oh no there's weird problems again in https://github.com/NixOS/nixpkgs/pull/254435, seems like we really need https://github.com/NixOS/ofborg/pull/650 | 02:30:06 |
| @adam:robins.wtf changed their display name from adamcstephens (buzz) to adamcstephens 🐝. | 12:22:28 |
| 14 Sep 2023 |
| @asymmetric:matrix.dapp.org.uk joined the room. | 09:33:14 |
Artturin | https://github.com/NixOS/ofborg/pull/642 | 21:38:54 |
Lily Foster | In reply to @artturin:matrix.org https://github.com/NixOS/ofborg/pull/642 (I will also second this, I think this is a good PR and a quick look through the diff looked fine to me) | 22:35:53 |
| 15 Sep 2023 |
Artturin | cole-h: | 00:57:35 |
| 19 Sep 2023 |
delroth | is there a known issue with ofborg and backport PRs? it doesn't seem to start eval/builds by itself | 21:59:11 |
delroth | e.g. https://github.com/NixOS/nixpkgs/pull/256190 | 21:59:24 |
Lily Foster | It does just give it time | 21:59:42 |
cole-h | The eval backlog is large | 21:59:52 |
delroth | well, after > 1h on https://github.com/NixOS/nixpkgs/pull/256182 it never showed up | 21:59:54 |
Lily Foster | We opted not to have the automated backport workflow start GHAs, which are what usually put the pending status before ofborg gets to it | 22:00:08 |
cole-h | If you look at the URL in the topic, there are 20 PRs in the eval queue. | 22:00:09 |
delroth | cole-h: sure but usually at least it adds the gh check thing to say it started an eval... here it doesn't even do that | 22:00:11 |
delroth | ahhh | 22:00:16 |
delroth | ok, that's what confused me, thanks | 22:00:25 |
cole-h | Yes, that's because GHA cannot trigger on bot-created PRs | 22:00:28 |
Lily Foster | (And GHAs don't get run by default for PRs opened by a github token) | 22:00:31 |
cole-h | Nixpkgs takes 10+ minutes to eval these days, so, yeah 🙃 | 22:00:46 |
delroth | for some reason I never noticed that peculiarity before, thanks | 22:00:47 |
cole-h | The workaround most people employ is to open-and-close the PR, which will start GHA | 22:00:58 |
Lily Foster | In reply to @cole-h:matrix.org Yes, that's because GHA cannot trigger on bot-created PRs I thought you could trigger it manually? Just as an actions workflow_dispatch | 22:01:06 |
cole-h | Maybe, I've never tried :P | 22:01:29 |
Artturin | I created a issue for it in 2021 https://github.com/NixOS/nixpkgs/issues/148482 | 22:01:58 |
Artturin | * I created a issue checking backport prs in 2021 https://github.com/NixOS/nixpkgs/issues/148482 | 22:02:12 |
Artturin | * I created a issue about checking backport prs in 2021 https://github.com/NixOS/nixpkgs/issues/148482 | 22:02:19 |
Lily Foster | Regardless the point being it would require an additional thing on our part to start GHAs on PRs created by our backport workflow | 22:02:22 |
Lily Foster | We actually don't run actions at all even on manual PRs iirc since for some reason we decided to exclude PRs to release branches on our github actions.... (ofborg still runs but again it just gets queued at the webhook and takes a while to actually start eval depending on queue size) | 22:03:55 |