| 29 Jun 2025 |
 emily | I like to use terrible names so everyone else can bikeshed them :) | 17:04:35 |
 hexa | done | 17:04:40 |
| hexa | (the bikeshedding part) | 17:04:49 |
| emily | and I suppose we could have nmSystemDeps or something for openconnect | 17:05:03 |
| emily | though it seems like OpenConnect is just bespokely cursed | 17:05:08 |
| hexa | it's a little bit more complicated, since strongswan requires a dbus package 😄 | 17:05:20 |
| hexa | but the point is clear | 17:05:37 |
| emily | right. well the more bespoke stuff that isn't a common need for these plugins the more I feel like it should just be services.networkmanager.plugins.strongswan or whatever, but also meh | 17:06:16 |
| emily | good to abstract things when there's actually commonality | 17:06:29 |
| hexa | emily: ok, done. ptal | 17:23:21 |
| hexa | also, I don't tthink we should block on jan, given that he didn't review the previous change of this nature either | 17:23:54 |
| hexa | alll nixos tests complete, but from the name I don't think they test any plugin behavior
/nix/store/8vm3nin5dq25k5xr28hs3a576qdg8b18-vm-test-run-auto-Networking-NetworkManager
/nix/store/3m2biidymsqpr4x4jjlnsiwg9km8na1l-vm-test-run-dispatcherScripts-Networking-NetworkManager
/nix/store/gifsd5snc5a54gan4kk9918yf25a8aaq-vm-test-run-dns-Networking-NetworkManager
/nix/store/39zidlnpzm6dgwb1wc3hj8k3jbx6mwk9-vm-test-run-envsubst-Networking-NetworkManager
/nix/store/vwfhzbphirnz865d2ib0kcabkgckafmf-vm-test-run-startup-Networking-NetworkManager
/nix/store/3prnprscnqy1zz1gv2wim1nr09irpyl6-vm-test-run-static-Networking-NetworkManager
| 17:26:22 |
| hexa | yeah, the word plugin does not appear in there | 17:26:37 |
| emily | this does not handle nmcli needing openconnect right? | 17:26:43 |
| emily | oh, it does | 17:26:57 |
| emily | ok | 17:26:59 |
| hexa | we drop it into systemPackages | 17:27:07 |
| hexa | like with the plugins itself | 17:27:13 |
| hexa | wait, I need to clean up withPlugin | 17:27:26 |
| hexa | or … not? | 17:27:37 |
| emily | it LGTM but I'm not too happy about the tmpfiles thing, so maybe we should have networkManagerTmpfilesRules too :p | 17:27:43 |
| hexa | 
Download image.png | 17:27:51 |
| hexa | networkManagerTmpFileRules? 😄 | 17:27:55 |
| hexa | fucking hell | 17:28:01 |
| emily | yeah, or at that point just have actual options | 17:28:07 |
| emily | you could put all the stuff the average NixOS serice module sets in its package's passthru too but… | 17:28:26 |
| emily | but I guess this way is better for compat | 17:28:34 |
| hexa | "this way"? | 17:28:48 |
| emily | this way = even more passthru | 17:29:29 |
| hexa | emily: you got it | 17:44:48 |
