!tCyGickeVqkHsYjWnh:nixos.org

NixOS Networking

905 Members
on your Router! Declaratively manage your switching, routing, wireless, tunneling and more.263 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
24 May 2025
@jeff:ocjtech.usJeffonly if the DHCP server tells your system22:20:03
25 May 2025
@prince213:matrix.orgprince213Can I have anyone review this PR? I know it's a review request but I'm looking for people with networking knowledge.12:09:06
@prince213:matrix.orgprince213https://github.com/NixOS/nixpkgs/pull/39858712:09:07
@prince213:matrix.orgprince213Thanks in advance.12:09:15
@emilazy:matrix.orgemily cc K900 who expressed some interest in firewalld? 13:05:15
@emilazy:matrix.orgemilyah already pinged on the PR I see13:05:28
@prince213:matrix.orgprince213It's quite a list13:06:19
@prince213:matrix.orgprince213But haven't seen any review yet13:06:28
@emilazy:matrix.orgemily

looks like a very substantive PR, thanks for putting in all this work! I don't have time to review fully right now (and I'm not a networking expert), but a few suggestions:

  • is it intended to be reviewed commit-by-commit? maybe some commits could be squashed to ease review, especially if some intermediate states may be broken (I approve of granular commits in general though!)
  • could some of this be split up into separate PRs? it looks like there are parts that just make some modules/tests more abstracted over various firewalls rather than assuming one implementation? so if those could be reviewed and landed separately it may be easier to get this through. similarly, the commits that are adding additional features to the module, or adding support for it in other modules, could be split out (simple "add the package to the list" commits could all go in one PR to handle that in bulk, say; not saying one commit per PR)
13:08:27
@emilazy:matrix.orgemilylarge PRs are pretty daunting to review so if you can take advantage of the commit granularity to split out stuff that is obvious cleanups/improvements, and chores for "after" the functionality exists, it makes it more likely that someone will find time to give a detailed review of the core functionality :)13:09:37
@prince213:matrix.orgprince213Thanks for the advice. It was originally carried over from my previous work https://git.sr.ht/~prince213/firewalld-nix and I've squash some commits together for easier reviewing, but well it's probably not enough.13:18:11
@prince213:matrix.orgprince213I should reorganize the commits then. 🤔13:18:47
@holl:matrix.orgHaroldOllivier changed their profile picture.18:56:54
26 May 2025
@ximnoise:infosec.exchangeximnoise left the room.02:55:25
@ximnoise:infosec.exchangeximnoise joined the room.02:57:38
@xengi42:matrix.orgXenGi joined the room.08:13:05
27 May 2025
@matthewcroughan:defenestrate.itmatthewcroughanhttps://www.amazon.co.uk/MikroTik-CRS305-1G-4S-IN/dp/B07LFKGP1L10:01:16
@matthewcroughan:defenestrate.itmatthewcroughanI wonder, does this do 10G10:01:22
@matthewcroughan:defenestrate.itmatthewcroughanit doesn't say it does10:01:23
@matthewcroughan:defenestrate.itmatthewcroughanBut the CRS304-4XG-IN does, and the model names are very similar10:01:38
@uep:matrix.orguep4S+.. yes it does10:03:18
@uep:matrix.orguepCootamundra10:03:46
@uep:matrix.orguep* https://mikrotik.com/product/crs305_1g_4s_in10:04:01
@matthewcroughan:defenestrate.itmatthewcroughanVeeeery cool10:05:25
@matthewcroughan:defenestrate.itmatthewcroughanso I just put a 10G in one of the SFPs and get 3 10G SFP+ out10:05:53
@matthewcroughan:defenestrate.itmatthewcroughanI would really enjoy something with some more SFP ports10:06:03
@k900:0upti.meK900Well you're still bottlenecked by the upstream 10:06:53
@matthewcroughan:defenestrate.itmatthewcroughanWDYM?10:07:04

Show newer messages


Back to Room ListRoom Version: 6