| 24 May 2025 |
 matthewcroughan @fosdem | like whether I am reachable at foo.lan or foo.localdomain or foo.bar | 22:00:08 |
 Jeff | sometimes a DHCP server will send you that information, otherwise there's no automated way | 22:08:52 |
| Jeff | and it's unlikely that a random computer connecting to a random network will get a DNS entry added to the DNS servers (not impossible, but certainly not to be relied on). | 22:10:08 |
| matthewcroughan @fosdem | resolvectl tells you about these domains anyway which is nice | 22:12:38 |
| Jeff | only if the DHCP server tells your system | 22:20:03 |
| 25 May 2025 |
 prince213 | Can I have anyone review this PR? I know it's a review request but I'm looking for people with networking knowledge. | 12:09:06 |
| prince213 | https://github.com/NixOS/nixpkgs/pull/398587 | 12:09:07 |
| prince213 | Thanks in advance. | 12:09:15 |
 emily | cc K900 who expressed some interest in firewalld? | 13:05:15 |
| emily | ah already pinged on the PR I see | 13:05:28 |
| prince213 | It's quite a list | 13:06:19 |
| prince213 | But haven't seen any review yet | 13:06:28 |
| emily | looks like a very substantive PR, thanks for putting in all this work! I don't have time to review fully right now (and I'm not a networking expert), but a few suggestions:
- is it intended to be reviewed commit-by-commit? maybe some commits could be squashed to ease review, especially if some intermediate states may be broken (I approve of granular commits in general though!)
- could some of this be split up into separate PRs? it looks like there are parts that just make some modules/tests more abstracted over various firewalls rather than assuming one implementation? so if those could be reviewed and landed separately it may be easier to get this through. similarly, the commits that are adding additional features to the module, or adding support for it in other modules, could be split out (simple "add the package to the list" commits could all go in one PR to handle that in bulk, say; not saying one commit per PR)
| 13:08:27 |
| emily | large PRs are pretty daunting to review so if you can take advantage of the commit granularity to split out stuff that is obvious cleanups/improvements, and chores for "after" the functionality exists, it makes it more likely that someone will find time to give a detailed review of the core functionality :) | 13:09:37 |
