| 17 Jun 2022 |
 hexa | wow, I made that it it's own sentence 😄 | 16:14:03 |
 fadenb | I ran into another issue though.
I naively just added a settings = { indented my old config lines and closed the curly braces.
This was valid enough to build but had multiple issuss:
database_args was accepted but did not work as expected. This lead to my database name below that being ignored.
Fix was easy, make it database.args and it is ok.
Another thing which broke was my old extraConfig which ended up as a single line in the new config.
I feel this was not sufficiently documented. For such a major change I'd hope for more safeguards or a much more detailed release notes entry that actually covers all those cases. | 19:20:39 |
 Dandellion |
need to be moved into services.matrix-synapse.settings
might have kind of implied you could just copy it in. but how settings (RFC42) works in the rest of nixos should make it somewhat a pattern so people hopefully don't actually verbatimely copy things into the settings
I don't think there's a nice way to sanity check freeform settings in general (since you want to be able to specify their contents freely), but maybe we could have explicitly checked for things like database_args for a while and thrown
| 20:00:18 |
| Dandellion | I personally think saying it generates a homeserver.yaml file and follows RFC42 ought to be enough, at least combined with settings being like that in other modules | 20:03:39 |
| 21 Jun 2022 |
| fadenb | Anyone here using synapse_auto_compressor with psql socket auth and can share with me how to specify how to connect to postgres? | 21:15:31 |
| fadenb | I always get a 'invalid configuration host missing' error but I obviously do not want to connect via the network.
Replacing host with a path to the socket does not work either | 21:16:37 |
 @andreas.schraegle:helsinki-systems.de | I just use it over localhost iirc | 21:35:15 |
| @andreas.schraegle:helsinki-systems.de | * I just use it over localhost | 21:35:41 |
| fadenb | Ah, seems that one must use ?host=/var/run/postgresql and no other format mentioned in the manual :) | 21:36:12 |
| 22 Jun 2022 |
 Ralith | whoever wrote the matrix-synapse release notes, thanks for the hour I just had to spend recovering | 20:44:11 |
| Ralith | "This means that options that are part of your homeserver.yaml configuration, and that were specified at the top-level of the module (services.matrix-synapse) now need to be moved into services.matrix-synapse.settings" is not accurate | 20:44:33 |
| Ralith | in particular database_type and database_args are ignored, and synapes silently defaults back to using sqlite, which not only breaks everything, but also nukes every active user session! | 20:45:45 |
| Ralith | could've lost e2e keys permanently if my backups weren't good | 20:46:05 |
| hexa | feel free to imporve the docs. | 20:46:44 |
| hexa | * feel free to improve the docs. | 20:47:53 |
| Ralith | unfortunately fixing this mess has used up all my available time for such issues and then some | 20:47:55 |
| hexa | # this attribute set holds all values that go into your homeserver.yaml configuration
# See https://github.com/matrix-org/synapse/blob/develop/docs/sample_config.yaml for
# possible values.
| 20:49:50 |
| hexa | the defaults for the database are dependant on the stateVersion | 20:51:43 |
| hexa | < 18.03 was sqlite3 | 20:51:46 |
| hexa |
= 18.03 is postgres
| 20:51:52 |
| hexa | * >= 18.03 is postgres | 20:51:59 |
| hexa | * < 18.03 was sqlite3 | 20:52:03 |
| hexa | database_type and database_args do not match the expected synapse config structure | 20:53:05 |
| hexa | so of course they were ignored | 20:53:08 |
| hexa | https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#database | 20:54:32 |
| Ralith | yes, silly me, taking the release notes at face value | 21:07:14 |
| hexa | (mkRemovedOptionModule [ "services" "matrix-synapse" "database_args" ] "Use settings.database.args instead" )
(mkRemovedOptionModule [ "services" "matrix-synapse" "database_name" ] "Use settings.database.args.database instead" )
(mkRemovedOptionModule [ "services" "matrix-synapse" "database_type" ] "Use settings.database.name instead" )
(mkRemovedOptionModule [ "services" "matrix-synapse" "database_user" ] "Use settings.database.args.user instead" )
| 21:17:59 |
| hexa | the migration of database settings was considered, but apparently nobody noticed that it didn't make it into the release notes | 21:26:41 |
| hexa | also the PR was open for a month and it was annoying to find reviewers, even though matrix-synapse has 7 maintainers | 21:27:27 |
| hexa | * also the PR was open for a month and it was annoying to find reviewers, even though matrix-synapse supposedly has 7 maintainers | 21:28:37 |
