30 Sep 2022 |
Winter (she/her) | doesn't look like it | 17:17:15 |
Winter (she/her) | though i can do more tests when i bump | 17:17:25 |
Winter (she/her) | (i originally disabled them) | 17:17:30 |
Winter (she/her) | * not sure | 17:17:47 |
Winter (she/her) | * i can do more tests when i bump | 17:18:00 |
problems | which tests were failing? i removed the doCheck = false line and didn't see anything fail, but if they're flaky obviously that might not mean much | 17:18:10 |
Winter (she/her) | it was flakiness | 17:18:22 |
Winter (she/her) | not consistent failing | 17:18:25 |
Winter (she/her) | (these can be reproduced on dendrite's ci even, lol.) | 17:19:13 |
problems | yeah, i mainly ask because i remember seeing some prs related to flaky tests a while back | 17:19:39 |
Winter (she/her) | yeah i fixed one of them | 17:19:59 |
Winter (she/her) | ~~(with the help of someone else)~~ | 17:20:10 |
problems | oh huh did i not actually make a pr for my matrix-media-repo module? i thought i did... | 17:20:17 |
Winter (she/her) | but there was at least one other one | 17:20:20 |
problems | that explains why nobody's looked at it yet ;p | 17:20:24 |
Winter (she/her) | lol | 17:20:31 |
problems | oh right i never pr'd it because i had to use a non-release rev | 17:21:10 |
problems | maybe i should poke them to make a release | 17:22:02 |
Winter (she/her) | In reply to @kity:kity.wtf oh right i never pr'd it because i had to use a non-release rev why did you need to use it? | 17:23:02 |
Winter (she/her) | (and do we have it packaged right now as a release version) | 17:23:11 |