30 Sep 2022 |
Winter (she/her) | i'm confused, that option has always been allowed to be set in NODE_OPTIONS, which is evident by it working in element-web | 12:48:32 |
Winter (she/her) | so yes i'd appreciate a reproducible example :) | 12:49:12 |
Winter (she/her) | i have like, one theory that would explain it, hm | 12:50:03 |
Dandellion | It seems it was me using pkgs.fixup_yarn_lock rather than pkgs.unstable.fixup_yarn_lock | 13:01:20 |
Winter (she/her) | Is it possible for you send a reproducible example? Just want to see if my theory is correct. | 13:02:56 |
Dandellion | configurePhase = ''
runHook preConfigure
export HOME=$PWD/tmp
export NODE_OPTIONS=--openssl-legacy-provider
mkdir -p $HOME
${pkgs.fixup_yarn_lock}/bin/fixup_yarn_lock yarn.lock
yarn config --offline set yarn-offline-mirror $offlineCache
yarn install --offline --frozen-lockfile --ignore-platform --ignore-scripts --no-progress --non-interactive
patchShebangs node_modules
# Replace with my matrix-react-sdk
rm -rf node_modules/matrix-react-sdk
ln -s ${matrix-react-sdk} node_modules/matrix-react-sdk
runHook postConfigure
'';
based on summerevans stuff
| 13:05:23 |
Dandellion | with matrix-react-sdk being a callPackaged:
{ lib
, stdenv
, fetchpatch
, fetchFromGitHub
, fetchYarnDeps
, writeText
, jq
, yarn
, fixup_yarn_lock
, nodejs
}: stdenv.mkDerivation rec {
pname = "matrix-react-sdk";
version = "3.57.0";
src = fetchFromGitHub {
owner = "matrix-org";
repo = "matrix-react-sdk";
rev = "v${version}";
sha256 = "sha256-duwjxaS4dKn/GbgykqLdQAjXeBG8kt5dhGa+O9iJacg=";
};
offlineCache = fetchYarnDeps {
yarnLock = src + "/yarn.lock";
sha256 = "sha256-Y/0hyLO78e4KGMfoCRy6bF7tU6rn6LwEcDt5afWTR6U=";
};
patches = [
# All of my patches to matrix-react-sdk
(fetchpatch {
url = "https://github.com/sumnerevans/matrix-react-sdk/commit/ed00c00901c1741042162924bba5e800eee71402.patch";
sha256 = "sha256-YNXRGlTDhYdIeciVRNkERqg366OYVgUaQWFAY9aP1p4=";
})
];
nativeBuildInputs = [ yarn fixup_yarn_lock jq nodejs ];
configurePhase = ''
runHook preConfigure
export HOME=$PWD/tmp
mkdir -p $HOME
fixup_yarn_lock yarn.lock
yarn config --offline set yarn-offline-mirror $offlineCache
yarn install --offline --frozen-lockfile --ignore-platform --ignore-scripts --no-progress --non-interactive
patchShebangs node_modules
runHook postConfigure
'';
buildPhase = ''
runHook preBuild
node_modules/.bin/babel -d lib --verbose --extensions \".ts,.js,.tsx\" src
runHook postBuild
'';
installPhase = ''
runHook preInstall
cp -R . $out
runHook postInstall
'';
}
| 13:07:04 |
Sandro 🐧 | In reply to @winterqt:nixos.dev also wait Sandro 🐧 what were you setting NODE_OPTIONS to? that's not in the version of the hoon you sent, so i don't think it'll reproduce this issue The crash was in element where it is set to NODE_OPTIONS=--openssl-legacy-provider https://github.com/NixOS/nixpkgs/commit/2e3e0081e5e843599aaa8f7128d2a139bda7dbca | 13:07:10 |
Dandellion | it is probably just stable node being a different version than unstable node | 13:09:01 |
Winter (she/her) | In reply to @sandro:supersandro.de The crash was in element where it is set to NODE_OPTIONS=--openssl-legacy-provider https://github.com/NixOS/nixpkgs/commit/2e3e0081e5e843599aaa8f7128d2a139bda7dbca Oh so did you fix it by unsetting it? | 13:09:22 |
Winter (she/her) | in your book | 13:09:27 |
Winter (she/her) | In reply to @dandellion:dodsorf.as it is probably just stable node being a different version than unstable node I'm guessing the issue, at least in Sandro's case, is using Node 14 for svgo, while only Node 18(?) has the option, but the code makes it so invalid options throw that error for whatever reason? | 13:10:37 |
Winter (she/her) | * in your hook | 13:10:49 |
Sandro 🐧 | In reply to @winterqt:nixos.dev Oh so did you fix it by unsetting it? yes | 13:13:25 |
Winter (she/her) | thanks, will take a look at this, may be a valid bug upstream | 13:13:59 |
problems | hey, i just added this to my dendrite config which seems to have helped some issues joining rooms. it's in the sample dendrite config, so i think we should probably have it in our defaults too | 15:40:13 |
Winter (she/her) | In reply to @winterqt:nixos.dev Dendrite 0.10.0 is out. Dendrite 0.10.1 is out. | 16:38:41 |
Winter (she/her) | I can do the upgrade in ~4 hours, if nobody else does by then. | 16:39:13 |
Winter (she/her) | Looks like there are still some issues with it, so maybe they'll be a 0.10.2 by the time I get to it, 😅. (hi problems) | 16:42:54 |
problems | also, has anyone checked if the flaky dendrite tests have been fixed? | 17:16:56 |
Winter (she/her) | doesn't look like it | 17:17:15 |
Winter (she/her) | though i can do more tests when i bump | 17:17:25 |
Winter (she/her) | (i originally disabled them) | 17:17:30 |
Winter (she/her) | * not sure | 17:17:47 |
Winter (she/her) | * i can do more tests when i bump | 17:18:00 |
problems | which tests were failing? i removed the doCheck = false line and didn't see anything fail, but if they're flaky obviously that might not mean much | 17:18:10 |
Winter (she/her) | it was flakiness | 17:18:22 |
Winter (she/her) | not consistent failing | 17:18:25 |
Winter (she/her) | (these can be reproduced on dendrite's ci even, lol.) | 17:19:13 |
problems | yeah, i mainly ask because i remember seeing some prs related to flaky tests a while back | 17:19:39 |