| 28 Sep 2022 |
 Dandellion | I tested my own PR and the diff is identical so I guess it's good | 17:51:50 |
 hexa | feel free to merge I guess? | 17:52:03 |
| Dandellion | If only | 17:52:44 |
| Dandellion | * If only :P | 17:52:52 |
| Dandellion | (Someone with the commit bit will have to do it) | 17:54:04 |
| hexa | (Someone with said commit bit did it) | 17:54:30 |
| hexa | todo: cinny and nheko backport | 18:18:22 |
| hexa | watch out for what schildichat does | 18:18:27 |
| 29 Sep 2022 |
| Dandellion | Sandro 🐧: Did you resolve https://github.com/NixOS/nixpkgs/pull/190950#issuecomment-1261473229 ? I'm getting the same message | 07:59:56 |
 philipp | In reply to @hexa:lossy.network
todo: cinny and nheko backport nheko done https://github.com/NixOS/nixpkgs/pull/193438
schildichat done: https://github.com/NixOS/nixpkgs/pull/193442
(thanks hexa )
| 08:09:31 |
|  problems joined the room. | 17:00:36 |
|  @magnetophon:matrix.org left the room. | 18:40:05 |
 Sandro 🐧 | In reply to @dandellion:dodsorf.as
Sandro 🐧: Did you resolve https://github.com/NixOS/nixpkgs/pull/190950#issuecomment-1261473229 ? I'm getting the same message I've unset NODE_OPTIONS in my hook for the node command run there. I think any node program running in the env after setting NODE_OPTIONS breaks but didn't deeply test this. | 21:52:16 |
| 30 Sep 2022 |
 Winter (she/her) | In reply to @sandro:supersandro.de
I've unset NODE_OPTIONS in my hook for the node command run there. I think any node program running in the env after setting NODE_OPTIONS breaks but didn't deeply test this. what hook, what do you mean? were you modifying the package in some way or something? | 03:14:54 |
| Winter (she/her) | curious ^^ | 03:14:58 |
| Sandro 🐧 | In reply to @winterqt:nixos.dev
what hook, what do you mean? were you modifying the package in some way or something? yes, I am precompressing web assets with brotli and zstd | 12:19:27 |
| Sandro 🐧 | In reply to @winterqt:nixos.dev
what hook, what do you mean? were you modifying the package in some way or something? * yes a custom hook, I am precompressing web assets with brotli and zstd | 12:19:33 |
| Winter (she/her) | ah
can i see it (the old version at least)/get steps to reproduce your issue? want to debug why that's happening :) | 12:20:39 |
| Sandro 🐧 | Add that to nativeBuildInputs of packages and then svgo should complain when NODE_OPTIONS is set.
compress-website = callPackage
({ }: makeSetupHook
{
name = "compress-website";
deps = [ nodePackages.svgo ];
} ./compress-website.sh)
{ };
fixupOutputHooks+=('compressWebsite "$prefix"')
compressWebsite() {
time svgo "$1"
}
| 12:32:12 |
| Winter (she/her) | In reply to @sandro:supersandro.de
Add that to nativeBuildInputs of packages and then svgo should complain when NODE_OPTIONS is set.
compress-website = callPackage
({ }: makeSetupHook
{
name = "compress-website";
deps = [ nodePackages.svgo ];
} ./compress-website.sh)
{ };
fixupOutputHooks+=('compressWebsite "$prefix"')
compressWebsite() {
time svgo "$1"
}
i'll take a look, thanks. | 12:33:04 |
| Winter (she/her) | Dendrite 0.10.0 is out. | 12:33:09 |
| Winter (she/her) | Adds support for full text search -- will require updates to the module to add the options for this. | 12:33:29 |
| Winter (she/her) | I can do the update in a few hours, if nobody else does by then. | 12:33:44 |
| Winter (she/her) | also wait Sandro 🐧 what were you setting NODE_OPTIONS to? that's not in the version of the hoon you sent, so i don't think it'll reproduce this issue | 12:34:23 |
| Winter (she/her) | (i don't see what you'd be setting it to) | 12:36:43 |
| Dandellion | I was getting it by setting the node option in an overrideatttrs configurephase | 12:37:16 |
| Winter (she/her) | what are you setting node_options to | 12:37:32 |
| Winter (she/her) | (plus i don't see why svgo would complain about node_options now if it worked before, sandro -- did you only recently add the node_options setting?) | 12:40:02 |
| Dandellion | https://github.com/NixOS/nixpkgs/blob/8039b055f8ef0693724a9909145f3daf5d762da5/pkgs/applications/networking/instant-messengers/element/element-web.nix#L49 | 12:41:40 |
| Winter (she/her) | Dandellion: https://github.com/nodejs/node/blob/2849283c4cebbfbf523cc24303941dc36df9332f/src/node_options.cc#L924
so it is allowed in NODE_OPTIONS, which is evident by the package building.
what was your overlay? how can i reproduce this? | 12:46:43 |
