Sender | Message | Time |
---|---|---|
30 Sep 2022 | ||
Winter (she/her) | ah can i see it (the old version at least)/get steps to reproduce your issue? want to debug why that's happening :) | 12:20:39 |
Sandro 🐧 | Add that to nativeBuildInputs of packages and then svgo should complain when NODE_OPTIONS is set.
| 12:32:12 |
Winter (she/her) | In reply to @sandro:supersandro.dei'll take a look, thanks. | 12:33:04 |
Winter (she/her) | Dendrite 0.10.0 is out. | 12:33:09 |
Winter (she/her) | Adds support for full text search -- will require updates to the module to add the options for this. | 12:33:29 |
Winter (she/her) | I can do the update in a few hours, if nobody else does by then. | 12:33:44 |
Winter (she/her) | also wait Sandro 🐧 what were you setting NODE_OPTIONS to? that's not in the version of the hoon you sent, so i don't think it'll reproduce this issue | 12:34:23 |
Winter (she/her) | (i don't see what you'd be setting it to) | 12:36:43 |
Dandellion | I was getting it by setting the node option in an overrideatttrs configurephase | 12:37:16 |
Winter (she/her) | what are you setting node_options to | 12:37:32 |
Winter (she/her) | (plus i don't see why svgo would complain about node_options now if it worked before, sandro -- did you only recently add the node_options setting?) | 12:40:02 |
Dandellion | https://github.com/NixOS/nixpkgs/blob/8039b055f8ef0693724a9909145f3daf5d762da5/pkgs/applications/networking/instant-messengers/element/element-web.nix#L49 | 12:41:40 |
Winter (she/her) | Dandellion: https://github.com/nodejs/node/blob/2849283c4cebbfbf523cc24303941dc36df9332f/src/node_options.cc#L924 so it is allowed in NODE_OPTIONS, which is evident by the package building. what was your overlay? how can i reproduce this? | 12:46:43 |
Winter (she/her) | i'm confused, that option has always been allowed to be set in NODE_OPTIONS, which is evident by it working in element-web | 12:48:32 |
Winter (she/her) | so yes i'd appreciate a reproducible example :) | 12:49:12 |
Winter (she/her) | i have like, one theory that would explain it, hm | 12:50:03 |
Dandellion | It seems it was me using pkgs.fixup_yarn_lock rather than pkgs.unstable.fixup_yarn_lock | 13:01:20 |
Winter (she/her) | Is it possible for you send a reproducible example? Just want to see if my theory is correct. | 13:02:56 |
Dandellion |
based on summerevans stuff | 13:05:23 |
Dandellion | with
| 13:07:04 |
Sandro 🐧 | In reply to @winterqt:nixos.devThe crash was in element where it is set to NODE_OPTIONS=--openssl-legacy-provider https://github.com/NixOS/nixpkgs/commit/2e3e0081e5e843599aaa8f7128d2a139bda7dbca | 13:07:10 |
Dandellion | it is probably just stable node being a different version than unstable node | 13:09:01 |
Winter (she/her) | In reply to @sandro:supersandro.deOh so did you fix it by unsetting it? | 13:09:22 |
Winter (she/her) | in your book | 13:09:27 |
Winter (she/her) | In reply to @dandellion:dodsorf.asI'm guessing the issue, at least in Sandro's case, is using Node 14 for svgo, while only Node 18(?) has the option, but the code makes it so invalid options throw that error for whatever reason? | 13:10:37 |
Winter (she/her) | * in your hook | 13:10:49 |
Sandro 🐧 | In reply to @winterqt:nixos.devyes | 13:13:25 |
Winter (she/her) | thanks, will take a look at this, may be a valid bug upstream | 13:13:59 |
problems | hey, i just added this to my dendrite config which seems to have helped some issues joining rooms. it's in the sample dendrite config, so i think we should probably have it in our defaults too | 15:40:13 |
Winter (she/her) | In reply to @winterqt:nixos.devDendrite 0.10.1 is out. | 16:38:41 |