!vxTmkuJzhGPsMdkAOc:transformierende-gesellschaft.org

NixOS Matrix Subsystem

118 Members
Coordination and discussion about the matrix subsystem in NixOS - https://nixos.wiki/wiki/Matrix61 Servers

Load older messages


SenderMessageTime
28 Sep 2022
@hexa:lossy.networkhexa(Someone with said commit bit did it)17:54:30
@hexa:lossy.networkhexatodo: cinny and nheko backport18:18:22
@hexa:lossy.networkhexawatch out for what schildichat does18:18:27
29 Sep 2022
@dandellion:dodsorf.asDandellion Sandro 🐧: Did you resolve https://github.com/NixOS/nixpkgs/pull/190950#issuecomment-1261473229 ? I'm getting the same message 07:59:56
@philipp:xndr.dephilipp
In reply to @hexa:lossy.network
todo: cinny and nheko backport

nheko done https://github.com/NixOS/nixpkgs/pull/193438
schildichat done: https://github.com/NixOS/nixpkgs/pull/193442

(thanks hexa )

08:09:31
@kity:kity.wtfproblems joined the room.17:00:36
@magnetophon:matrix.org@magnetophon:matrix.org left the room.18:40:05
@sandro:supersandro.deSandro 🐧
In reply to @dandellion:dodsorf.as
Sandro 🐧: Did you resolve https://github.com/NixOS/nixpkgs/pull/190950#issuecomment-1261473229 ? I'm getting the same message
I've unset NODE_OPTIONS in my hook for the node command run there. I think any node program running in the env after setting NODE_OPTIONS breaks but didn't deeply test this.
21:52:16
30 Sep 2022
@winterqt:nixos.devWinter (she/her)
In reply to @sandro:supersandro.de
I've unset NODE_OPTIONS in my hook for the node command run there. I think any node program running in the env after setting NODE_OPTIONS breaks but didn't deeply test this.
what hook, what do you mean? were you modifying the package in some way or something?
03:14:54
@winterqt:nixos.devWinter (she/her)curious ^^03:14:58
@sandro:supersandro.deSandro 🐧
In reply to @winterqt:nixos.dev
what hook, what do you mean? were you modifying the package in some way or something?
yes, I am precompressing web assets with brotli and zstd
12:19:27
@sandro:supersandro.deSandro 🐧
In reply to @winterqt:nixos.dev
what hook, what do you mean? were you modifying the package in some way or something?
* yes a custom hook, I am precompressing web assets with brotli and zstd
12:19:33
@winterqt:nixos.devWinter (she/her)

ah

can i see it (the old version at least)/get steps to reproduce your issue? want to debug why that's happening :)

12:20:39
@sandro:supersandro.deSandro 🐧

Add that to nativeBuildInputs of packages and then svgo should complain when NODE_OPTIONS is set.

  compress-website = callPackage
    ({ }: makeSetupHook
      {
        name = "compress-website";
        deps = [ nodePackages.svgo ];
      } ./compress-website.sh)
    { };
fixupOutputHooks+=('compressWebsite "$prefix"')

compressWebsite() {
  time svgo "$1"
}
12:32:12
@winterqt:nixos.devWinter (she/her)
In reply to @sandro:supersandro.de

Add that to nativeBuildInputs of packages and then svgo should complain when NODE_OPTIONS is set.

  compress-website = callPackage
    ({ }: makeSetupHook
      {
        name = "compress-website";
        deps = [ nodePackages.svgo ];
      } ./compress-website.sh)
    { };
fixupOutputHooks+=('compressWebsite "$prefix"')

compressWebsite() {
  time svgo "$1"
}
i'll take a look, thanks.
12:33:04
@winterqt:nixos.devWinter (she/her)Dendrite 0.10.0 is out.12:33:09
@winterqt:nixos.devWinter (she/her)Adds support for full text search -- will require updates to the module to add the options for this.12:33:29
@winterqt:nixos.devWinter (she/her)I can do the update in a few hours, if nobody else does by then.12:33:44
@winterqt:nixos.devWinter (she/her) also wait Sandro 🐧 what were you setting NODE_OPTIONS to? that's not in the version of the hoon you sent, so i don't think it'll reproduce this issue 12:34:23
@winterqt:nixos.devWinter (she/her)(i don't see what you'd be setting it to)12:36:43
@dandellion:dodsorf.asDandellionI was getting it by setting the node option in an overrideatttrs configurephase12:37:16
@winterqt:nixos.devWinter (she/her)what are you setting node_options to12:37:32
@winterqt:nixos.devWinter (she/her)(plus i don't see why svgo would complain about node_options now if it worked before, sandro -- did you only recently add the node_options setting?)12:40:02
@dandellion:dodsorf.asDandellionhttps://github.com/NixOS/nixpkgs/blob/8039b055f8ef0693724a9909145f3daf5d762da5/pkgs/applications/networking/instant-messengers/element/element-web.nix#L4912:41:40
@winterqt:nixos.devWinter (she/her)

Dandellion: https://github.com/nodejs/node/blob/2849283c4cebbfbf523cc24303941dc36df9332f/src/node_options.cc#L924

so it is allowed in NODE_OPTIONS, which is evident by the package building.

what was your overlay? how can i reproduce this?

12:46:43
@winterqt:nixos.devWinter (she/her)i'm confused, that option has always been allowed to be set in NODE_OPTIONS, which is evident by it working in element-web12:48:32
@winterqt:nixos.devWinter (she/her)so yes i'd appreciate a reproducible example :)12:49:12
@winterqt:nixos.devWinter (she/her)i have like, one theory that would explain it, hm12:50:03
@dandellion:dodsorf.asDandellion It seems it was me using pkgs.fixup_yarn_lock rather than pkgs.unstable.fixup_yarn_lock 13:01:20
@winterqt:nixos.devWinter (she/her)Is it possible for you send a reproducible example? Just want to see if my theory is correct.13:02:56

Show newer messages


Back to Room ListRoom Version: 4