!wfudwzqQUiJYJnqfSY:nixos.org

NixOS Module System

150 Members
31 Servers

Load older messages


SenderMessageTime
16 May 2025
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) H'm, do I get a merged value as an input if I addCheck (submodule ...) (def: def?marker_a)?
I just tried adding { foo = { }; } before and after { foo.marker_b = ...; } and it still seems to work
20:28:37
@h7x4:nani.wtfh7x4 I believe the attrs are merged before being typechecked. I suppose you could try adding a lib.trace inside the typecheck to verify? 20:32:31
@ss:someonex.netSomeoneSerge (UTC+U[-12,12])
trace: { below = "_"; }                                                                                                                                                                                              
trace: { marker_b = "bar"; }                                                                                                                                                                                         
trace: { above = "_"; }                                                                                                                                                                                              
trace: { below = "_"; }                                                                                                                                                                                              
{ foo = { above = "_"; below = "_"; marker_b = "bar"; }; } 

For modules:

    { foo = { above = "_"; }; }
    {
      foo.marker_b = "bar";
    }
    { foo = { below = "_"; }; }

20:37:22
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) *
trace: { below = "_"; }                                                                                                                                                                                              
trace: { marker_b = "bar"; }                                                                                                                                                                                         
trace: { above = "_"; }                                                                                                                                                                                              
trace: { below = "_"; }                                                                                                                                                                                              
{ foo = { above = "_"; below = "_"; marker_b = "bar"; }; } 

For modules:

    { foo = { above = "_"; }; }
    {
      foo.marker_b = "bar";
    }
    { foo = { below = "_"; }; }

20:37:32
@mattsturg:matrix.orgMatt Sturgeon

This won't support foo = { config,...}: { marker_b = "bar"; }.

Type checking is done before merging, but after resolving mkIf (etc) wrappers.

Type checking is used to determine which type to use for merging.

20:39:18
@h7x4:nani.wtfh7x4Aha, that makes sense 👍️20:41:25
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) Sounds like __result is least wrong? 20:50:51
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) * Sounds like __result is the least wrong? 20:50:55
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) H'm what if freeformTypes are different? attrsOf a and attrsOf b 20:53:42
@mattsturg:matrix.orgMatt SturgeonI believe the freeform type can be conditional on a marker option being defined without infinite recursion.20:58:27
@mattsturg:matrix.orgMatt SturgeonSo long as the marker options are explicitly defined, they are resolved before freeform definitions 20:59:14
@ss:someonex.netSomeoneSerge (UTC+U[-12,12])Not sure I should depend on this detail 😅20:59:19
@mattsturg:matrix.orgMatt Sturgeon* So long as the marker options are explicitly declared, they are resolved before freeform definitions 20:59:26
@mattsturg:matrix.orgMatt Sturgeon freeformType is itself an option (config._module.freeformType), so it's not really an implementation detail 21:00:17
@mattsturg:matrix.orgMatt Sturgeon
(
  { options, ... }:
  {
    freeformType = attrsOf (
      if options.marker_a.isDefined && options.marker_b.isDefined then
        throw "both `${options.marker_a}' and `${options.marker_b}' are defined"
      else if options.marker_a.isDefined then
        a
      else if options.marker_b.isDefined then
        b
      else
        throw "neither `${options.marker_a}' or `${options.marker_b}' are defined"
    );
  }
)
21:06:01
@mattsturg:matrix.orgMatt Sturgeon _Note: stringifying an option will use it's showOption opt.loc location, so you'll automatically get the full option prefix, e.g. "foo.marker_b" 21:07:27
@mattsturg:matrix.orgMatt Sturgeon * Note: stringifying an option will use it's showOption opt.loc location, so you'll automatically get the full option prefix, e.g. "foo.marker_b" 21:07:39
@ss:someonex.netSomeoneSerge (UTC+U[-12,12])Awe and horror21:41:09
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) I suspect this works and then gets rejected by some kind of a final type check: error: The option marker_a' was accessed but has no value defined. Try setting the option` 22:04:36
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) * I suspect this works and then gets rejected by some kind of a final type check: error: The option `marker_a' was accessed but has no value defined. Try setting the option 22:04:51
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) *

I suspect this works and then gets rejected by some kind of a final type check: error: The option `marker_a' was accessed but has no value defined. Try setting the option

(my attempt: https://gist.github.com/SomeoneSerge/29a9e6e10cdcd3596f865c41c7042610)

22:05:59
@mattsturg:matrix.orgMatt Sturgeon

That's not a type check, that's an "empty value" stub. When an option has no definitions, its value is set to a stub that throws that error.

You're probably reading the value somewhere, e.g. using config.marker_a instead of options.marker_a, or not using removeAttrs when creating __result?

22:06:40
@mattsturg:matrix.orgMatt Sturgeon On line 11 you assign freeformType to a submodule, but freeformType must be an attrsOf type. 22:12:06
@mattsturg:matrix.orgMatt Sturgeon

On line 45 you're defining apply which is meaningless in a module, it's a feature of options.

If you're evaluating these directly with lib.evalModules instead of using a submodule option, you can do the apply manually:

(lib.evalModules { /* ... */ }).config.__result
22:14:08
@ss:someonex.netSomeoneSerge (UTC+U[-12,12])

On line 45 you're defining apply which is meaningless in a module, it's a feature of options.

Yeah I was wondering if I misunderstood the "freeformType is an option"

22:15:13
@ss:someonex.netSomeoneSerge (UTC+U[-12,12])Whoops, the snippet is screwed then I guess22:15:50
@mattsturg:matrix.orgMatt Sturgeon

Here's what I meant by freeformType is an option: https://github.com/NixOS/nixpkgs/blob/ec56f7ae8cdc39eebb8a3b4aa7a3a6365c214fb5/lib/modules.nix#L213-L227

You can set it explicitly in a submodule by defining e.g. config._module.freeformType = attrsOf str, but the module system allows a "shorthand" syntax where freeformType can be defined as a top-level attr in a module and it'll do the conversion to assigning the option for you.

22:17:34
@ss:someonex.netSomeoneSerge (UTC+U[-12,12])

Here's what I meant by freeformType is an option:

Was my second guess. Thanks for walking me through these!

22:19:58
@ss:someonex.netSomeoneSerge (UTC+U[-12,12]) Does work with mkOption indeed: https://gist.github.com/SomeoneSerge/b278317b83e5090fbfa9472c78701703 22:51:20
@mattsturg:matrix.orgMatt Sturgeon

Awesome!

I'd highly recommend checking the marker_a.isDefined && marker_b.isDefined case too, which I assume should be an error?

The else case where neither are defined may need some special handling too: is it an error? Is it still an error if cfg is empty?

22:56:09

Show newer messages


Back to Room ListRoom Version: 10