!yNLbWuxtZEZoUZYwKG:nixos.org

Nix Geospatial Team

33 Members
Nix Geospatial packages maintenance. Team board - https://github.com/orgs/NixOS/projects/47/views/18 Servers

Load older messages


SenderMessageTime
12 Jul 2024
@wcohen:matrix.orgwcohen
In reply to @timlinux:osgeo.org

wcohenunfortunately I left the macOS ecosystem after dabbling in it for 5 years of so, so I can't help much

All good. Thanks!
10:22:43
@imincik:matrix.orgIvan Mincik (imincik)Easy to review QGIS-LTR build fix https://github.com/NixOS/nixpkgs/pull/326550 . 13:27:15
@nh2:matrix.orgnh2gdal is still broken on 24.05: https://github.com/OSGeo/gdal/issues/9887#issuecomment-2225823879 Does Hydra use bcachefs?15:25:15
@nh2:matrix.orgnh2Apparently those tests are known to be flaky: https://github.com/OSGeo/gdal/issues/9887#issuecomment-222584625116:08:52
@imincik:matrix.orgIvan Mincik (imincik) Yes, gdal tests are flaky especially wgen executed under high load. The problem is that by my experience they fail quite randomly. 16:46:01
13 Jul 2024
@nh2:matrix.orgnh2Then they aren't fit for Hydra, we need to disable them. I asked in the ticket which ones those are. 02:39:56
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @nh2:matrix.org
Then they aren't fit for Hydra, we need to disable them.
I asked in the ticket which ones those are.
I would be very happy if we could identify and disable couple of tests which are more likely to fail, but I would feel very uncomfortable to disable all of them.
07:29:25
@imincik:matrix.orgIvan Mincik (imincik) nh2: PDAL update is good to go now https://github.com/NixOS/nixpkgs/pull/323327 08:01:19
@imincik:matrix.orgIvan Mincik (imincik)New team page is live now - https://nixos.org/community/teams/geospatial/ . Please let me know if you want your name to appear/not to appear in the members list ( @sikmir ) . Or any other comments. 15:59:13
14 Jul 2024
@nh2:matrix.orgnh2
In reply to @imincik:matrix.org
I would be very happy if we could identify and disable couple of tests which are more likely to fail, but I would feel very uncomfortable to disable all of them.
Ivan Mincik (imincik): Yes, we should not disable all tests just because some are flaky.
But we should disable all tests that are flaky in any way. Flaky tests cause huge problems: Disabling a large amount of nixpkgs packages, wasting time on Hydra and 1000x that time on users' computers, as well as contributor time.
Fixing flaky tests is an upstream responsibility; we should report the flakiness, disabled them in nixpkgs, and let upstream solve it (or help with that if we have the time).
16:50:18
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @nh2:matrix.org
Ivan Mincik (imincik): Yes, we should not disable all tests just because some are flaky.
But we should disable all tests that are flaky in any way. Flaky tests cause huge problems: Disabling a large amount of nixpkgs packages, wasting time on Hydra and 1000x that time on users' computers, as well as contributor time.
Fixing flaky tests is an upstream responsibility; we should report the flakiness, disabled them in nixpkgs, and let upstream solve it (or help with that if we have the time).
Fully agree
17:18:15
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @nh2:matrix.org
Ivan Mincik (imincik): Yes, we should not disable all tests just because some are flaky.
But we should disable all tests that are flaky in any way. Flaky tests cause huge problems: Disabling a large amount of nixpkgs packages, wasting time on Hydra and 1000x that time on users' computers, as well as contributor time.
Fixing flaky tests is an upstream responsibility; we should report the flakiness, disabled them in nixpkgs, and let upstream solve it (or help with that if we have the time).
Let's create PR where we start disabling all gdal tests which we see failing, keep it open for at least one month and then merge. Repeat if needed. What do you think?
17:23:07
@vengmark2:matrix.orgl0b0
In reply to @imincik:matrix.org
Let's create PR where we start disabling all gdal tests which we see failing, keep it open for at least one month and then merge. Repeat if needed. What do you think?
How about creating a new PR every time someone notices a set of failing tests? That way we can disable flaky tests ASAP, rather than after an arbitrary time.
20:34:24
@vengmark2:matrix.orgl0b0By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests.20:36:07
15 Jul 2024
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @vengmark2:matrix.org
By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests.
Just reporting that. Shame on me, I just spent a week with gdal devs and completely forgot to discuss this issue.
08:22:26
@imincik:matrix.orgIvan Mincik (imincik)I just submitted a PR with some tests re-enabled. https://github.com/NixOS/nixpkgs/pull/32732309:49:21
@imincik:matrix.orgIvan Mincik (imincik) * I just submitted a PR with some gdal tests re-enabled. https://github.com/NixOS/nixpkgs/pull/327323 After that, I'll create a new PR where I start disabling flaky ones.09:50:04
@imincik:matrix.orgIvan Mincik (imincik)Or maybe, better idea, we disable flaky ones in the same PR to avoid too many rebuilds.09:55:03
@imincik:matrix.orgIvan Mincik (imincik)OK, PR updated - https://github.com/NixOS/nixpkgs/pull/32732309:56:16
@nh2:matrix.orgnh2
In reply to @vengmark2:matrix.org
By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests.
For flaky tests I just always file them as upstream issues.
E.g. here: https://github.com/OSGeo/gdal/issues/9887#issuecomment-2225823879
15:13:51
@autra:trancart.euautra
In reply to @imincik:matrix.org

Hi autra , you are very welcome to join. You can learn as you go, start from simple things like reviewing version bumps. I can also provide some onboarding sessions if you are interested.

Please, add yourself to Nixpkgs team list and create a pull request with short introduction of yourself and assign it to me for review. Looking forward to see you around.

done! https://github.com/NixOS/nixpkgs/pull/327419
16:51:18
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @autra:trancart.eu
done! https://github.com/NixOS/nixpkgs/pull/327419
Great ! Left one comment and we can merge.
17:01:52
@imincik:matrix.orgIvan Mincik (imincik) autra: are you interested in onboarding session over video call ? 17:04:34
@autra:trancart.euautra Ivan Mincik (imincik): updated 17:07:06
@autra:trancart.euautra Ivan Mincik (imincik): good idea! I'll see better how I can help this way 17:07:45
17 Jul 2024
@autra:trancart.euautra Ivan Mincik (imincik): when you have build failure on dependant packages (like for geopandas), do you fix them in the same PR? Or do you open subsequent PRs? 11:47:08
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @autra:trancart.eu
Ivan Mincik (imincik): when you have build failure on dependant packages (like for geopandas), do you fix them in the same PR? Or do you open subsequent PRs?

Can be fixed in the same PR or in a new one. Doesn't matter too much. If you personally want to fix some of failures reported in geopandas PR it might be better to open a new PR rather then pushing in PR created by me.

We also ignore failures if we know that they are not caused by current PR. For example, packages like bsuite or plotnine are broken very often because of something else.

12:15:26
@imincik:matrix.orgIvan Mincik (imincik) You can try to build a failed package in master branch to see if it is PR breaking it or it was already broken. 12:17:10
@imincik:matrix.orgIvan Mincik (imincik) I would be happy to see geodatasets and libpysal fixed regardless of what caused the failure. 12:18:39
19 Jul 2024
@autra:trancart.euautra Ivan Mincik (imincik): should we adopt folium and osmnx? 18:25:29

Show newer messages


Back to Room ListRoom Version: 10