!yNLbWuxtZEZoUZYwKG:nixos.org

Nix Geospatial Team

39 Members
Nix Geospatial packages maintenance. Team board - https://github.com/orgs/NixOS/projects/47/views/19 Servers

Load older messages


SenderMessageTime
9 Apr 2024
@imincik:matrix.orgIvan Mincik (imincik)Thanks for adding more packages @sikmir .10:29:56
@ss:someonex.netSomeoneSerge (matrix works sometimes) changed their display name from SomeoneSerge (migrating synapse) to SomeoneSerge (void).13:24:46
25 Apr 2024
@ss:someonex.netSomeoneSerge (matrix works sometimes) changed their display name from SomeoneSerge (void) to SomeoneSerge (UTC+1).23:02:32
29 Apr 2024
@ss:someonex.netSomeoneSerge (matrix works sometimes) changed their display name from SomeoneSerge (UTC+1) to SomeoneSerge (is taking time off and doesn't want to hear about it).11:43:23
@mjolnir:nixos.orgNixOS Moderation Botchanged room power levels.15:28:30
1 May 2024
@mjolnir:nixos.orgNixOS Moderation Botchanged room power levels.15:06:05
4 May 2024
@ss:someonex.netSomeoneSerge (matrix works sometimes) changed their display name from SomeoneSerge (is taking time off and doesn't want to hear about it) to SomeoneSerge (Way down Hadestown).21:03:56
9 May 2024
@ss:someonex.netSomeoneSerge (matrix works sometimes) changed their display name from SomeoneSerge (Way down Hadestown) to SomeoneSerge (UTC+3).17:11:46
15 May 2024
@kidanger:kidanger.net@kidanger:kidanger.net

Hello,
Currently nixpkgs' gdal is missing zstd support. It can be fixed by adding zstd to buildInputs of libtiff:

gdal = pkgs.gdal.override {
  libtiff = pkgs.libtiff.overrideAttrs (attrs: {
    buildInputs = (attrs.buildInputs or []) ++ [pkgs.zstd];
  });
};

(tested with gdalinfo, gdal 3.8.5)

Should I create a PR?

09:45:04
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @kidanger:kidanger.net

Hello,
Currently nixpkgs' gdal is missing zstd support. It can be fixed by adding zstd to buildInputs of libtiff:

gdal = pkgs.gdal.override {
  libtiff = pkgs.libtiff.overrideAttrs (attrs: {
    buildInputs = (attrs.buildInputs or []) ++ [pkgs.zstd];
  });
};

(tested with gdalinfo, gdal 3.8.5)

Should I create a PR?

I think yes, we did the same with lerc in https://github.com/NixOS/nixpkgs/pull/290556/files
10:02:29
@imincik:matrix.orgIvan Mincik (imincik)Please assign myself for PR review. Thanks.10:03:16
@imincik:matrix.orgIvan Mincik (imincik) * Please assign me for PR review. Thanks.10:03:23
@kidanger:kidanger.net@kidanger:kidanger.netdone, https://github.com/NixOS/nixpkgs/pull/31192211:41:32
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @kidanger:kidanger.net
done, https://github.com/NixOS/nixpkgs/pull/311922
Thanks, looks good to me. Are you able to run nixpkgs-review for it ?
12:20:50
@kidanger:kidanger.net@kidanger:kidanger.netI had to use gdalMinimal because right now master requires too many rebuild and I don't have enough disk space. I won't be able to run nixpkgs-review either :/12:21:54
@imincik:matrix.orgIvan Mincik (imincik) kidanger: sorry, I think libtiff PRs need to go to staging. 12:23:08
@kidanger:kidanger.net@kidanger:kidanger.netit should be good now (targeting staging)12:29:29
16 May 2024
@imincik:matrix.orgIvan Mincik (imincik) kidanger: would you please open new PR for zstd ? I had the same problem with mass ping when I tried to re-target between branches (see this recommendation to avoid this issue for the next time). Thank you. 10:25:20
@imincik:matrix.orgIvan Mincik (imincik)Ah, sorry, I see it now https://github.com/NixOS/nixpkgs/pull/31197910:27:28
@kidanger:kidanger.net@kidanger:kidanger.netThanks for the merge!11:02:39
18 May 2024
@sikmir:matrix.orgsikmir
In reply to @imincik:matrix.org
Ah, great. Can I add it to nixpkgs ?
Here it is https://github.com/NixOS/nixpkgs/pull/312708, welcome to review)
17:55:53
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @sikmir:matrix.org
Here it is https://github.com/NixOS/nixpkgs/pull/312708, welcome to review)
Great, I'll review it on Monday. Would you please make sure I am set as the reviewer for this PR?
18:01:53
22 May 2024
@imincik:matrix.orgIvan Mincik (imincik)Trivial to review QGIS version bump - https://github.com/NixOS/nixpkgs/pull/31309706:08:25
@mjolnir:nixos.orgNixOS Moderation Botchanged room power levels.15:25:50
@mjolnir:nixos.orgNixOS Moderation Botchanged room power levels.15:28:05
@imincik:matrix.orgIvan Mincik (imincik)
In reply to @imincik:matrix.org
Trivial to review QGIS version bump - https://github.com/NixOS/nixpkgs/pull/313097
Thank l0b0
16:12:14
23 May 2024
@sikmir:matrix.orgsikmirLooks really hard to package https://github.com/NixOS/nixpkgs/issues/31400514:25:53
@sikmir:matrix.orgsikmirJust in case, I'm almost done with packaging mapclassify and libpysal https://github.com/NixOS/nixpkgs/issues/26009914:28:44
@vengmark2:matrix.orgl0b0

Hi guys, just wondering what you consider an appropriate level of PR review for bot-generated patch releases like libgeotiff: 1.7.1 -> 1.7.2. Some things to consider:

  • Anybody doing a review has finite time, and want to do the best possible job in that finite time.
  • Somewhere between 11 and 100 packages rely on this one, as detected by ofborg. So the impact of a broken package isn't tiny.
  • The package passthru tests are run automatically, but it's hard to gauge at a glance whether those are as complete as they should be, because it's not like we report some kind of coverage front and centre.
  • I don't think NixOS tests are typically linked to the package passthru tests, so it's non-trivial to figure out whether any NixOS tests should be run for a particular PR. Do you have any tricks/heuristics for figuring out which tests to run, better than rg libgeotiff nixos/tests (which won't detect tests of packages which depend on libgeotiff)?
20:35:41
@vengmark2:matrix.orgl0b0 *

Hi guys, just wondering what you consider an appropriate level of PR review for bot-generated patch releases like libgeotiff: 1.7.1 -> 1.7.2. Some things to consider:

  • Anybody doing a review has finite time, and want to do the best possible job in that finite time.
  • Somewhere between 11 and 100 packages rely on this one, as detected by ofborg. So the impact of a broken package isn't tiny.
  • The package passthru tests are run automatically, but it's hard to gauge at a glance whether those are as complete as they should be, because it's not like we report some kind of coverage front and centre.
  • I don't think NixOS tests are typically linked to the package passthru tests, so it's non-trivial to figure out whether any NixOS tests should be run for a particular PR. Do you have any tricks/heuristics for figuring out which tests to run, better than rg libgeotiff nixos/tests (which won't detect tests of packages which depend on libgeotiff)?
  • If a rubber stamp of "the build passes" is considered sufficient, why don't we automate the merging of such PRs?
20:36:56

Show newer messages


Back to Room ListRoom Version: 10