| 14 Jul 2024 |
 l0b0 | In reply to @imincik:matrix.org
Let's create PR where we start disabling all gdal tests which we see failing, keep it open for at least one month and then merge. Repeat if needed. What do you think? How about creating a new PR every time someone notices a set of failing tests? That way we can disable flaky tests ASAP, rather than after an arbitrary time. | 20:34:24 |
| l0b0 | By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests. | 20:36:07 |
| 15 Jul 2024 |
 Ivan Mincik (imincik) | In reply to @vengmark2:matrix.org
By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests. Just reporting that. Shame on me, I just spent a week with gdal devs and completely forgot to discuss this issue. | 08:22:26 |
| Ivan Mincik (imincik) | I just submitted a PR with some tests re-enabled. https://github.com/NixOS/nixpkgs/pull/327323 | 09:49:21 |
| Ivan Mincik (imincik) | * I just submitted a PR with some gdal tests re-enabled. https://github.com/NixOS/nixpkgs/pull/327323
After that, I'll create a new PR where I start disabling flaky ones. | 09:50:04 |
| Ivan Mincik (imincik) | Or maybe, better idea, we disable flaky ones in the same PR to avoid too many rebuilds. | 09:55:03 |
| Ivan Mincik (imincik) | OK, PR updated - https://github.com/NixOS/nixpkgs/pull/327323 | 09:56:16 |
 nh2 | In reply to @vengmark2:matrix.org
By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests. For flaky tests I just always file them as upstream issues.
E.g. here: https://github.com/OSGeo/gdal/issues/9887#issuecomment-2225823879 | 15:13:51 |
 autra | In reply to @imincik:matrix.org
Hi autra , you are very welcome to join. You can learn as you go, start from simple things like reviewing version bumps. I can also provide some onboarding sessions if you are interested.
Please, add yourself to Nixpkgs team list and create a pull request with short introduction of yourself and assign it to me for review. Looking forward to see you around.
done! https://github.com/NixOS/nixpkgs/pull/327419 | 16:51:18 |
| Ivan Mincik (imincik) | In reply to @autra:trancart.eu
done! https://github.com/NixOS/nixpkgs/pull/327419 Great ! Left one comment and we can merge. | 17:01:52 |
| Ivan Mincik (imincik) | autra: are you interested in onboarding session over video call ? | 17:04:34 |
| autra | Ivan Mincik (imincik): updated | 17:07:06 |
| autra | Ivan Mincik (imincik): good idea! I'll see better how I can help this way | 17:07:45 |
| 17 Jul 2024 |
| autra | Ivan Mincik (imincik): when you have build failure on dependant packages (like for geopandas), do you fix them in the same PR? Or do you open subsequent PRs? | 11:47:08 |
| Ivan Mincik (imincik) | In reply to @autra:trancart.eu
Ivan Mincik (imincik): when you have build failure on dependant packages (like for geopandas), do you fix them in the same PR? Or do you open subsequent PRs? Can be fixed in the same PR or in a new one. Doesn't matter too much. If you personally want to fix some of failures reported in geopandas PR it might be better to open a new PR rather then pushing in PR created by me.
We also ignore failures if we know that they are not caused by current PR. For example, packages like bsuite or plotnine are broken very often because of something else.
| 12:15:26 |
| Ivan Mincik (imincik) | You can try to build a failed package in master branch to see if it is PR breaking it or it was already broken. | 12:17:10 |
| Ivan Mincik (imincik) | I would be happy to see geodatasets and libpysal fixed regardless of what caused the failure. | 12:18:39 |
| 19 Jul 2024 |
| autra | Ivan Mincik (imincik): should we adopt folium and osmnx? | 18:25:29 |
| Ivan Mincik (imincik) | In reply to @autra:trancart.eu
Ivan Mincik (imincik): should we adopt folium and osmnx? Yes, I think so. Adoption should contain some QA - package works correctly and is covered by tests. | 19:09:33 |
| 20 Jul 2024 |
| autra | In reply to @imincik:matrix.org
I would be happy to see geodatasets and libpysal fixed regardless of what caused the failure. Are they broken? They seem ok to me. | 12:26:47 |
| 21 Jul 2024 |
 sikmir | Just in case, maybe interesting for geospatial team https://github.com/NixOS/nixpkgs/pull/328819 | 08:36:39 |
| 22 Jul 2024 |
| autra | indeed! I'd split this MR in several smaller one to ease the review though 😅 | 13:12:48 |
| * autra just reviewed a +5000 - 3000 lines PR from a colleague, that might explain my current feeling! | 13:13:26 |
| autra | nice to see parquet format coming to nixpkgs, it'll be useful :-) | 13:22:45 |
| Ivan Mincik (imincik) | I am on family holiday during this week. I will be less responsive than usual. | 14:01:28 |
| Ivan Mincik (imincik) | Shapely update looks good to go. Please review. Thanks. | 15:12:31 |
| 23 Jul 2024 |
| autra | Ivan Mincik (imincik): hi! when a PR is approved, we can ping the merge bot to have it merged right? | 07:37:53 |
|  Ezzobir Bezziou joined the room. | 08:21:45 |
| Ivan Mincik (imincik) | In reply to @autra:trancart.eu
Ivan Mincik (imincik): hi! when a PR is approved, we can ping the merge bot to have it merged right? You can always ping me for merging. | 11:32:22 |
| Ivan Mincik (imincik) | In reply to @autra:trancart.eu
Ivan Mincik (imincik): hi! when a PR is approved, we can ping the merge bot to have it merged right? Merge bot works only for PRs created by ryantm bot. | 11:35:41 |
