Nix Geospatial Team | 37 Members | |
| Nix Geospatial packages maintenance. Team board - https://github.com/orgs/NixOS/projects/47/views/1 | 8 Servers |
| Sender | Message | Time |
|---|---|---|
| 13 Jul 2024 | ||
In reply to @nh2:matrix.orgI would be very happy if we could identify and disable couple of tests which are more likely to fail, but I would feel very uncomfortable to disable all of them. | 07:29:25 | |
| nh2: PDAL update is good to go now https://github.com/NixOS/nixpkgs/pull/323327 | 08:01:19 | |
| New team page is live now - https://nixos.org/community/teams/geospatial/ . Please let me know if you want your name to appear/not to appear in the members list ( @sikmir ) . Or any other comments. | 15:59:13 | |
| 14 Jul 2024 | ||
In reply to @imincik:matrix.orgIvan Mincik (imincik): Yes, we should not disable all tests just because some are flaky. But we should disable all tests that are flaky in any way. Flaky tests cause huge problems: Disabling a large amount of nixpkgs packages, wasting time on Hydra and 1000x that time on users' computers, as well as contributor time. Fixing flaky tests is an upstream responsibility; we should report the flakiness, disabled them in nixpkgs, and let upstream solve it (or help with that if we have the time). | 16:50:18 | |
In reply to @nh2:matrix.orgFully agree | 17:18:15 | |
In reply to @nh2:matrix.orgLet's create PR where we start disabling all gdal tests which we see failing, keep it open for at least one month and then merge. Repeat if needed. What do you think? | 17:23:07 | |
In reply to @imincik:matrix.orgHow about creating a new PR every time someone notices a set of failing tests? That way we can disable flaky tests ASAP, rather than after an arbitrary time. | 20:34:24 | |
| By the way, do we have some sort of simple upstream feedback mechanism? Passing flaky tests onto upstream should hopefully result in less flaky tests. | 20:36:07 | |
| 15 Jul 2024 | ||
In reply to @vengmark2:matrix.orgJust reporting that. Shame on me, I just spent a week with gdal devs and completely forgot to discuss this issue. | 08:22:26 | |
| I just submitted a PR with some tests re-enabled. https://github.com/NixOS/nixpkgs/pull/327323 | 09:49:21 | |
| * I just submitted a PR with some gdal tests re-enabled. https://github.com/NixOS/nixpkgs/pull/327323 After that, I'll create a new PR where I start disabling flaky ones. | 09:50:04 | |
| Or maybe, better idea, we disable flaky ones in the same PR to avoid too many rebuilds. | 09:55:03 | |
| OK, PR updated - https://github.com/NixOS/nixpkgs/pull/327323 | 09:56:16 | |
In reply to @vengmark2:matrix.orgFor flaky tests I just always file them as upstream issues. E.g. here: https://github.com/OSGeo/gdal/issues/9887#issuecomment-2225823879 | 15:13:51 | |
In reply to @imincik:matrix.orgdone! https://github.com/NixOS/nixpkgs/pull/327419 | 16:51:18 | |
In reply to @autra:trancart.euGreat ! Left one comment and we can merge. | 17:01:52 | |
| autra: are you interested in onboarding session over video call ? | 17:04:34 | |
| Ivan Mincik (imincik): updated | 17:07:06 | |
| Ivan Mincik (imincik): good idea! I'll see better how I can help this way | 17:07:45 | |
| 17 Jul 2024 | ||
| Ivan Mincik (imincik): when you have build failure on dependant packages (like for geopandas), do you fix them in the same PR? Or do you open subsequent PRs? | 11:47:08 | |
In reply to @autra:trancart.eu Can be fixed in the same PR or in a new one. Doesn't matter too much. If you personally want to fix some of failures reported in geopandas PR it might be better to open a new PR rather then pushing in PR created by me. We also ignore failures if we know that they are not caused by current PR. For example, packages like | 12:15:26 | |
You can try to build a failed package in master branch to see if it is PR breaking it or it was already broken. | 12:17:10 | |
I would be happy to see geodatasets and libpysal fixed regardless of what caused the failure. | 12:18:39 | |
| 19 Jul 2024 | ||
| Ivan Mincik (imincik): should we adopt folium and osmnx? | 18:25:29 | |
In reply to @autra:trancart.euYes, I think so. Adoption should contain some QA - package works correctly and is covered by tests. | 19:09:33 | |
| 20 Jul 2024 | ||
In reply to @imincik:matrix.orgAre they broken? They seem ok to me. | 12:26:47 | |
| 21 Jul 2024 | ||
| Just in case, maybe interesting for geospatial team https://github.com/NixOS/nixpkgs/pull/328819 | 08:36:39 | |
| 22 Jul 2024 | ||
| indeed! I'd split this MR in several smaller one to ease the review though 😅 | 13:12:48 | |
| * | 13:13:26 | |
| nice to see parquet format coming to nixpkgs, it'll be useful :-) | 13:22:45 | |