!yUrHuDcxUngfTlDbiy:matrix.org

flakelight

38 Members
https://github.com/nix-community/flakelight12 Servers

Load older messages


SenderMessageTime
15 Mar 2024
@accelbread:matrix.orgaccelbreaddo you know which subset of files is being picked up? ah15:27:50
@cmacr.ae:matrix.orgcmacraeyeah, I mean I legit have no idea what I'm doing haha, i've never really used rust properly15:28:08
@accelbread:matrix.orgaccelbreadI'm wondering is it might be due to how crane works 15:28:34
@cmacr.ae:matrix.orgcmacrae
In reply to @accelbread:matrix.org
do you know which subset of files is being picked up?
ah
all the rust related stuff! so that's good, the default filter is working
15:28:35
@accelbread:matrix.orgaccelbreadAh15:28:41
@accelbread:matrix.orgaccelbreadSo probably not a crane issue15:28:55
@cmacr.ae:matrix.orgcmacraenope :) let me try and get a different filter working and report back15:29:13
@accelbread:matrix.orgaccelbread

one thing you can try to debug is set:

15:29:30
@accelbread:matrix.orgaccelbread
{
  inputs.flakelight-rust.url = "github:accelbread/flakelight-rust";
  outputs = { flakelight-rust, ... }:
    flakelight-rust ./. ({ lib, outputs, ... }: {
      fileset = ./.;
      outputs.test = lib.fileset.toList outputs.fileset;
    });
}

and nix eval .#test

15:32:04
@accelbread:matrix.orgaccelbreadneed a recent nixpkgs for toList; one shipped with flakelight has it already iirc15:32:39
@accelbread:matrix.orgaccelbread * need a very recent nixpkgs for toList; one shipped with flakelight has it already iirce15:32:51
@accelbread:matrix.orgaccelbread * need a very recent nixpkgs for toList; one shipped with flakelight has it already iirc15:32:55
@cmacr.ae:matrix.orgcmacraeah nice, that's really handy, thanks!15:33:33
@cmacr.ae:matrix.orgcmacrae

doesn't seem like fileset is being honoured/evaluated correctly when I'm setting it like so:

  outputs = { flakelight, flakelight-rust, devenv, ... }@inputs:
    flakelight ./. ({ pkgs, lib, outputs, ... }: {
      imports = [ flakelight-rust.flakelightModules.default ];
      systems = lib.systems.flakeExposed;
      fileset = ./.;

tried mkForceing it in case, that didn't work either

15:48:30
@cmacr.ae:matrix.orgcmacrae the handy test output you provided showed that I was able to filter how I wanted. but when the build fails for the cargo stuff, I take a look at the log, get the build env's source tree and look in there, there's only rust related contents, even though I set the filter to ./. 15:49:47
@accelbread:matrix.orgaccelbreadhuh, should just be using it here: https://github.com/accelbread/flakelight-rust/blob/master/flakelight-rust.nix doesnt seem like crane is overriding anything15:52:14
@accelbread:matrix.orgaccelbread if you point at a fork of flakelight-rust with that line swapped with inherit src; would that work?
i'll mess around with it in a bit too to see if I can figure it out
15:54:14
@cmacr.ae:matrix.orgcmacraegood idea :) let me give that a go15:55:34
@cmacr.ae:matrix.orgcmacraethanks! I appreciate it!15:55:40
@cmacr.ae:matrix.orgcmacrae hmm, weird, no even with just inherit src; in the crane call the filetree is the same (filtered rust related stuff). that seems completely wrong, based on that change. so, let me dig around and make sure I'm not doing anything stupid 16:00:37
@cmacr.ae:matrix.orgcmacraewait, nope, yeah I did something stupid 🤦‍♂️ignore this ☝️16:01:32
@cmacr.ae:matrix.orgcmacrae

hmm, okay, still no luck - every time the source tree is the same, even with inherit src here:

package = { craneLib, cargoArtifacts, defaultMeta }:
        craneLib.buildPackage {
          inherit src;  # <-- here
          inherit cargoArtifacts;
          doCheck = false;
          strictDeps = true;
          meta = defaultMeta;
        };
16:06:20
@accelbread:matrix.orgaccelbreadHuh, that probably means crane is filtering the source17:21:57
@accelbread:matrix.orgaccelbreadI'll see if thats the case and if it can be disabled17:22:10
@accelbread:matrix.orgaccelbread(and maybe switch off crane; people at NixCon were mentioning might be better to use no-cargo instead)17:22:37
@accelbread:matrix.orgaccelbreadhttps://github.com/ipetkov/crane/blob/10484f86201bb94bd61ecc5335b1496794fedb78/docs/source-filtering.md?plain=1#L24 17:23:53
@accelbread:matrix.orgaccelbreadAh yeah, seems will have to turn this crane feature off in flakelight-rust17:24:15
@accelbread:matrix.orgaccelbreadactually hmm that seems opt-in17:29:27
@accelbread:matrix.orgaccelbreadMaybe https://github.com/ipetkov/crane/issues/352?17:32:02
@cmacr.ae:matrix.orgcmacraeahh, interesting, yeah it's possibly related to the above issue (although it's closed, haha)17:33:24

Show newer messages


Back to Room ListRoom Version: 10