| 15 Mar 2024 |
 cmacrae | the handy test output you provided showed that I was able to filter how I wanted. but when the build fails for the cargo stuff, I take a look at the log, get the build env's source tree and look in there, there's only rust related contents, even though I set the filter to ./. | 15:49:47 |
 accelbread | huh, should just be using it here: https://github.com/accelbread/flakelight-rust/blob/master/flakelight-rust.nix
doesnt seem like crane is overriding anything | 15:52:14 |
| accelbread | if you point at a fork of flakelight-rust with that line swapped with inherit src; would that work?
i'll mess around with it in a bit too to see if I can figure it out | 15:54:14 |
| cmacrae | good idea :) let me give that a go | 15:55:34 |
| cmacrae | thanks! I appreciate it! | 15:55:40 |
| cmacrae | hmm, weird, no even with just inherit src; in the crane call the filetree is the same (filtered rust related stuff). that seems completely wrong, based on that change. so, let me dig around and make sure I'm not doing anything stupid | 16:00:37 |
| cmacrae | wait, nope, yeah I did something stupid 🤦♂️ignore this ☝️ | 16:01:32 |
| cmacrae | hmm, okay, still no luck - every time the source tree is the same, even with inherit src here:
package = { craneLib, cargoArtifacts, defaultMeta }:
craneLib.buildPackage {
inherit src; # <-- here
inherit cargoArtifacts;
doCheck = false;
strictDeps = true;
meta = defaultMeta;
};
| 16:06:20 |
| accelbread | Huh, that probably means crane is filtering the source | 17:21:57 |
| accelbread | I'll see if thats the case and if it can be disabled | 17:22:10 |
| accelbread | (and maybe switch off crane; people at NixCon were mentioning might be better to use no-cargo instead) | 17:22:37 |
| accelbread | https://github.com/ipetkov/crane/blob/10484f86201bb94bd61ecc5335b1496794fedb78/docs/source-filtering.md?plain=1#L24
| 17:23:53 |
| accelbread | Ah yeah, seems will have to turn this crane feature off in flakelight-rust | 17:24:15 |
| accelbread | actually hmm that seems opt-in | 17:29:27 |
| accelbread | Maybe https://github.com/ipetkov/crane/issues/352? | 17:32:02 |
| cmacrae | ahh, interesting, yeah it's possibly related to the above issue (although it's closed, haha) | 17:33:24 |
| cmacrae | what's 'no-cargo'? is that a nix rust abstraction? | 17:33:41 |
| cmacrae | https://github.com/oxalica/nocargo this? | 17:33:59 |
| accelbread | Yeah | 17:34:06 |
| cmacrae | oh cool, not seen this before | 17:34:14 |
| accelbread | I hadn;t heard of it either but people said it has better caching for deps than crane | 17:34:49 |
| 19 Mar 2024 |
|  NixOS Moderation Botchanged room power levels. | 00:29:56 |
| 21 Mar 2024 |
| NixOS Moderation Botchanged room power levels. | 18:02:53 |
| 24 Mar 2024 |
|  @psvo:matrix.org joined the room. | 23:06:35 |
| accelbread | cmacrae: Not sure about how to make crane not filter deps; might have to open an issue there. Been busy, apologies for late reply
Looking into using nocargo as well, seems better, though may need some work to make it usable | 23:10:26 |
| accelbread | Do you have an example of how the file is included? is it include_str! or include_bytes!? or is Cargo.toml somehow importing it? | 23:41:43 |
| accelbread | Yeah with include_str/bytes, I'm getting expected behavior of just the fileset applying, so unsure how to reproduce the issue | 23:56:44 |
| 25 Mar 2024 |
| cmacrae | no need for apologies! I wasn't expecting anything :) I've had to switch focus to some other stuff for now, so will go spelunking with Nix/Rust stuff then 👍️
definitely curious about nocargo | 14:29:29 |
| 27 Mar 2024 |
|  Vicenzo Giuseppe joined the room. | 09:04:01 |
| 29 Mar 2024 |
|  SebTM joined the room. | 05:40:41 |
