| 4 Dec 2024 |
 Picnoir | I keep the refactoring in my git stash for now. I'll push it once we're done with https://github.com/maralorn/nix-output-monitor/pull/162 | 10:49:50 |
| Picnoir | It do not seem like I did something very very stupid perf wise. | 10:50:15 |
| Picnoir | I'm not super sure about the help screen part, there's maybe a better way to do it. | 10:55:45 |
 maralorn | In reply to @picnoir:alternativebit.fr
I'm not super sure about the help screen part, there's maybe a better way to do it. Yeah, that part is problematic. It has been for now my iron rule that nom will not destroy the backlog of the build. So calling clearScreen is not something I want to do. | 10:57:33 |
| Picnoir | Right | 10:57:52 |
| Picnoir | Makes sense | 10:58:07 |
| maralorn | Rather the help should somehow appear in / replace the usual info box. | 10:58:24 |
| maralorn | I think I would put it in the info box right above the summary but below warnings and the tree. | 10:59:23 |
| maralorn | We should also show add "?: help" somewhere in the normal output. | 11:00:14 |
| maralorn | * We should also add "?: help" somewhere in the normal output. | 11:00:25 |
| maralorn | In reply to @maralorn:maralorn.de
We should also add "?: help" somewhere in the normal output. But that’s optional for later. | 11:04:29 |
| Picnoir | 👍️ | 11:05:34 |
| Picnoir | In reply to @maralorn:maralorn.de
Rather the help should somehow appear in / replace the usual info box. Do we already have some code clearing the info box? | 11:06:08 |
| Picnoir | In reply to @maralorn:maralorn.de
Rather the help should somehow appear in / replace the usual info box. * Do we already have some code clearing/printing the info box? | 11:06:14 |
| Picnoir | ^ stupid question, we have, the real question is "could you point me to that?" :D | 11:06:31 |
| maralorn | Well, the code currently clears and prints the infobox. If you make the help message part of the infobox (which should be easy because you are already propagating PrintState to that function) then the rest of the code will automatically take care of everything. | 11:07:33 |
| maralorn | Really, now that I think about it. Other than the input and the printState you shouldn’t need to touch the IO module. | 11:08:31 |
| Picnoir | We need to force the print when a user pushes a key. | 11:13:24 |
| Picnoir | Otherwise we're waiting on the next nix log line/timestamp to reprint. | 11:13:42 |
| Picnoir | It feels weird feedback-wise. | 11:13:48 |
| Picnoir | * It feels weird feedback-wise if we don't. | 11:14:48 |
| maralorn | Yeah, that’s okay, too. | 11:18:11 |
| maralorn | Redacted or Malformed Event | 11:18:51 |
| maralorn | Redacted or Malformed Event | 11:20:14 |
| maralorn | * I think waiting the worst case 60ms is fine, though isn’t it? | 11:20:20 |
| Picnoir | Heh, if we want a nice helpl print, we'll have to abstract a few functions in printBuilds to get the nice titles and all. | 11:46:22 |
| Picnoir | Too much work to do it rn for me >< | 11:46:34 |
| Picnoir | * That's too much work to do it rn for me >< | 11:46:52 |
| Picnoir | I'll come back to it later. | 11:46:56 |
| maralorn | In reply to @picnoir:alternativebit.fr
Heh, if we want a nice helpl print, we'll have to abstract a few functions in printBuilds to get the nice titles and all. Yeah, abstracting the printing stuff in a sane way is definitely on my wishlist. | 11:48:03 |
