| 4 Dec 2024 |
 Picnoir | Yeah, builds are usually printing quite often anyways. | 09:31:40 |
| Picnoir | This PR start to scope creep on my end, started a refactoring to clear a bit writeStateToScreen and have a single tmvar blocking the printer until something new to print appears. | 09:32:23 |
| Picnoir | Let's remove this refactoring from this PR and get this merged first. | 09:32:36 |
| Picnoir | I'll make a quick hyperfine bench run to make sure I'm not breaking perf too much. | 09:34:38 |
| Picnoir | In reply to @picnoir:alternativebit.fr
Let's remove this refactoring from this PR and get this merged first. (I'll keep a few variables remame in the end, I don't think it'll add too much review burden) | 09:35:10 |
 maralorn | Picnoir: I appreciate all refactorings, but small PRs are definitely better.
The printing code is the part of the code base which I am least proud off. It became an ugly chimera because it is not very sensitive but changed probably the most.
| 10:05:37 |
| Picnoir | Yeah, definitely, I'm splitting to keep it small. | 10:12:02 |
| Picnoir | (implementing help and freeze atm, I'm almost done) | 10:12:16 |
| Picnoir | The freeze feature without a visual feedback is probably a footgun 😅 | 10:35:15 |
| Picnoir | Redacted or Malformed Event | 10:35:31 |
| maralorn | Bug report: "nix-output-monitor hangs when pressing f" 😄 | 10:42:08 |
| Picnoir | "maralorn assigned this issue to @picnoir" | 10:44:02 |
| Picnoir | :D | 10:44:03 |
| Picnoir | Alright, I think this is ready for review. | 10:49:28 |
| Picnoir | I keep the refactoring in my git stash for now. I'll push it once we're done with https://github.com/maralorn/nix-output-monitor/pull/162 | 10:49:50 |
| Picnoir | It do not seem like I did something very very stupid perf wise. | 10:50:15 |
| Picnoir | I'm not super sure about the help screen part, there's maybe a better way to do it. | 10:55:45 |
| maralorn | In reply to @picnoir:alternativebit.fr
I'm not super sure about the help screen part, there's maybe a better way to do it. Yeah, that part is problematic. It has been for now my iron rule that nom will not destroy the backlog of the build. So calling clearScreen is not something I want to do. | 10:57:33 |
| Picnoir | Right | 10:57:52 |
| Picnoir | Makes sense | 10:58:07 |
| maralorn | Rather the help should somehow appear in / replace the usual info box. | 10:58:24 |
| maralorn | I think I would put it in the info box right above the summary but below warnings and the tree. | 10:59:23 |
| maralorn | We should also show add "?: help" somewhere in the normal output. | 11:00:14 |
| maralorn | * We should also add "?: help" somewhere in the normal output. | 11:00:25 |
| maralorn | In reply to @maralorn:maralorn.de
We should also add "?: help" somewhere in the normal output. But that’s optional for later. | 11:04:29 |
| Picnoir | 👍️ | 11:05:34 |
| Picnoir | In reply to @maralorn:maralorn.de
Rather the help should somehow appear in / replace the usual info box. Do we already have some code clearing the info box? | 11:06:08 |
| Picnoir | In reply to @maralorn:maralorn.de
Rather the help should somehow appear in / replace the usual info box. * Do we already have some code clearing/printing the info box? | 11:06:14 |
| Picnoir | ^ stupid question, we have, the real question is "could you point me to that?" :D | 11:06:31 |
| maralorn | Well, the code currently clears and prints the infobox. If you make the help message part of the infobox (which should be easy because you are already propagating PrintState to that function) then the rest of the code will automatically take care of everything. | 11:07:33 |
