| 16 Aug 2021 |
| Finn Behrens (he/him) changed their display name from Finn Behrens to Finn Behrens (he/him). | 20:40:48 |
| 17 Aug 2021 |
@grahamc:nixos.org | das_j: is your hydra public? | 13:50:59 |
das_j | In reply to @grahamc:nixos.org das_j: is your hydra public? It's not and I don't think it ever will since it's processing customer-relevant data | 13:54:07 |
@grahamc:nixos.org | cool | 13:54:16 |
das_j | Well depends | 13:54:21 |
das_j | Also I don't really trust it security-wise ;) | 13:54:29 |
@grahamc:nixos.org | I ask because I somewhat suspect your "restart components" PR makes it possible to restart components without being logged in... not totally sure the behavior of chaining on admin | 13:54:52 |
das_j | well I stole it from sub news_submit : Chained('admin') PathPart('news/submit') Args(0) { because I thought that would be secure | 13:55:49 |
das_j | I haven't seen anyone who is not admin submitting news | 13:56:03 |
@grahamc:nixos.org | ah gotcha | 13:56:17 |
@grahamc:nixos.org | yeah probably | 13:56:45 |
das_j | I do hope so :D | 13:56:56 |
das_j | Btw, is the eval-triggering API endpoint protected now? | 13:57:10 |
@grahamc:nixos.org | no | 18:51:23 |
| 18 Aug 2021 |
| p10r left the room. | 00:38:03 |
@grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1001 | 19:46:17 |
@grahamc:nixos.org | RFR as always ... :P | 19:51:53 |
| 19 Aug 2021 |
| hexagonk joined the room. | 02:38:55 |
@grahamc:nixos.org | ugh I peppered "use warnings" around and it is a lot | 20:59:00 |
@grahamc:nixos.org | Anyone know automake? I made this change:
https://github.com/NixOS/hydra/pull/1002/files#diff-0462e381b2fb3286568215681c8983490a37ac9ae0f0c5ee304df7fa6426d4af
and after it runs perlcritic . it errors with:
/nix/store/kxj6cblcsd1qcbbxlmbswwrn89zcmgd6-bash-4.4-p23/bin/bash: line 9: ./perlcritic: No such file or directory
FAIL: perlcritic
==================
1 of 1 test failed
==================
note I don't know automake, so this was totally a shot in the dark.
| 21:07:18 |
tomberek | grahamc (he/him): the syntax/style-checker isn't in scope? perlPackages.PerlCritic | 21:13:53 |
@grahamc:nixos.org | it is in scope, that error message is immediately after successfully running perlcritic, but it isn't available at ./perlcritic of course | 21:15:16 |
andi- | Perhaps since it is in the TESTS list? I haven't looked into the details but I could imagine the test scripts being "built" and then execute them | 21:16:42 |
andi- | keep in mind that make targets usually are there for producing said target | 21:17:01 |
@grahamc:nixos.org | right | 21:17:22 |
@grahamc:nixos.org | yeah, I don't really know how automake expects to be used to make this thing get called | 21:17:36 |
@grahamc:nixos.org | does automake automatically call all the targets? | 21:17:44 |
tomberek | i believe TESTS will be turned into targets that are called. https://www.gnu.org/software/automake/manual/html_node/Tests.html | 21:19:18 |
tomberek | oh, i see what you mean | 21:21:45 |
tomberek | PL_LOG_COMPILER | 21:24:48 |