!zghijEASpYQWYFzriI:nixos.org

Hydra

373 Members
109 Servers

Load older messages


SenderMessageTime
15 Nov 2024
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
if you like it, feel free to hit the merge button
I will take a look this weekend I hope. If I don't, feel free to ping and annoy me again because I likely forgot ;) I'll do my best reviewing the change
21:42:10
@Ericson2314:matrix.orgJohn EricsonOK thanks!21:42:19
@Ericson2314:matrix.orgJohn Ericsonall the code is due to the lix people, who are already using this21:42:29
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
OK thanks!
No, thank you for upstreaming all that work
21:42:41
@Ericson2314:matrix.orgJohn EricsonI just changed nix-eval-jobs (already merged) and stuff in the flake21:42:43
@Ericson2314:matrix.orgJohn Ericsonso feel free to give it a quick and dirty review21:42:56
@Ericson2314:matrix.orgJohn Ericsonsince the code is already in production....somewhere21:43:02
@Ericson2314:matrix.orgJohn Ericsonfrankly, I don't mind if you don't look at the code at all21:43:48
@Ericson2314:matrix.orgJohn EricsonI just want to not merge it myself since you brought up the nix-comunity issue, want to make sure no one reads that as me merging over your objection21:44:14
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
frankly, I don't mind if you don't look at the code at all
I'd feel bad if I didn't tbh. That's something I would expect someone in my role to do
21:44:23
@Ericson2314:matrix.orgJohn Ericson(if one just glances, they might not see you are raising a concern just to dismiss it)21:44:28
@Ericson2314:matrix.orgJohn EricsonOK fair enough :)21:44:34
@Ericson2314:matrix.orgJohn EricsonI won't tell you to not hold yourself to your own high standard :)21:44:46
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
I won't tell you to not hold yourself to your own high standard :)
Just trying to give something back :)
21:45:18
@Ericson2314:matrix.orgJohn Ericson:)21:45:26
@hexa:lossy.networkhexaThe machine status page shows all active machines twice 🙃21:45:49
@hexa:lossy.networkhexa