| 15 Nov 2024 |
 John Ericson | das_j: gotcha, so you are saying this is definitely a net improvement, right? | 21:40:06 |
| John Ericson | if you like it, feel free to hit the merge button | 21:40:42 |
| John Ericson | I can inform the rest of the SC but I would not block a decision on this | 21:40:58 |
 @janne.hess:helsinki-systems.de | In reply to @Ericson2314:matrix.org
das_j: gotcha, so you are saying this is definitely a net improvement, right? Pretty much, apart from the fact that it's nix-community. Which is not something I have a personal issue with but I can imagine other people do | 21:41:31 |
| John Ericson | I say better to ask for forgiveness than permission :) | 21:41:54 |
| @janne.hess:helsinki-systems.de | In reply to @Ericson2314:matrix.org
if you like it, feel free to hit the merge button I will take a look this weekend I hope. If I don't, feel free to ping and annoy me again because I likely forgot ;) I'll do my best reviewing the change | 21:42:10 |
| John Ericson | OK thanks! | 21:42:19 |
| John Ericson | all the code is due to the lix people, who are already using this | 21:42:29 |
| @janne.hess:helsinki-systems.de | In reply to @Ericson2314:matrix.org
OK thanks! No, thank you for upstreaming all that work | 21:42:41 |
| John Ericson | I just changed nix-eval-jobs (already merged) and stuff in the flake | 21:42:43 |
| John Ericson | so feel free to give it a quick and dirty review | 21:42:56 |
| John Ericson | since the code is already in production....somewhere | 21:43:02 |
| John Ericson | frankly, I don't mind if you don't look at the code at all | 21:43:48 |
| John Ericson | I just want to not merge it myself since you brought up the nix-comunity issue, want to make sure no one reads that as me merging over your objection | 21:44:14 |
| @janne.hess:helsinki-systems.de | In reply to @Ericson2314:matrix.org
frankly, I don't mind if you don't look at the code at all I'd feel bad if I didn't tbh. That's something I would expect someone in my role to do | 21:44:23 |
| John Ericson | (if one just glances, they might not see you are raising a concern just to dismiss it) | 21:44:28 |
| John Ericson | OK fair enough :) | 21:44:34 |
| John Ericson | I won't tell you to not hold yourself to your own high standard :) | 21:44:46 |
| @janne.hess:helsinki-systems.de | In reply to @Ericson2314:matrix.org
I won't tell you to not hold yourself to your own high standard :) Just trying to give something back :) | 21:45:18 |
| John Ericson | :) | 21:45:26 |
 hexa | The machine status page shows all active machines twice 🙃 | 21:45:49 |
| hexa |
|
