| 22 Oct 2023 |
Lily Foster | and is supposed to fail gracefully in the absence of a binary being available? | 14:54:24 |
Lily Foster | Can you share your full build log? | 14:54:35 |
Lily Foster | they removed the ability for it to build at all, so the fallback fails 🙃 https://github.com/mapbox/mapbox-gl-native/pull/15748 | 14:55:29 |
Lily Foster | why is node.js ecosystem such an ecological disaster | 14:55:39 |
Lily Foster | this pr would fix it; https://github.com/maplibre/maplibre-native/pull/535 | 14:56:00 |
Lily Foster | * this pr would fix it: https://github.com/maplibre/maplibre-native/pull/535 | 14:56:03 |
Lily Foster | i'm not sure what a good option is to work around that for now though :( | 14:57:13 |
Lily Foster | ideally you can just patch the package.json in the dependency, but we don't have the machinery yet to patch npm dependencies like that... | 14:57:38 |
Lily Foster | (more details at https://github.com/maplibre/maplibre-native/issues/851 too) | 14:58:15 |
Lily Foster | what you are trying to package that is using maplibre-native? | 14:58:33 |
daniel | Just an application I'm building myself. I found the same references you linked, so I think I will have to discuss it with the maintainers | 15:00:39 |
daniel | Seems awful to patch by hand | 15:00:51 |
Lily Foster | i'm really not sure how you would patch by hand tbh :( | 15:02:08 |
Lily Foster | unless you forked it i guess | 15:02:15 |
daniel | Yeah 😅 Thanks, though! | 15:03:45 |
Lily Foster | if you have any ideas though, let me know. or let me know if you figure out something, i am curious if you come up with a workaround! | 15:07:22 |
Lily Foster | i'm thinking once we have redone lockfile fixup, we could maybe also work on adding an arg for passing dep patches that get picked up and applied in the fetcher | 15:09:13 |
Lily Foster | which would help with situations like this | 15:09:25 |
Lily Foster | You know. Actually. Since we do npm ci --ignore-scripts iirc, we could probably add a hook between that and the npm rebuild to allow patching deps before running install scripts too | 15:10:03 |
Lily Foster | hmmmm i'll see about doing that, since that would be a hacky easy way to allow doing such dep fixup | 15:11:12 |
Lily Foster | @Marie btw i haven't forgotten, i just didn't get a chance to do nodejs stuff last night. hopefully i can do later today (i still have reminder set) | 15:44:00 |
Marie | okay, thank you for telling me and please don't feel stressed | 15:48:14 |
Lily Foster | In reply to @marie:marie.cologne okay, thank you for telling me and please don't feel stressed i'm not and reminders are okay for me :) (i'm too scattered to exist without them tbh.....) | 16:01:50 |
Lily Foster | * i'm don't feel stressed and reminders are okay for me, don't worry :)
(i'm too scattered to exist without them tbh.....) | 16:02:59 |
Cobalt | Hi, does someone know a workaround for overriding the default node prefetcher phase/hook? I would like to alter the working directory of prefetcher to a subdir of src. | 21:28:11 |
Cobalt | And preferably also keep the node modules from this subdir associated with it for the install phase, though that can be patched with installPhase otherwise (wouldn't be the only overwrite their). | 21:29:12 |
Cobalt | (for context: My goal is to build a package from a monorepo. This package requires type declarations from another package on the same level) | 21:31:06 |
Cobalt | * (for context: The goal is to build a package from a monorepo. This package requires type declarations from another package on the same level) | 21:31:16 |
Cobalt | Any help would be appreciated :) | 21:32:22 |
Cobalt | Update: Got it solved via patching the dependency link rather than updating the prefetcher dir:
{
prePatch = ''
sed -Ei 's/\.\.\/types\/\*/${
lib.strings.escape [ "/" "+" "*" "?" "(" ")" "[" "]" ]
(toString proofbuddy)
}\/types\/\*/' tsconfig.json
'';
}```
| 21:44:17 |