| 21 Dec 2023 |
Lily Foster | because uh 👀 | 16:20:35 |
peter-lustig | the prerendering stuff is so weird | 16:21:13 |
peter-lustig | like all of it confuses me | 16:21:16 |
peter-lustig | i had everything working with dynamic env variables and now nothing of that works anymore | 16:21:28 |
Lily Foster |
Note that all environment variables referenced in your code should be declared (for example in an .env file), even if they don't have a value until the app is deployed
hmmmmmm (from https://kit.svelte.dev/docs/modules#$env-static-private)
| 16:21:34 |
peter-lustig | In reply to @lily:lily.flowers
Note that all environment variables referenced in your code should be declared (for example in an .env file), even if they don't have a value until the app is deployed
hmmmmmm (from https://kit.svelte.dev/docs/modules#$env-static-private)
yep i saw that | 16:21:59 |
Lily Foster | In reply to @peter-lustig:matrix.org i had everything working with dynamic env variables and now nothing of that works anymore well i'm worried it's trying to include these vars in client-side generated code. which handing over secrets to the client feels ,,, problematic. would you mind sharing more of the code to help me understand? | 16:22:04 |
peter-lustig | In reply to @lily:lily.flowers well i'm worried it's trying to include these vars in client-side generated code. which handing over secrets to the client feels ,,, problematic. would you mind sharing more of the code to help me understand? import { github, google } from '@lucia-auth/oauth/providers';
import {
GITHUB_CLIENT_ID,
GITHUB_CLIENT_SECRET,
GOOGLE_CLIENT_ID,
GOOGLE_CLIENT_SECRET
} from '$env/static/private';
export const pool = new postgres.Pool({
host: '/run/postgresql',
user: 'postgres',
database: 'app'
});
export const auth = lucia({
env: dev ? 'DEV' : 'PROD',
middleware: sveltekit(),
adapter: pg(pool, {
user: 'auth_user',
key: 'user_key',
session: 'user_session'
}),
getUserAttributes: (data) => {
return {
username: data.username,
authProvider: data.auth_provider
};
}
});
export const githubAuth = github(auth, {
clientId: GITHUB_CLIENT_ID,
clientSecret: GITHUB_CLIENT_SECRET
});
| 16:23:14 |
peter-lustig | with $env/dynamic/priavate everything just worked | 16:23:31 |
peter-lustig | but in sveltekit 2.0 it does not work anymore | 16:23:36 |
Lily Foster | well apparently prior to 2.0, there was no strong distinction between those types of vars apparently | 16:24:13 |
Lily Foster | * well apparently prior to 2.0, there was no strong distinction between those types of vars | 16:24:16 |
Lily Foster | i'm gonna look up more about how lucia-auth works real quick | 16:24:39 |
Lily Foster | oh apparently lucia-auth is now just under lucia for v2 | 16:24:58 |
Lily Foster | * oh apparently lucia-auth is now just under lucia for v2 | 16:25:05 |
Lily Foster | oh but other packages are the same. ignore me. i can't read | 16:25:15 |
Lily Foster | (reading https://lucia-auth.com/migrate/v2/ rn) | 16:25:19 |
Lily Foster | well that file looks correct according to https://lucia-auth.com/guidebook/github-oauth/sveltekit/#initialize-the-oauth-integration | 16:26:43 |
Lily Foster | where and how are you using githubAuth? | 16:26:48 |
peter-lustig | this has nothing to do with lucia auth, it is just the static stuff | 16:27:24 |
peter-lustig | for the env variables | 16:27:30 |
Lily Foster | hmm? | 16:28:43 |
peter-lustig | i do not get why they made this so confusing once again | 16:29:12 |
peter-lustig | instead of writing a proper migration guide | 16:29:31 |
Wanja Hentze | is it really fine to have the github oauth secret in the frontend? 😅 | 16:29:39 |
peter-lustig | for multiple deployment methods | 16:29:41 |
Lily Foster | In reply to @whentze:matrix.org is it really fine to have the github oauth secret in the frontend? 😅 that's what i'm hoping is not happening. but without more of the code, i can't tell | 16:29:52 |
peter-lustig | In reply to @whentze:matrix.org is it really fine to have the github oauth secret in the frontend? 😅 that never happens sveltekit errors out when you try to do that | 16:29:57 |
Wanja Hentze | oh cool | 16:30:06 |
peter-lustig | https://kit.svelte.dev/docs/server-only-modules#how-it-works | 16:31:07 |