| 21 Dec 2023 |
peter-lustig | In reply to @lily:lily.flowers yeah but do you have github env vars set? yeah in .env and then I import them with $env/static/.. | 16:00:19 |
Lily Foster | ah, but is it possible to make them not required during build? | 16:00:37 |
Lily Foster | you can mock up fake ones in the nix build too | 16:00:47 |
peter-lustig | I guess it is | 16:01:00 |
Lily Foster | by writing a .env there or something | 16:01:03 |
peter-lustig | not sure | 16:01:05 |
peter-lustig | In reply to @lily:lily.flowers you can mock up fake ones in the nix build too could you show me how I would do that in my current flake | 16:01:27 |
Lily Foster | yeah, one sec. getting personal laptop out | 16:01:44 |
Lily Foster | In reply to @peter-lustig:matrix.org could you show me how I would do that in my current flake the values don't matter during build right? so they could be empty strings for all your package cares? | 16:03:49 |
peter-lustig | yeah i think so | 16:04:21 |
peter-lustig | worth a try | 16:04:28 |
Lily Foster | (dynamically grabbing them from the env when they are needed rather than importing from a virtual module would probably be more robust, and would also handle things like the env vars changing during the lifetime of the program better) | 16:04:51 |
Lily Foster | you can do something like this though:
env = {
GITHUB_CLIENT_ID = "";
GITHUB_CLIENT_SECRET = "";
...
}
| 16:05:19 |
Lily Foster | on the derivation | 16:05:23 |
peter-lustig | In reply to @lily:lily.flowers (dynamically grabbing them from the env when they are needed rather than importing from a virtual module would probably be more robust, and would also handle things like the env vars changing during the lifetime of the program better) yeah i had it dynamic before and everything worked, but look at this:
https://kit.svelte.dev/docs/migrating-to-sveltekit-2#dynamic-environment-variables-cannot-be-used-during-prerendering
| 16:05:33 |
peter-lustig | that does not work for the new version | 16:05:47 |
Lily Foster | shouldn't you be using dynamic instead of static then? | 16:06:41 |
Lily Foster | since you want runtime vars, not build-time vars? | 16:06:46 |
Lily Foster | (if i'm reading this doc right) | 16:06:52 |
peter-lustig | read what is ent | 16:07:06 |
peter-lustig | when i use dynamic i get an error | 16:07:11 |
peter-lustig | that i shoul duse static | 16:07:15 |
peter-lustig | because of the prerendering | 16:07:20 |
Lily Foster | oh, so you need real values during build time then? | 16:07:30 |
Lily Foster | that would be secrets baked in to your program :grimc | 16:07:38 |
Lily Foster | * that would be secrets baked in to your program 😬 | 16:07:45 |
Lily Foster | do they have a better way to deal with secrets? | 16:08:03 |
peter-lustig | i will first test the fake values now | 16:08:03 |
peter-lustig | because what i really wonder is why npm run build works and nix build errors out | 16:08:14 |
Lily Foster | i mean again, the fake values will let it build, but if it's baking them in, it won't work. you could put real values in there but then you'd have world-readable secrets | 16:08:26 |