| 18 Dec 2023 |
 Sandro 🐧 | We can't just xz compress them and then commit them? 😅 | 13:49:12 |
 Wanja Hentze | I think you're misunderstanding me | 13:49:29 |
| Wanja Hentze | I'm not saying let's commit a bunch of lockfiles to nixpkgs | 13:49:41 |
| Wanja Hentze | the use case is "I have a nodejs project and my lockfile is already in git, I want to write a default.nix" | 13:50:28 |
| Wanja Hentze | this has nothing to do with nixpkgs other than that it would be nice to get the packaging helper function from nixpkgs | 13:51:48 |
| Wanja Hentze | hence me asking "is it worthwhile to ship packaging helpers in nixpkgs that are not dogfooded by nixpkgs?" | 13:53:33 |
| Sandro 🐧 | Maybe depends on size but e.g. vendoring yarn2nix seemed more of a headache then it needs to be. Other things are just put in as a CLI is that's possible | 15:15:05 |
| Wanja Hentze | oh wait | 15:16:02 |
| Wanja Hentze | you're talking about vendoring the packaging helper, not the packages | 15:16:15 |
| Wanja Hentze | in this case, it's really not a ton of code: https://github.com/adisbladis/buildNodeModules | 15:16:46 |
| 19 Dec 2023 |
 @adis:blad.is | We could port over the expressions that already vendor a lock file.
No point in having fat FODs for those cases. | 02:51:09 |
| @adis:blad.is | In reply to @whentze:matrix.org
in this case, it's really not a ton of code: https://github.com/adisbladis/buildNodeModules If I were to add it to nixpkgs I'd consider it the new upstream and archive my repo | 02:53:19 |
| 20 Dec 2023 |
| Sandro 🐧 | In reply to @adis:blad.is
We could port over the expressions that already vendor a lock file.
No point in having fat FODs for those cases. for remote building it is likely still faster. Copying hundreds of derivations over is extremely slow and takes probably longer than rebuilding them. | 02:20:59 |
 Mason Mackaman | anyone have experience wrangling vite? | 02:37:36 |
| @adis:blad.is | In reply to @sandro:supersandro.de
for remote building it is likely still faster. Copying hundreds of derivations over is extremely slow and takes probably longer than rebuilding them. That's only true if you're privileged enough to have a fast Internet connection.
That's not true for users in the developing world. | 06:31:58 |
| @adis:blad.is | And faster isn't the only concern.
Bytes transferred matters. | 06:32:38 |
| 21 Dec 2023 |
 peter-lustig | > at VariableDeclarator.bind (file:///build/2rdr2hwic3kd9pwpgp32s206yh5kqwhs-source/node_modules/rollup/dist/es/shared/node-entry.js:4639:23)
>
> ERROR: `npm build` failed
Is this some nix issue again?
I can build the project fine with npm run build
| 15:40:21 |
| peter-lustig | but with nix the build command seems to fail for some reason | 15:40:52 |
| peter-lustig | My build script (left the hash out for abbreviation):
packages.${system}.default = pkgs.buildNpmPackage {
name = "project-build";
src = ./.;
installPhase = ''
mkdir $out
cp -r build/* $out
cp package.json $out
cp -r node_modules $out
'';
};
};
| 15:42:05 |
| peter-lustig | More explicitly getting is not exported by "^@virtual:$env/static/private", imported by, but I do not get this error when I only run npm run build without doing anything nix. | 15:45:05 |
 Lily Foster | In reply to @peter-lustig:matrix.org
> at VariableDeclarator.bind (file:///build/2rdr2hwic3kd9pwpgp32s206yh5kqwhs-source/node_modules/rollup/dist/es/shared/node-entry.js:4639:23)
>
> ERROR: `npm build` failed
Is this some nix issue again?
I can build the project fine with npm run build
hmmm it's unclear. can you send full build output? the error is before that | 15:53:43 |
| peter-lustig | In reply to @lily:lily.flowers
hmmm it's unclear. can you send full build output? the error is before that yep wait | 15:56:33 |
| peter-lustig | https://pastebin.com/dfAjZx0K | 15:58:10 |
| Lily Foster | uhhh why is it needing github api env vars | 15:58:51 |
| Lily Foster | during build | 15:58:54 |
| peter-lustig | idk | 15:59:33 |
| peter-lustig | as mentioned | 15:59:36 |
| Lily Foster | give me a sec so i can get out my laptop | 15:59:41 |
| peter-lustig | it does not happen when I do npm run build without nix stuff | 15:59:43 |
| Lily Foster | In reply to @peter-lustig:matrix.org
it does not happen when I do npm run build without nix stuff yeah but do you have github env vars set? | 15:59:57 |
