| 24 Aug 2023 |
 Lily Foster | In reply to @robert:funklause.de
Please review and merge if you have some spare time. I don't wanna accrue merge conflicts. Merged. And naturally it immediately created a merge conflict with https://github.com/NixOS/nixpkgs/pull/250250, but I already left another review comment on that one anyway | 00:53:27 |
| Lily Foster | In reply to @gdesforges:matrix.org
Lily Foster: I've closed previous PR and pushed a new PR https://github.com/NixOS/nixpkgs/pull/248107 Apologies for taking a minute there to get back to this, but I left one super minor nit (which tbh doesn't need to be a blocker for merge, so feel free to ask it to just be merged if you'd rather not fix it) | 00:54:13 |
| Lily Foster | In reply to @lily:lily.flowers
Merged. And naturally it immediately created a merge conflict with https://github.com/NixOS/nixpkgs/pull/250250, but I already left another review comment on that one anyway (thank you for your recent node work btw dotlambda, you've been fabulous ❤️) | 00:55:22 |
| Lily Foster | (I finally got a chance to look at the manpages PR and I saw it was accidentally merged a little early (probably because I didn't get to it in time), but it looks fine to me assuming it passed testing) | 00:57:42 |
 @gdesforges:matrix.org | In reply to @lily:lily.flowers
Apologies for taking a minute there to get back to this, but I left one super minor nit (which tbh doesn't need to be a blocker for merge, so feel free to ask it to just be merged if you'd rather not fix it) thanks a lot! I've applied your change 👍️ | 07:34:01 |
| @gdesforges:matrix.org | who should I ask for merge? | 07:34:08 |
| @gdesforges:matrix.org | * who should I ask for a merge? | 07:34:17 |
 raitobezarius | me | 09:35:45 |
