| 10 Aug 2023 |
 p14 | (Thanks very much for your input trofi, learned some useful things and also good to know it's not just me this is bonkers for ;-)) | 14:44:54 |
| p14 | trofi: scrub found no errors, so I'm redoing memtest but also entertaining a software bug somewhere? | 15:50:41 |
 trofi | Yeah, looks like nix-daemon bug. | 15:51:41 |
| 11 Aug 2023 |
 tpw_rules | so i'm running into a weird issue where i'm trying to copy a large file in a derivation and cp decides to use copy_file_range and the file is copied, but then i guess it calls again to check if it's done and copy_file_range returns -EINVAL despite the fact that the copy succeeded? | 16:14:13 |
| tpw_rules | do i have a kernel issue or something? | 16:15:38 |
| tpw_rules | this is ubuntu running a pretty old kernel | 16:15:45 |
| tpw_rules | cp itself also prints "invalid argument" and returns nonzero | 16:17:47 |
| tpw_rules | ah, this was caused by the coreutils 9.3 upgrade likely | 16:21:15 |
| tpw_rules | that's kind of awkard... | 16:23:21 |
| 13 Aug 2023 |
|  nevoyu joined the room. | 01:27:28 |
| 15 Aug 2023 |
|  Christina Sørensen changed their profile picture. | 14:57:25 |
| nevoyu left the room. | 19:34:39 |
| 17 Aug 2023 |
|  lxsameer joined the room. | 11:57:33 |
| 22 Aug 2023 |
|  chvp changed their profile picture. | 13:06:48 |
| 27 Aug 2023 |
|  catch22 joined the room. | 22:08:35 |
| 29 Aug 2023 |
 Artturin | https://github.com/NixOS/nixpkgs/pull/251853 | 19:05:05 |
| 3 Sep 2023 |
| p14 | I would like to address https://github.com/NixOS/nixpkgs/issues/111010#issuecomment-1536424163 but it will require changing the cc-wrapper.
[fix is to account for$NIX_CFLAGS_LINK when computing the link type].
Anyone see any problems with doing so, or any suggestions on implementation, can I submit a fix to staging?
| 09:45:32 |
 Mindavi | One way to find out if it gives problems, go for it | 10:49:15 |
| p14 | Doing a local build with an obvious fix before I send it, let's see how that pans out. | 10:49:39 |
| p14 | diff --git a/pkgs/build-support/cc-wrapper/cc-wrapper.sh b/pkgs/build-support/cc-wrapper/cc-wrapper.sh
index 9dcd29c64431..fbc62144ab3f 100644
--- a/pkgs/build-support/cc-wrapper/cc-wrapper.sh
+++ b/pkgs/build-support/cc-wrapper/cc-wrapper.sh
@@ -30,7 +30,7 @@ cxxInclude=1
cxxLibrary=1
cInclude=1
-expandResponseParams "$@"
+expandResponseParams "$@" ${NIX_CFLAGS_LINK_@suffixSalt@:-}
linkType=$(checkLinkType "${params[@]}")
declare -ag positionalArgs=()
In case anyone has suggestions/criticisms. I should have a build of some nontrivial software within an hour or two.
| 10:50:55 |
| p14 | Darn, that doesn't seem to be right. Should I be putting NIX_CFLAGS_LINK there rather than NIX_CFLAGS_LINK_@suffixSalt@, or possibly even both? | 11:03:19 |
| p14 | I guess that's also not right because we don't want to inject the link flags into the params so early anyway (even if it might be nice to have the CFLAGS_LINK response-expanded... | 11:06:46 |
| p14 | Candidate fix. I've been able to build/run pkgsStatic.pkgsLLVM.hello using this (on staging, also using LLVM 16) https://github.com/NixOS/nixpkgs/pull/253116 | 12:54:32 |
| p14 | Artturin: I also tried building pkgsStatic.pkgsLLVM.clang.cc -- for this I hit the error message you described in https://github.com/NixOS/nixpkgs/issues/22060 ( file RPATH_CHANGE could not write new RPATH:) while installing llvm. | 12:55:49 |
| p14 | * Artturin: I also tried building pkgsStatic.pkgsLLVM.clang.cc -- for this I hit the error message you described in https://github.com/NixOS/nixpkgs/issues/22060 ( file RPATH_CHANGE could not write new RPATH:) while in the ninja install phase of llvm. | 12:56:00 |
| p14 | Is there any testing machinery someone can run #253116 through, is it possible to have a hydra job for it? | 12:57:51 |
| Artturin | Running nix build -f tests.cc-wrapper | 13:07:16 |
| Artturin | * Im running
nix build -f tests.cc-wrapper | 13:07:48 |
| Artturin | * Im running
`nix build -f tests.cc-wrapper` | 13:07:59 |
| Artturin | it built | 14:28:22 |
