| 8 Mar 2023 |
 vcunat | In reply to @winterqt:nixos.dev
Where did you find this info? * That's the libc.so text-file. | 08:09:19 |
| 14 Mar 2023 |
|  ckie (they/them) changed their display name from ckie (they/them) to ckie (they/them; heavily limited keyboard usage, dictation or voice only). | 01:09:43 |
| 18 Mar 2023 |
|  Mindavi changed their display name from Rick (Mindavi) to Mindavi. | 10:48:18 |
| 20 Mar 2023 |
 hexa | ❯ nix build -f . curl.tests
error:
… while calling a functor (an attribute set with a '__functor' attribute)
at /home/hexa/git/nixos/staging/pkgs/tools/networking/curl/default.nix:171:20:
170| withCheck = finalAttrs.finalPackage.overrideAttrs (_: { doCheck = true; });
171| fetchpatch = tests.fetchpatch.simple.override { fetchpatch = fetchpatch.override { fetchurl = useThisCurl fetchurl; }; };
| ^
172| curlpp = useThisCurl curlpp;
… while evaluating a branch condition
at /home/hexa/git/nixos/staging/lib/customisation.nix:92:7:
91| in
92| if builtins.isAttrs result then
| ^
93| result // {
(stack trace truncated; use '--show-trace' to show the full trace)
error: attribute 'version' missing
at /home/hexa/git/nixos/staging/pkgs/build-support/fetchpatch/tests.nix:4:19:
3| let
4| isFetchpatch2 = fetchpatch.version == 2;
| ^
5| in
not sure if the fetchers are stdenv material, but looks like fetchpatch2 changes have broken curls passthru tests 🙂 cc Artturin
| 15:07:53 |
 Artturin | the override clears the // { version ... } done on the callPackage result | 15:18:43 |
| Artturin | fetchpatch = callPackage ../build-support/fetchpatch {
# 0.3.4 would change hashes: https://github.com/NixOS/nixpkgs/issues/25154
patchutils = buildPackages.patchutils_0_3_3;
} // {
tests = pkgs.tests.fetchpatch;
version = 1;
};
fetchpatch2 = callPackage ../build-support/fetchpatch {
patchutils = buildPackages.patchutils_0_4_2;
} // {
tests = pkgs.tests.fetchpatch2;
version = 2;
};
| 15:18:47 |
| Artturin | passthru is not used here because fetchpatch retunrs a function | 15:19:10 |
| Artturin | one solution
diff --git a/pkgs/tools/networking/curl/default.nix b/pkgs/tools/networking/curl/default.nix
index fca190bde4a..b95275327c2 100644
--- a/pkgs/tools/networking/curl/default.nix
+++ b/pkgs/tools/networking/curl/default.nix
@@ -168,7 +168,7 @@ stdenv.mkDerivation (finalAttrs: {
inherit opensslSupport openssl;
tests = {
withCheck = finalAttrs.finalPackage.overrideAttrs (_: { doCheck = true; });
- fetchpatch = tests.fetchpatch.simple.override { fetchpatch = fetchpatch.override { fetchurl = useThisCurl fetchurl; }; };
+ fetchpatch = tests.fetchpatch.simple.override { fetchpatch = (fetchpatch.override { fetchurl = useThisCurl fetchurl; }) // { version = 1; }; };
curlpp = useThisCurl curlpp;
coeurl = useThisCurl coeurl;
haskell-curl = useThisCurl haskellPackages.curl;
| 15:20:15 |
| hexa | I'll take that, thanks | 15:29:21 |
| Artturin | https://github.com/NixOS/nixpkgs/pull/222215 doesn't fix the issue either, don't know if there's a way to preserve it through .override | 15:38:54 |
| hexa | pushed the "one solution" one top of https://github.com/NixOS/nixpkgs/pull/222172 | 15:51:33 |
| hexa | w/e you prefer | 15:51:51 |
| hexa | * pushed the "one solution" one on top of https://github.com/NixOS/nixpkgs/pull/222172 | 16:31:36 |
| 23 Mar 2023 |
| ckie (they/them) changed their display name from ckie (they/them; heavily limited keyboard usage, dictation or voice only) to ckie (they/them; limited keyboard usage, voice preferred). | 02:03:47 |
| 24 Mar 2023 |
 Winter (she/her) | https://bugs.gnu.org/62403 | 00:42:40 |
| Winter (she/her) | not sure if we bumped coreutils yet (sorry), but apply ^ when we do | 00:42:57 |
| Winter (she/her) | see also https://bugs.archlinux.org/task/77969 | 00:43:09 |
| hexa | https://bugs.gnu.org/62403 | 01:21:03 |
| hexa | we did not yet | 01:21:20 |
| hexa | https://github.com/NixOS/nixpkgs/pull/222314#issuecomment-1482044692 | 01:22:06 |
| Winter (she/her) | In reply to@hexa:lossy.network
https://bugs.gnu.org/62403 is that link different from mine? :D | 01:50:27 |
| hexa | shut up? 😛 | 01:50:59 |
| hexa | I'm old, deal with it | 01:51:08 |
 Sandro 🐧 | Do coreutils even have tests? | 13:51:24 |
 @andreas.schraegle:helsinki-systems.de | they have users | 14:02:11 |
 Alyssa Ross | they have lots of tests | 14:08:10 |
| Alyssa Ross | they're quite noticeable when building stdenv :P | 14:08:20 |
| 25 Mar 2023 |
|  amardeeps joined the room. | 04:46:58 |
|  rbutani joined the room. | 23:56:00 |
| 27 Mar 2023 |
 j-k | In reply to @sandro:supersandro.de
Do coreutils even have tests? You probably saw this graph when doing uutils work
https://github.com/uutils/coreutils-tracking/blob/main/gnu-results.png?raw=true
| 11:24:05 |
