| 1 Aug 2022 |
 Winter (she/her) | Yeah Goblin is definitely better. | 16:54:35 |
| Winter (she/her) | Was ZFS support added since the initial PR, btw? | 16:55:11 |
 @elvishjerricco:matrix.org | Yes | 16:55:16 |
| Winter (she/her) | I didn't see any commits but I may be looking in the wrong place. | 16:55:21 |
| Winter (she/her) | Oh, cool. | 16:55:26 |
| @elvishjerricco:matrix.org | AFAIK zfs support is now on par with scripted initrd | 16:55:28 |
| Winter (she/her) | What commit added that, what should I be looking for, out of curiosity? | 16:55:46 |
| @elvishjerricco:matrix.org | https://github.com/NixOS/nixpkgs/pull/168269 | 16:56:10 |
| @elvishjerricco:matrix.org | Redacted or Malformed Event | 17:25:09 |
 K900 | Applied all the suggestions on the goblin PR | 19:57:56 |
| @elvishjerricco:matrix.org | Cool. I'd still like someone's answer to this comment, but I'm inclined to merge if we get no such answer in the next day or two | 20:08:27 |
| @elvishjerricco:matrix.org | Oh, and apparently we're getting an eval error because there's no lib.maintainers.dasJ | 20:11:10 |
| @elvishjerricco:matrix.org | Ah, lib.maintainers.das_j | 20:11:40 |
| @elvishjerricco:matrix.org | Also, Janne Heß did you ever consent to being added to that maintainer list? I gave a thumbs up for myself; I apologize if I accidentally indicated you were cool with it too | 20:12:35 |
| Winter (she/her) | So I'm considering giving systemd initrd a whirl on my machines. The one requirement I have is that I'm able to wipe my ZFS root dataset on startup. Would this be accomplished by defining a unit that requires and runs after zfs-import-<pool name>? I think that's... all I really have to do? | 21:49:27 |
| Winter (she/her) | (I do this with postDeviceCommands now.) | 21:49:43 |
| @elvishjerricco:matrix.org | That sounds right to me. | 21:50:13 |
| Winter (she/her) | Also, semi off-topic but I think someone here would know: why does the ZFS module explicitly use ${cfgZfs.package}/sbin/zfs in its scripts, when this is already added to initrd's packages and the system packages, so it really should just be able to call zfs, unless there's a reason this is explicitly done that I'm missing? | 21:53:02 |
| @elvishjerricco:matrix.org | why would it be able to just call zfs? | 21:54:24 |
| @elvishjerricco:matrix.org | units don't have a PATH by default | 21:54:39 |
 @linus:schreibt.jetzt | In reply to @winterqt:nixos.dev
So I'm considering giving systemd initrd a whirl on my machines. The one requirement I have is that I'm able to wipe my ZFS root dataset on startup. Would this be accomplished by defining a unit that requires and runs after zfs-import-<pool name>? I think that's... all I really have to do? I think you'll also want to order it before and make it required by the rootfs mount unit | 21:57:26 |
| @linus:schreibt.jetzt | not sure what that's called though | 21:57:33 |
| @elvishjerricco:matrix.org | That's probably "correct" but shouldn't really be necessary. ZFS can rollback a mounted file system. | 22:02:01 |
| @elvishjerricco:matrix.org | You will want it before initrd.target though | 22:02:14 |
| @elvishjerricco:matrix.org | (but before the rootfs would obviously make that implicit) | 22:04:31 |
| Winter (she/her) | In reply to @elvishjerricco:matrix.org
You will want it before initrd.target though What happens after that target? It looks like this is just like, the initrd setup target, based on the wants/after. | 22:45:47 |
| Winter (she/her) | Does like, everything else happen after it? | 22:45:56 |
| @elvishjerricco:matrix.org | After initrd.target gets reached, we run systemctl isolate initrd-switch-root.service | 22:46:28 |
| @elvishjerricco:matrix.org | so everything without IgnoreOnIsolate gets killed, meaning anything that was still in progress won't finish | 22:46:49 |
| 2 Aug 2022 |
| Winter (she/her) | In reply to @elvishjerricco:matrix.org
After initrd.target gets reached, we run systemctl isolate initrd-switch-root.service Do you run that literal command? I can't find the reference to it, only the definition of the service. | 02:04:13 |
