| 20 Mar 2022 |
@elvishjerricco:matrix.org | I think that consistency is probably worthwhile | 17:47:45 |
bobvanderlinden | better for now indeed | 17:47:56 |
bobvanderlinden | to get the PR merged 😅 can always experiment with these things afterwards | 17:48:21 |
@elvishjerricco:matrix.org | I have to run for now. Let me know if the PATH thing and makefs/growfs work. Or if you're not messing with it right now I'll probably give it a go in an hour or two | 17:49:10 |
bobvanderlinden | meh, i need to go too for now. This is what I got atm: https://github.com/bobvanderlinden/nixpkgs/commit/49f374ed7cf234a99ecab41ab2f0b5359b088ae8 | 18:06:00 |
bobvanderlinden | I don't see it doing any makefs things yet:
machine # [ OK ] Found device /dev/vda.
machine # [ 2.398149] systemd-udevd[85]: Using default interface naming scheme 'v249'.
machine # Mounting /sysroot...
machine # [ 2.735262] EXT4-fs (vda): VFS: Can't find ext4 filesystem
machine # [ 2.514791] mount[110]: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/vda, missing codepage or helper program, or other error.
machine # sysroot.mount: Mount process exited, code=exited, status=32/n/a
machine # sysroot.mount: Failed with result 'exit-code'.
machine # [FAILED] Failed to mount /sysroot.
| 18:06:20 |
bobvanderlinden | aah, maybe those generator files aren't there yet in the right place on the initramfs:
/nix/store/mf3c2s2zfwn7i5j9ibca1md7gnhmxy91-systemd-minimal-249.7/lib/systemd/system-generators/systemd-fstab-generator -> /etc/systemd/system-generators/ | 18:08:04 |
@elvishjerricco:matrix.org | Systemd does actually implicitly know where its included generators are. That's why the fstab generator works | 18:13:16 |
@elvishjerricco:matrix.org | But yes, tangentially, we should create the proper generators directory | 18:13:34 |
bobvanderlinden | Ah, well I couldn't see that it ran the generator from the logs. Not sure what was up. Not looking at it atm (need some food 😅) | 18:17:28 |
@elvishjerricco:matrix.org | Ok cool, I have makefs and growfs working | 19:33:23 |
@elvishjerricco:matrix.org | but yea like I thought, I have the IgnoreOnIsolate problem | 19:33:38 |
@elvishjerricco:matrix.org | bobvanderlinden: Janne Heß: I think I've fixed it now. Check out the latest two commits on the PR | 20:04:11 |
@elvishjerricco:matrix.org | And now I've added a bare minimum test case. Works just fine | 20:12:11 |
@janne.hess:helsinki-systems.de | one thing I was wondering: why always DefaultEnvironment=PATH=/bin:/sbin? Wouldn't it be cleaner to reference /nix directly? | 20:14:39 |
@elvishjerricco:matrix.org | Janne Heß: Mainly because it doesn't matter, unlike in actual NixOS | 20:16:38 |
@elvishjerricco:matrix.org | Before I had a lot of things working, it was way easier to just have /bin rather than having to go spelunking through /nix | 20:18:01 |
@elvishjerricco:matrix.org | when something gets wildly borked it's nice to have there | 20:18:15 |
@janne.hess:helsinki-systems.de | hmm, does the test work for you? | 20:18:16 |
@elvishjerricco:matrix.org | yes | 20:18:20 |
@janne.hess:helsinki-systems.de | interesting, so some local modification must be breaking it… | 20:18:32 |
@elvishjerricco:matrix.org | what's the breakage? | 20:18:41 |
@janne.hess:helsinki-systems.de | [FAILED] Failed to start Make File System on /dev/vda. | 20:18:56 |
@elvishjerricco:matrix.org | Uh oh | 20:19:17 |
@janne.hess:helsinki-systems.de | ummmm interesting | 20:19:33 |
@janne.hess:helsinki-systems.de | the modification that broke it was my Environment= stuff | 20:19:41 |
@elvishjerricco:matrix.org | Systemd needs to find mke2fs on PATH | 20:20:20 |
@elvishjerricco:matrix.org | Does setting Environment= override PATH even if you don't use it to set PATH? | 20:22:04 |
@elvishjerricco:matrix.org | Er, no, emergency.service uses it to set HOME=/root, and that doesn't break PATH in my emergency shell | 20:22:27 |
@janne.hess:helsinki-systems.de | ah yeah for some reason it sets PATH=:. I'll take a look at this later because it turns out the argument passing doesn't work :/ | 20:24:33 |