| 8 Feb 2023 |
 @elvishjerricco:matrix.org | https://github.com/systemd/systemd/pull/26348 | 03:12:31 |
 @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
https://github.com/systemd/systemd/pull/26348 I saw yuwata responded to your PR. Having a pre-any-filesystem sync point would make sense exactly for stuff like hibernate/resume, so I'm not sure what their motivation for limiting the change to just adding Before=sysroot.mount sysusr-usr.mount to systemd-hibernate-resume@.service is (and also shouldn't it be sysusr-usr.mount instead of sysroot-usr.mount, since sysusr-usr.mount comes first?) | 15:20:12 |
| @lily:lily.flowers | Are they concerned about the local part of local-fs-pre? Because there could also just be a new pre-mount target they're after. Because resume docs for kernel are pretty clear it needs to come before all mounts, period | 15:21:09 |
| @lily:lily.flowers | * Are they concerned about the local part of local-fs-pre.target? Because there could also just be a new pre-mount target they're after. Because resume docs for kernel are pretty clear it needs to come before all mounts, period | 15:21:20 |
| @elvishjerricco:matrix.org | I'm worried they're going to tell me to create initrd-fs-pre.target | 22:13:31 |
| @elvishjerricco:matrix.org | I noted that Before=sysroot.mount doesn't even work because then systemd-fsck-root.service can be started simultaneously with systemd-hibernate-resume@.service, which seems broken. | 22:14:52 |
| @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
I'm worried they're going to tell me to create initrd-fs-pre.target I mean that probably wouldn't be a bad thing to have | 22:20:13 |
| @elvishjerricco:matrix.org | It just seems pointless though | 22:24:54 |
| @elvishjerricco:matrix.org | The reason for the difference between local-fs.target and initrd-fs.target is so that initrd-switch-root can pull in initrd-fs and not local-fs, causing the initrd's local-fs units to be unmounted / stopped. But local-fs-pre.target is supposed to not have any Wants dependencies, isn't it? So stopping that for switch-root should be no problem? | 22:29:27 |
| @elvishjerricco:matrix.org | * The reason for the difference between local-fs.target and initrd-fs.target is so that initrd-switch-root can pull in initrd-fs and not local-fs, causing the initrd's local-fs units to be unmounted / stopped. But local-fs-pre.target is supposed to not have any Wants dependencies, isn't it? So stopping that for switch-root when some relevant units are ordered before it should be no problem? | 22:29:41 |
| 9 Feb 2023 |
| @elvishjerricco:matrix.org | Oh btw this is ready for review now that 252.5 is in staging: https://github.com/NixOS/nixpkgs/pull/208269 | 03:23:37 |
| @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
Oh btw this is ready for review now that 252.5 is in staging: https://github.com/NixOS/nixpkgs/pull/208269 I left a review with the only comment I had. I'll try running the PR on my own laptop after staging-next is merged, to ensure it doesn't regress anything on my system | 17:08:08 |
| 12 Feb 2023 |
 @kranzes:matrix.org | How's networking support going? | 00:08:59 |
| @elvishjerricco:matrix.org | I've been using it reliably. Seems better than scripted initrd's networking so far. | 00:09:31 |
| @elvishjerricco:matrix.org | That's on my list of things to work on this weekend | 00:09:38 |
| @elvishjerricco:matrix.org | Would like to get it merged soon | 00:09:45 |
| 13 Feb 2023 |
| @elvishjerricco:matrix.org | Lily Foster: FYI apparently I didn't notice that they replaced my PR with one that has the problems I mentioned: https://github.com/systemd/systemd/pull/26367 | 07:11:07 |
| @elvishjerricco:matrix.org | So I'm kinda frustrated, even though that will realistically solve the issue as far as they're concerned (since they seem to think literally only / and /usr will ever be mounted in initrd) | 07:11:46 |
| @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
Lily Foster: FYI apparently I didn't notice that they replaced my PR with one that has the problems I mentioned: https://github.com/systemd/systemd/pull/26367 Yeah I saw :( | 11:58:30 |
| @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
So I'm kinda frustrated, even though that will realistically solve the issue as far as they're concerned (since they seem to think literally only / and /usr will ever be mounted in initrd) I don't even understand why something that just hides the problem rather than fixes it is preferred, since it was never articulated in the thread what is undesirable about a sync point or why the hack is better. Yu just sorta opened a new PR without waiting for your feedback | 12:00:10 |
| 14 Feb 2023 |
 K900 | Bump: https://github.com/NixOS/nixpkgs/pull/210505 | 18:01:36 |
| K900 | Any reason I shouldn't just merge this? | 18:01:40 |
| K900 | It's been running fine on all of my machines | 18:01:47 |
| K900 | (and I'm cleaning up my pile of cherry-picks) | 18:01:55 |
| @elvishjerricco:matrix.org | K900: I still think it should be based on chroot and realpath but I don't care enough to say it shouldn't be merged | 18:08:19 |
| K900 | I'd rather run all of this after the chroot entirely tbh | 18:09:58 |
| K900 | But I'm not sure there's a good way to do that | 18:10:06 |
| K900 | Outside of wrapping systemd | 18:10:18 |
| K900 | Which is just ew | 18:10:24 |
| K900 | I'm still hoping to see the day where we don't need to do that on nixos-wsl | 18:11:29 |
