| 24 Nov 2023 |
 yannis | * This bug is already fixed in tree and should reach users soon with 120.0.1 Yureka (she/her) | 11:32:20 |
| yannis | * This bug is already fixed in tree and the fix should reach users soon with 120.0.1 Yureka (she/her) | 11:32:44 |
| yannis | * This bug (the one about 16K page size) is already fixed in tree and the fix should reach users soon with 120.0.1 Yureka (she/her) | 11:35:05 |
 l-88 | what is the wrapped firefox version ? | 11:41:15 |
|  9hp71n joined the room. | 11:55:42 |
 nbp | https://github.com/NixOS/nixpkgs/commit/8f1180704ac3 <-- the matching commit, not sure this is the revision which introduced the issue. | 12:04:19 |
| nbp | * https://github.com/NixOS/nixpkgs/commit/8f1180704ac3 <-- the matching commit, not sure this is the revision which introduced the issue. (This is likely to be unrelated) | 12:05:26 |
| nbp | As a temporary work-around firefox-bin does not have the problem, only firefox | 12:10:05 |
| l-88 | yeah. I was wondering if it wouldn't be better to use this package eventually. Is there any advantage to using firefox instead firefox-bin ? | 12:27:18 |
| yannis | If someone knows well what decides how NixOS links with libstdc++ please read https://github.com/NixOS/nixpkgs/issues/269571#issuecomment-1825621198 | 12:43:34 |
| yannis | * If someone knows well what decides how NixOS builds link with libstdc++ please read https://github.com/NixOS/nixpkgs/issues/269571#issuecomment-1825621198 | 12:43:48 |
 hexa | l-88: what nixos version are you on btw? | 12:56:24 |
| hexa | ah yeah, seems to be limited to 23.05 | 12:58:13 |
| hexa | hm | 12:58:14 |
| l-88 | yes 23.05 | 13:00:54 |
| hexa | In reply to @yannis:mozilla.org
If someone knows well what decides how NixOS builds link with libstdc++ please read https://github.com/NixOS/nixpkgs/issues/269571#issuecomment-1825621198 reposted to #stdenv:nixos.org | 13:06:47 |
| yannis | Thanks! | 14:01:41 |
| yannis | On the Firefox side we are only receiving crashes from 23.05 | 14:02:02 |
| hexa | yes, I checked the crash stats to confirm that earlier | 14:02:19 |
| hexa | ok, so firefox 120.0 isn't crashing for me exactly | 14:34:44 |
| hexa | but webgl support is failing with | 14:34:52 |
| hexa |
Status: WebGL creation failed: * WebglAllowWindowsNativeGl:false restricts context creation on this system. () * Exhausted GL driver options. (FEATURE_FAILURE_WEBGL_EXHAUSTED_DRIVERS)
| 14:34:56 |
| hexa | so I'm having a hard time to reproduce | 14:35:12 |
| nbp | I was able to reproduce the issue earlier. I can try patches if needed. | 14:35:37 |
| yannis | Also nm -D can be used first to distinguish good builds from bad builds if you can't reproduce. | 14:37:53 |
| hexa | $ nm -D result/bin/.firefox-wrapped| grep _S_initialize
00000000000c55c0 T _ZNSt6locale13_S_initializeEv
00000000000c5560 T _ZNSt6locale18_S_initialize_onceEv
00000000000c2860 T _ZNSt6locale5facet18_S_initialize_onceEv
| 14:44:09 |
| hexa | ok, the T here is bad | 14:44:16 |
| hexa | diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix
index aadbb32d6e02..7a00670ebc44 100644
--- a/pkgs/applications/networking/browsers/firefox/common.nix
+++ b/pkgs/applications/networking/browsers/firefox/common.nix
@@ -497,6 +497,8 @@ buildStdenv.mkDerivation ({
preBuild = ''
cd mozobj
+ '' + lib.optionalString (stdenv.cc.isGNU) ''
+ export NIX_LDFLAGS="-L${stdenv.cc.cc.lib}/lib"
'' + lib.optionalString (lib.versionAtLeast version "120") ''
# https://bugzilla.mozilla.org/show_bug.cgi?id=1864083
export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE $(pkg-config dbus-1 --cflags)"
| 14:44:38 |
| hexa | * diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix
index aadbb32d6e02..7a00670ebc44 100644
--- a/pkgs/applications/networking/browsers/firefox/common.nix
+++ b/pkgs/applications/networking/browsers/firefox/common.nix
@@ -497,6 +497,8 @@ buildStdenv.mkDerivation ({
preBuild = ''
cd mozobj
+ '' + lib.optionalString stdenv.cc.isGNU ''
+ export NIX_LDFLAGS="-L${stdenv.cc.cc.lib}/lib"
'' + lib.optionalString (lib.versionAtLeast version "120") ''
# https://bugzilla.mozilla.org/show_bug.cgi?id=1864083
export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE $(pkg-config dbus-1 --cflags)"
| 14:44:52 |
| hexa | this is the patch I'm trying | 14:44:58 |
