| 20 Sep 2023 |
Artturin | * gonna try to add timeout | 18:08:50 |
colemickens | wdyt, I can just move the nix flake check to a separate step and add a time out for it? | 18:08:56 |
colemickens | I'll wait for you | 18:09:02 |
colemickens | * I'll wait for you (and not make the most recent change) gonna force push right now | 18:09:17 |
colemickens | feel free to push it if you get it going, I've gotta get some air and food. | 18:10:18 |
colemickens | (manually canceling runs for now to save the minutes) | 18:11:10 |
Artturin | found https://github.com/NixOS/nixpkgs/pull/192593 gonna rebase it to resolve conflicts | 18:21:58 |
colemickens | You thinking of patching the input nixpkgs with that, then? (also, nice!) | 18:31:49 |
Artturin | Ok BTW https://github.com/NixOS/nix/pull/6530 will have support for patchFiles in inputs | 18:43:07 |
Artturin | * Yeah BTW https://github.com/NixOS/nix/pull/6530 will have support for patchFiles in inputs | 18:43:19 |
Artturin | colemickens: I'm going to rewrite the flake so that forAllSystems doesn't have to be repeated everywhere | 19:37:16 |
Artturin | * colemickens: I'm going to refactor the flake so that forAllSystems doesn't have to be repeated everywhere | 19:37:21 |
colemickens | 👍 | 19:37:50 |
Artturin | In reply to @colemickens:matrix.org 👍 is xarch much system to mozilla system | 20:11:45 |
Artturin | In reply to @colemickens:matrix.org 👍 * is xarch juch system to mozilla system | 20:11:50 |
Artturin | * is xarch just system to mozilla system | 20:11:52 |
colemickens | yes | 20:12:45 |
Artturin | https://github.com/nix-community/flake-firefox-nightly/pull/23 | 20:16:30 |
K900 ⚡️ | So this is a problem | 20:32:32 |
K900 ⚡️ | Based on the conversation on the issue, Firefox basically hardcodes an offset into the binary now | 20:32:55 |
K900 ⚡️ | Which means patchelf can't really be expected to work | 20:33:14 |
K900 ⚡️ | Unless | 20:33:44 |
K900 ⚡️ | Unless we do even more horrible things | 20:34:18 |
hexa | in all fairness, they do call it a hack | 20:36:23 |
K900 ⚡️ | I think I have a horrible idea but I'll have to look at patchelf code to see if it can work | 20:39:26 |
K900 ⚡️ | Basically, what if instead of moving all the sections around, we just unlist the old dynamic section and add our new one at the end | 20:42:53 |
K900 ⚡️ | Actually I wonder what the linker will do if you just have more than one .dynamic section | 20:44:03 |
colemickens | In reply to @artturin:matrix.org https://github.com/nix-community/flake-firefox-nightly/pull/23 ready? I can merge | 20:48:41 |
colemickens | oops, just saw its still a draft. no rush | 20:48:59 |
Artturin | ready | 20:50:23 |