!RROtHmAaQIkiJzJZZE:nixos.org

NixOS Infrastructure

387 Members
Next Infra call: 2024-07-11, 18:00 CEST (UTC+2) | Infra operational issues backlog: https://github.com/orgs/NixOS/projects/52 | See #infra-alerts:nixos.org for real time alerts from Prometheus.116 Servers

Load older messages


SenderMessageTime
19 Mar 2026
@hexa:lossy.networkhexa (signing key rotation when)Works for me12:08:15
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)

Don't think so. With a dummy python server with h1.1 I do get reuse:

curl: Reusing existing http: connection with host localhost
downloading 'http://localhost:9000/9x7dq2sgrw63d93pa5lyk51hgwsmmn9k.narinfo'...
12:15:58
@joerg:thalheim.ioMic92https://github.com/NixOS/infra/pull/98212:17:11
@joerg:thalheim.ioMic92I am checking also what the aws sdk is actually doing, since it's also using curl12:22:47
@joerg:thalheim.ioMic92https://github.com/aws/aws-sdk-cpp/blob/9204e236faaa1ca6a0342dee7caf61c7cf5ad8bb/src/aws-cpp-sdk-core/source/http/curl/CurlHandleContainer.cpp#L172-L17612:24:33
@joerg:thalheim.ioMic92So looks like we always had keep-alive12:25:12
@joerg:thalheim.ioMic92but aws does it's own pooling12:26:48
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)It might have retries for the error. Also one thing to note is that old code didn't run concurrent s3 requests at all, since it was using the blocking API. Now we fire off a bunch of requests in parallel.12:26:53
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)We do curl_multi pooling too, that does reuse the handles12:27:25
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Or rather the connections for the easy handles12:27:36
@joerg:thalheim.ioMic92aws, doesn't seem to use this interface12:28:30
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Well it effectively does the same thing. What aws probably does is retry on that 400 error12:29:30
@arianvp:matrix.orgArian
In reply to @joerg:thalheim.io
but aws does it's own pooling
Only if you use the transfer API iirc which we didn't
12:32:54
@arianvp:matrix.orgArianFor S3 you also need to retry on 503 for uploads https://docs.aws.amazon.com/AmazonS3/latest/userguide/optimizing-performance-design-patterns.html12:34:08
@arianvp:matrix.orgArianThey use 503 for rate limit :')12:34:30
@joerg:thalheim.ioMic92https://github.com/aws/aws-sdk-cpp/blob/9204e236faaa1ca6a0342dee7caf61c7cf5ad8bb/src/aws-cpp-sdk-core/source/client/CoreErrors.cpp#L90-L9112:35:08
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Yup bernardo added that in https://github.com/NixOS/nix/pull/1544912:35:11
@arianvp:matrix.orgArianSweet12:35:38
@joerg:thalheim.ioMic92where dos this handle 400?12:37:33
@joerg:thalheim.ioMic92* where does this handle 400?12:37:39
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)I was talking about 503, 400 is not handled there. We'd need to look at the response xml12:38:17
@arianvp:matrix.orgArianLine 11312:38:56
@arianvp:matrix.orgArianDecides if an error is retry able 12:39:11
@joerg:thalheim.ioMic92True, but I think Sergei is right, we need to look at the xml12:41:00
@joerg:thalheim.ioMic92deploying this now12:44:59
@joerg:thalheim.ioMic92how did you came up with this number, so I can monitor?12:49:53
@hexa:lossy.networkhexa (signing key rotation when)journalctl -u hydra-queue-runner --since "2 days ago" --grep="unable to upload" | wc -l12:50:38
@joerg:thalheim.ioMic92okay, we don't have any upload error since: Thu Mar 19 01:01:45 PM UTC 202613:02:00
@joerg:thalheim.ioMic92Let's see13:02:05
@joerg:thalheim.ioMic92journalctl -u hydra-queue-runner --since "3 hour ago" --grep="unable to upload" is also empty13:02:13

There are no newer messages yet.


Back to Room ListRoom Version: 6