| 24 Jun 2026 |
K900 | OK actually it's like five lines of code | 07:28:59 |
K900 | Let me just do a PR | 07:29:01 |
Vladimír Čunát | I still wouldn't be too happy if a builder built stuff against a local version of a dependency instead of waiting for the official one which ends up in S3. | 07:29:29 |
Vladimír Čunát | * I still wouldn't be too happy if a builder built stuff against a local version of a dependency instead of waiting for the "official one" which ends up in S3. | 07:29:40 |
Vladimír Čunát | Smells like rare weird effects if for stuff which isn't 100% binary reproducible. | 07:30:15 |
Vladimír Čunát | * Smells like rare weird effects for stuff which isn't 100% binary reproducible. | 07:30:22 |
Mic92 | it's actually the same NAR in this case | 07:30:29 |
Mic92 | so same content | 07:30:43 |
Vladimír Čunát | I meant generally. | 07:30:57 |
Vladimír Čunát | We probably can't afford to assume that the NAR would always be the same. | 07:31:22 |
Mic92 | I think queue runner itself should dedup derivation already at a higher level | 07:32:10 |
Mic92 | so it's not like the same build run twice | 07:32:37 |
dramforever | we upload nar/{narhash}.nar.zst now right? | 07:32:48 |
Vladimír Čunát | 🤔 but that won't persist if we restart the queue-runner and the leftover build result might persist on the builder? | 07:32:54 |
Vladimír Čunát | * 🤔 but this deduplication won't persist if we restart the queue-runner and the leftover build result might persist on the builder? | 07:33:02 |
dramforever | so if it's just nar then the contents would be identical | 07:33:02 |
Vladimír Čunát | * 🤔 but this deduplication won't persist if we restart the queue-runner and the leftover build result might persist on the builder? Though that seems hard to avoid. | 07:33:25 |
Mic92 | builds are stopped when queue runner restarts | 07:33:28 |
Vladimír Čunát | OK, sounds like it should be rare. | 07:33:53 |
Vladimír Čunát | At least after we get that dedup which we don't have yet, if I understand you correctly? | 07:34:10 |
K900 | https://github.com/NixOS/hydra/pull/1811 | 07:39:17 |
K900 | OK this should do it | 07:39:20 |
Mic92 | looks good | 07:43:29 |
K900 |  Download Tried it on a real log from browser devtools | 07:45:28 |
K900 | It definitely renders things | 07:45:35 |
K900 | (also what the fuck is a groonga) | 07:46:10 |
Sergei Zimmerman (xokdvium) | In reply to @vcunat:matrix.org 🤔 but this deduplication won't persist if we restart the queue-runner and the leftover build result might persist on the builder? Though that seems hard to avoid. It will. Retires on different builder are also a concern. Frankenbuilds are a thing definitely | 07:46:13 |
Arian | In reply to @vcunat:matrix.org I still wouldn't be too happy if a builder built stuff against a local version of a dependency instead of waiting for the "official one" which ends up in S3. Yeh these Franken builds are annoying | 07:59:27 |
dramforever | looks like the new queue runner is supposed to be uploading build logs, so that's odd | 08:03:31 |
Mic92 | dramforever: check for content-encoding. Earlier version changed didn't included that in the upload | 08:24:25 |