!UNVBThoJtlIiVwiDjU:nixos.org

Staging

311 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/108 Servers

Load older messages


SenderMessageTime
29 Nov 2025
@k900:0upti.meK900Bumped by one13:26:22
@k900:0upti.meK900Yeah13:26:23
@k900:0upti.meK900Conditional breakpoint time?13:26:39
@dramforever:matrix.orgdramforeveroh dear13:28:38
@dramforever:matrix.orgdramforeverwait i don't have to run it with refcnt log now, if i can just break on the function13:29:09
@k900:0upti.meK900Well you don't know what the function is13:33:54
@k900:0upti.meK900But you can break on refcnt_add probably13:33:59
@dramforever:matrix.orgdramforeveri have a backtrace13:34:58
@dramforever:matrix.orgdramforeverlast 2000 lines of refcnt.log for reference https://gist.github.com/dramforever/7689f686881cb863039614ef1ef1e0e013:35:22
@k900:0upti.meK900I want to see when it's created13:38:13
@k900:0upti.meK900Not when it's dereferenced13:38:16
@dramforever:matrix.orgdramforeveroh good point13:40:28
30 Nov 2025
@hexa:lossy.networkhexahttps://github.com/NixOS/nixpkgs/issues/46641700:11:01
@hexa:lossy.networkhexaThat sound like the same Firefox issue, no?00:11:25
@robert:funklause.dedotlambda Do the automatic merges master -> staging-next and staging-next -> staging only happen if both succeed? 00:17:09
@limwa:matrix.orgAndré LimaLooking at the workflow file, I'd say they're independent00:19:39
@robert:funklause.dedotlambda I was expecting the merges to have happened just now but neither did. However, only the staging-next -> staging one has a merge conflict 00:20:02
@robert:funklause.dedotlambdaOh, it just appeared 🎉00:20:43
@limwa:matrix.orgAndré Lima Master -> staging-next just finished 00:20:52
@limwa:matrix.orgAndré Lima staging-next -> staging failed 00:21:03
@robert:funklause.dedotlambdaI'll do that one manually00:21:44
@grimmauld:m.grimmauld.deGrimmauld (any/all)
In reply to @robert:funklause.de
I was expecting the merges to have happened just now but neither did. However, only the staging-next -> staging one has a merge conflict
Committers can manually launch the action BTW, so it you are ever waiting for something specific you can just be impatient and kick it
00:22:02
@grimmauld:m.grimmauld.deGrimmauld (any/all)Doesn't work if there is conflicts ofc00:22:18
@grimmauld:m.grimmauld.deGrimmauld (any/all)But if you do resolve conflicts it's a good idea to kick it manually still, just to male sure that merge commit propagates. Conflicts on conflicts are no fun.00:23:01
@grimmauld:m.grimmauld.deGrimmauld (any/all)* But if you do resolve conflicts it's a good idea to kick it manually afterwards still, just to make sure that merge commit propagates. Conflicts on conflicts are no fun.00:23:26
@robert:funklause.dedotlambdaI don't understand. Which merge are you worried might create another conflict?00:25:01
@grimmauld:m.grimmauld.deGrimmauld (any/all)
In reply to @robert:funklause.de
I don't understand. Which merge are you worried might create another conflict?
Its more about accidental discards of commits. We had merge conflicts resolved on staging-next by creating a merge commit. But then the next automerge after got a new conflict, requiring manual resolution again. But because the staging side of that second co flict didn't have the base resolution, mistakes happened and some hunks were lost in the process. Cleaning that up took some got magic. Its just less error prone to make sure merges made to staging-next propagate immediately, e.g. by kicking the action. If the cobflict is in next -> staging, its less bad of a concern though
00:32:26
@robert:funklause.dedotlambdaI could also test that manually by merging my local branches but sure, I'll start the automatic merge jobs again00:33:26
@grimmauld:m.grimmauld.deGrimmauld (any/all)I mean, it might well be voodoo, git can be weird sometimes. My understanding is probably a bit off here.00:36:04
@robert:funklause.dedotlambdaActually, it looks like the job didn't create new commits cause no commits were made to master in the meantime00:39:37

There are no newer messages yet.


Back to Room ListRoom Version: 6