!UNVBThoJtlIiVwiDjU:nixos.org

Staging

400 Members
Staging merges | Find currently open staging-next PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+sort%3Aupdated-desc+head%3Astaging-next+head%3Astaging-next-21.05+is%3Aopen128 Servers

Load older messages


SenderMessageTime
30 Jun 2026
@k900:0upti.meK900 And we're calling update when we shouldn't 15:12:48
@k900:0upti.meK900 But ideally we'd just call update and it'll tell us if it did nothing 15:12:59
@k900:0upti.meK900 And then we can probably just drop all the bootctl status parsing nonsense 15:14:09
@elvishjerricco:matrix.orgElvishJerricco yea so options are: 1) fix our check so it doesn't look at that fallback binary, 2) patch bootctl to have a check command 3) patch bootctl update to let you know if it did nothing, but that seems less generally useful than having check too, 4) use varlink to tell the same thing, but that won't work in chroot 15:14:23
@k900:0upti.meK900We just call varlink if it exists and otherwise we call update --graceful15:14:29
@elvishjerricco:matrix.orgElvishJerriccooh15:14:41
@k900:0upti.meK900 In chroot it never exits 1 15:14:42
@elvishjerricco:matrix.orgElvishJerriccothat's a good point15:14:43
@k900:0upti.meK900 Because it's graceful 15:14:46
@elvishjerricco:matrix.orgElvishJerriccograceful on the fallback15:14:49
@k900:0upti.meK900 Because it's a stupid chroot check 15:14:53
@elvishjerricco:matrix.orgElvishJerriccogood idea15:14:55
@k900:0upti.meK900So I think varlink and fall back to update --graceful is noop for chroots15:15:14
@elvishjerricco:matrix.orgElvishJerricco I mean, bootctl is the kinda tool where I'm not happy for it to require varlink. So I don't actually like us using the varlink 15:15:23
@k900:0upti.meK900 And improvement for most other things 15:15:24
@elvishjerricco:matrix.orgElvishJerriccowait, well adding --graceful isn't a noop in chroot, right? It's still going to turn some failures into non-failures?15:16:04
@k900:0upti.meK900 No 15:16:11
@k900:0upti.meK900 It literally forces graceful 15:16:17
@k900:0upti.meK900When it detects a chroot15:16:20
@elvishjerricco:matrix.orgElvishJerriccowe do or bootctl does?15:16:24
@k900:0upti.meK900bootctl15:16:29
@elvishjerricco:matrix.orgElvishJerriccohuh, did not know that15:16:36
@k900:0upti.meK900 Guess how I fucking found out 15:16:49
@elvishjerricco:matrix.orgElvishJerriccolol15:16:54
@elvishjerricco:matrix.orgElvishJerricco hm, it does ARG_GRACEFUL_FORCE, how does that differ from ARG_GRACEFUL_YES? 15:18:48
@k900:0upti.meK900It's even forcer15:19:48
@elvishjerricco:matrix.orgElvishJerricco

this is the only line that cares about the difference:

        b.graceful = arg_graceful() == ARG_GRACEFUL_FORCE ||
                (operation == INSTALL_UPDATE && arg_graceful() != ARG_GRACEFUL_NO);
15:20:34
@elvishjerricco:matrix.orgElvishJerriccowild15:20:34
@elvishjerricco:matrix.orgElvishJerriccoSo I guess that means it's different for the other install-like commands15:21:47
@elvishjerricco:matrix.orgElvishJerriccowhich I think don't matter?15:22:04

Show newer messages


Back to Room ListRoom Version: 6