| 30 Jun 2026 |
K900 | And we're calling update when we shouldn't | 15:12:48 |
K900 | But ideally we'd just call update and it'll tell us if it did nothing | 15:12:59 |
K900 | And then we can probably just drop all the bootctl status parsing nonsense | 15:14:09 |
ElvishJerricco | yea so options are: 1) fix our check so it doesn't look at that fallback binary, 2) patch bootctl to have a check command 3) patch bootctl update to let you know if it did nothing, but that seems less generally useful than having check too, 4) use varlink to tell the same thing, but that won't work in chroot | 15:14:23 |
K900 | We just call varlink if it exists and otherwise we call update --graceful | 15:14:29 |
ElvishJerricco | oh | 15:14:41 |
K900 | In chroot it never exits 1 | 15:14:42 |
ElvishJerricco | that's a good point | 15:14:43 |
K900 | Because it's graceful | 15:14:46 |
ElvishJerricco | graceful on the fallback | 15:14:49 |
K900 | Because it's a stupid chroot check | 15:14:53 |
ElvishJerricco | good idea | 15:14:55 |
K900 | So I think varlink and fall back to update --graceful is noop for chroots | 15:15:14 |
ElvishJerricco | I mean, bootctl is the kinda tool where I'm not happy for it to require varlink. So I don't actually like us using the varlink | 15:15:23 |
K900 | And improvement for most other things | 15:15:24 |
ElvishJerricco | wait, well adding --graceful isn't a noop in chroot, right? It's still going to turn some failures into non-failures? | 15:16:04 |
K900 | No | 15:16:11 |
K900 | It literally forces graceful | 15:16:17 |
K900 | When it detects a chroot | 15:16:20 |
ElvishJerricco | we do or bootctl does? | 15:16:24 |
K900 | bootctl | 15:16:29 |
ElvishJerricco | huh, did not know that | 15:16:36 |
K900 | Guess how I fucking found out | 15:16:49 |
ElvishJerricco | lol | 15:16:54 |
ElvishJerricco | hm, it does ARG_GRACEFUL_FORCE, how does that differ from ARG_GRACEFUL_YES? | 15:18:48 |
K900 | It's even forcer | 15:19:48 |
ElvishJerricco | this is the only line that cares about the difference:
b.graceful = arg_graceful() == ARG_GRACEFUL_FORCE ||
(operation == INSTALL_UPDATE && arg_graceful() != ARG_GRACEFUL_NO);
| 15:20:34 |
ElvishJerricco | wild | 15:20:34 |
ElvishJerricco | So I guess that means it's different for the other install-like commands | 15:21:47 |
ElvishJerricco | which I think don't matter? | 15:22:04 |