Staging | 395 Members | |
| Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.11 | Review Reports: https://malob.github.io/nix-review-tools-reports/ | 128 Servers |
| Sender | Message | Time |
|---|---|---|
| 28 Jun 2026 | ||
| true. we could probably figure something out though. links or whatever. GHA can do custom buttons and stuff | 21:12:26 | |
| or the bot could just edit it in to your PR message | 21:12:36 | |
| We also might want to have better linking. Something like a central file for all questions that branches out into the correct files | 21:13:15 | |
| I always have issues finding something and rely on search engine foo | 21:13:39 | |
| The answer tends to be "somewhere in the repo" | 21:14:31 | |
| python-updates was mostly fine | 21:14:31 | |
| one numpy 2.5.0 merge that didn't test jack shit is now causing all kinds of deprecationwarnings and api breakages | 21:14:59 | |
I believe CONTRIBUTING.md actually links to all the other docs like pkgs/README.md? | 21:16:17 | |
| but yeah it's pretty confusing | 21:16:21 | |
| I think it's just a lot to take in | 21:21:49 | |
| yeah, the ideal would be presenting the high-level principles and most important requirements upfront in a screen or two of text, with links to more detail | 21:25:56 | |
| The people with whom i talked about starting out contributing mostly were willing to learn/read a lot, just intimidated by the amount of shit we have, scared to overlook something. Which, admittedly, it is quite easy to overlook something. When i review things, i try not to waste my or the reviewees time. Our documentation is currently NOT structured in a way that attempts to not waste time. Its dumped in random places, and even just getting an overview is a significant investment we expect new contributors to do. I don't think this is idea. | 21:26:22 | |
| * The people with whom i talked about starting out contributing mostly were willing to learn/read a lot, just intimidated by the amount of shit we have, scared to overlook something. Which, admittedly, it is quite easy to overlook something. When i review things, i try not to waste my or the reviewees time. Our documentation is currently NOT structured in a way that attempts to not waste time. Its dumped in random places, and even just getting an overview is a significant investment we expect new contributors to do. I don't think this is ideal. | 21:26:26 | |
| can't avoid writing down specifics, but right now you have to wade through lots of tl;dr detail just to learn all the basic expectations about patching, commit messages etc. | 21:26:34 | |
| And even then its a mess. I think we still don't have consensus about the fetchpatch2 situation... | 21:27:53 | |
| maybe these can be moved up in the contrib.md so its the first thing seen? | 21:28:22 | |
| I think it's more like even with consensus we don't have people putting the effort into fixing things | 21:28:33 | |
| if documentation were all in files, that'd be one thing. But sending newbies to years-ongoing technical discussions is bad | 21:28:33 | |
| myself included, it's just a rabbit hole I don't have time for | 21:28:45 | |
| and nobody owns our contributing docs really | 21:28:52 | |
| sure | 21:29:01 | |
| it would be very high-value work if people wanted to improve them | 21:29:18 | |
| everyones workflow is different. I have ideas how i would want contributing docs to be structured, but collecting all the things that need to be documented is tedious and making it work for everyone is basically impossible | 21:30:37 | |
| well, right now they work for nobody :) | 21:32:39 | |
I'd want:
git-merge-base master staging- tell people to STOP WASTING COMPUTE with nixpkgs-review without thinking- tell people to think? XD
- a new package/module - exiting packages/modules - existing contributors/committers - how to do (good) reviews that are useful, even if the reviewer is not a committer - includes security considerations
- examples - "inspiration" from how other distros do things (and how that translates to nix)< | 21:37:37 | |
I'd want:
git-merge-base master staging- tell people to STOP WASTING COMPUTE with nixpkgs-review without thinking- tell people to think? XD
- a new package/module - exiting packages/modules - existing contributors/committers - how to do (good) reviews that are useful, even if the reviewer is not a committer - includes security considerations
- examples - "inspiration" from how other distros do things (and how that translates to nix)
| 21:37:56 | |
| okay formatting got butchered in my matrix client.... | 21:38:08 | |
I'd want: | 21:38:19 | |
| ther,e thats a bit less awful+ | 21:38:34 | |
| * there, thats a bit less awful | 21:38:39 | |