!UNVBThoJtlIiVwiDjU:nixos.org

Staging

394 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.11 | Review Reports: https://malob.github.io/nix-review-tools-reports/127 Servers

Load older messages


SenderMessageTime
28 Jun 2026
@elvishjerricco:matrix.orgElvishJerriccoactually15:57:07
@elvishjerricco:matrix.orgElvishJerriccocan we just patch that in and submit it upstream?15:57:21
@elvishjerricco:matrix.orgElvishJerriccothat seems way better, assuming they'll take it upstream15:57:29
@elvishjerricco:matrix.orgElvishJerriccowhich it seems like something reasonable for them to have15:57:39
@emilazy:matrix.orgemily Randy Eckenrode: put up https://github.com/NixOS/nixpkgs/pull/536363 16:45:08
@emilazy:matrix.orgemilyand https://github.com/NixOS/nixpkgs/pull/53636516:54:09
@reckenrode:matrix.orgRandy EckenrodeSeems to have a bunch of unrelated stuff?17:44:45
@emilazy:matrix.orgemily that's staging-nextstaging delta 17:45:10
@emilazy:matrix.orgemilywill go away on the periodic merge17:45:17
@emilazy:matrix.orgemily(after the first PR)17:45:23
@lach:delta.rocksLach joined the room.20:22:59
@lach:delta.rocksLachHi There is a pretty annoying regression on staging (and now in staging-next), which causes the systems with overcommit enabled to OOM during build: https://github.com/NixOS/nixpkgs/pull/535423 Python cryptography package expects allocation + filling of 4TiB of memory to fail with allocation error, but with overcommit enabled this just causes OOM Can this patch be accepted to staging-next?20:25:09
@lach:delta.rocksLachThis patch was already merged upstream20:25:51
@hexa:lossy.networkhexa
Download
20:27:54
@hexa:lossy.networkhexaroadblock20:27:58
@lach:delta.rocksLach(Didn't knew anyone looked at checkmarks) Marked first, llms were not used so the second20:29:52
@hexa:lossy.networkhexawe absolutely do20:30:42
@winter:catgirl.cloudWinterwhy would we have them if nobody looks at them? 😅20:42:59
@lach:delta.rocksLachMost of the time I'm seeing them empty :D20:45:09
@hexa:lossy.networkhexawe should just autoclose if nothing is checked tbh20:45:36
@emilazy:matrix.orgemilyhave had thoughts about splitting the checklist into "things relevant for every PR" / "things new contributors should look at"21:01:07
@emilazy:matrix.orgemilyand hooking automated triage off that21:01:14
@emilazy:matrix.orgemilytbh we could probably drop a few of the extraneous checklist items21:01:36
@emilazy:matrix.orgemilyeverything between built on platform and CONTRIBUTING.md is pretty inconsistent value21:02:35
@grimmauld:m.grimmauld.deGrimmauld (any/all) I'd love a "review template" for that stuff, but i don't think github can do that... 21:07:37
@emilazy:matrix.orgemily the thing about the CONTRIBUTING.md checkbox is that nobody is actually going through every provision in it every PR to check whether they're in compliance 21:08:34
@emilazy:matrix.orgemilybut we definitely want new contributors to read it21:08:42
@emilazy:matrix.orgemilymy thinking is that the PR checklist itself should be minimal and focused on the high-importance stuff you should be checking every PR, and then first-time contributors get a bot reply with extra checkboxes for stuff we want people to learn about at the start21:09:36
@kuflierl:matrix.orgkuflierlTo be fair, i did the first 2 times or so. I don't anymore since i think i now most of it21:09:37
@emilazy:matrix.orgemilyand the reward for those is you get the PR assigned to a round-robin new user contribution triage team21:09:49

Show newer messages


Back to Room ListRoom Version: 6