| 28 Jun 2026 |
ElvishJerricco | actually | 15:57:07 |
ElvishJerricco | can we just patch that in and submit it upstream? | 15:57:21 |
ElvishJerricco | that seems way better, assuming they'll take it upstream | 15:57:29 |
ElvishJerricco | which it seems like something reasonable for them to have | 15:57:39 |
emily | Randy Eckenrode: put up https://github.com/NixOS/nixpkgs/pull/536363 | 16:45:08 |
emily | and https://github.com/NixOS/nixpkgs/pull/536365 | 16:54:09 |
Randy Eckenrode | Seems to have a bunch of unrelated stuff? | 17:44:45 |
emily | that's staging-next → staging delta | 17:45:10 |
emily | will go away on the periodic merge | 17:45:17 |
emily | (after the first PR) | 17:45:23 |
| Lach joined the room. | 20:22:59 |
Lach | Hi
There is a pretty annoying regression on staging (and now in staging-next), which causes the systems with overcommit enabled to OOM during build: https://github.com/NixOS/nixpkgs/pull/535423
Python cryptography package expects allocation + filling of 4TiB of memory to fail with allocation error, but with overcommit enabled this just causes OOM
Can this patch be accepted to staging-next? | 20:25:09 |
Lach | This patch was already merged upstream | 20:25:51 |
hexa |  Download | 20:27:54 |
hexa | roadblock | 20:27:58 |
Lach | (Didn't knew anyone looked at checkmarks)
Marked first, llms were not used so the second | 20:29:52 |
hexa | we absolutely do | 20:30:42 |
Winter | why would we have them if nobody looks at them? 😅 | 20:42:59 |
Lach | Most of the time I'm seeing them empty :D | 20:45:09 |
hexa | we should just autoclose if nothing is checked tbh | 20:45:36 |
emily | have had thoughts about splitting the checklist into "things relevant for every PR" / "things new contributors should look at" | 21:01:07 |
emily | and hooking automated triage off that | 21:01:14 |
emily | tbh we could probably drop a few of the extraneous checklist items | 21:01:36 |
emily | everything between built on platform and CONTRIBUTING.md is pretty inconsistent value | 21:02:35 |
Grimmauld (any/all) | I'd love a "review template" for that stuff, but i don't think github can do that... | 21:07:37 |
emily | the thing about the CONTRIBUTING.md checkbox is that nobody is actually going through every provision in it every PR to check whether they're in compliance | 21:08:34 |
emily | but we definitely want new contributors to read it | 21:08:42 |
emily | my thinking is that the PR checklist itself should be minimal and focused on the high-importance stuff you should be checking every PR, and then first-time contributors get a bot reply with extra checkboxes for stuff we want people to learn about at the start | 21:09:36 |
kuflierl | To be fair, i did the first 2 times or so. I don't anymore since i think i now most of it | 21:09:37 |
emily | and the reward for those is you get the PR assigned to a round-robin new user contribution triage team | 21:09:49 |