!UUYziobKGGxpovWyAN:nixos.org

Robotnix

249 Members
Build Android (AOSP) using Nix | https://github.com/danielfullmer/robotnix77 Servers

Load older messages

SenderMessageTime
25 Oct 2021
@kranzes:matrix.orgkranzesSeems like maybe Robotnix is just too big for using the basic and free Github Actions20:55:46
@kranzes:matrix.orgkranzes🤷‍♂️20:55:52
@zhaofeng:zhaofeng.liZhaofeng Li joined the room.21:07:30
@zhaofeng:zhaofeng.liZhaofeng LiHi all, so I'm testing the new Android 12 support in Robotnix. It works fine, but despite being suppressed in https://github.com/danielfullmer/robotnix/blob/808b305de0f5b52b2b193829b1e4ee7e24cf1a7c/flavors/vanilla/12/default.nix#L41, I'm still seeing the statementservice crashes21:39:14
@zhaofeng:zhaofeng.liZhaofeng Li So I suspect that the resource overlays are somehow not being applied correctly. I don't see the overridden values in framework-res.apk, nor in framework-res__auto_generated_rro_vendor.apk in vendor 21:40:32
@danielrf:matrix.orgdanielrfresources."framsworks/base/core/res"21:45:34
@danielrf:matrix.orgdanielrfLooks like I made a spelling error21:46:00
@zhaofeng:zhaofeng.liZhaofeng LiAh, I should have noticed it 😅21:46:35
@danielrf:matrix.orgdanielrfI didn't encounter those crashes on sunfish, so I didn't notice21:46:44
@danielrf:matrix.orgdanielrfThanks for letting me know though. I'll merge a PR if you'd like. Otherwise I can fix that later tonight21:48:03
@danielrf:matrix.orgdanielrfAway from my PC for till then21:48:21
@zhaofeng:zhaofeng.liZhaofeng LiBut still the misspelt config should be somewhere in the system, right? Where can I find them? I was messing with the icon outline masks earlier and couldn't find my overridden values21:48:27
@zhaofeng:zhaofeng.liZhaofeng LiYou can fix it when you have time 🙂21:48:49
@zhaofeng:zhaofeng.liZhaofeng LiOh nevermind, it shouldn't 🤦‍♂️ My problem is unrelated21:50:16
26 Oct 2021
@grahamc:nixos.org@grahamc:nixos.orgchanged room power levels.01:19:45
@mjolnir:nixos.orgNixOS Moderation Bot changed their display name from mjolnir to NixOS Moderation Bot.02:00:18
@mjolnir:nixos.orgNixOS Moderation Bot set a profile picture.02:00:35
@mjolnir:nixos.orgNixOS Moderation Bot changed their profile picture.02:23:50
@mjolnir:nixos.orgNixOS Moderation Bot changed their profile picture.02:33:19
@danvittegleo:matrix.orgdan-v danielrf: just an fyi - one more vanilla aosp 12 issue i bumped into (in addition to the intent one): https://github.com/ProtonAOSP/android_packages_apps_Settings/commit/1aa49ec5017326ec6297e9ee067eb23647618494 04:24:46
@danielrf:matrix.orgdanielrf dan-v: Thanks for the heads-up! I missed that one 04:26:07
@danielrf:matrix.orgdanielrfLooking at that patch, it seems I'm not the only one who makes typos :)04:30:03
@danvittegleo:matrix.orgdan-vhaha04:31:07
@danvittegleo:matrix.orgdan-valso, the default with vanilla aosp power button hold going to assistant that doesn't exist is pretty broken, so plan on changing that as well (https://github.com/ProtonAOSP/android_vendor_proton/blob/sc/overlay/frameworks/base/core/res/res/values/config.xml#L228)04:32:24
@danielrf:matrix.orgdanielrf Pushed new tags: vanilla-2021102614 and grapheneos-2021102503. Tested on sunfish and crosshatch, respectively. 15:24:56
@danielrf:matrix.orgdanielrfVanilla tag includes fixes for the issues we've talked about here over the last couple days15:25:21
27 Oct 2021
@puffnfresh:chat.home.brianmckenna.orgpuffnfresh set a profile picture.01:08:02
@yuka:yuka.devYuka (she/her)I changed the microG patch in my build a bit, because I could not resolve the spoofing permission issue08:47:17
@yuka:yuka.devYuka (she/her) 
diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java
index c477546..88c9390 100644
--- a/services/core/java/com/android/server/pm/PackageManagerService.java
+++ b/services/core/java/com/android/server/pm/PackageManagerService.java
@@ -818,6 +818,11 @@ public class PackageManagerService extends IPackageManager.Stub
 
     private static final String RANDOM_DIR_PREFIX = "~~";
 
+    /**
+     * The Google signature faked by microG.
+     */
+    private static final String MICROG_FAKE_SIGNATURE = "308204433082032ba003020102020900c2e08746644a308d300d06092a864886f70d01010405003074310b3009060355040613025553311330110603550408130a43616c69666f726e6961311630140603550407130d4d6f756e7461696e205669657731143012060355040a130b476f6f676c6520496e632e3110300e060355040b1307416e64726f69643110300e06035504031307416e64726f6964301e170d3038303832313233313333345a170d3336303130373233313333345a3074310b3009060355040613025553311330110603550408130a43616c69666f726e6961311630140603550407130d4d6f756e7461696e205669657731143012060355040a130b476f6f676c6520496e632e3110300e060355040b1307416e64726f69643110300e06035504031307416e64726f696430820120300d06092a864886f70d01010105000382010d00308201080282010100ab562e00d83ba208ae0a966f124e29da11f2ab56d08f58e2cca91303e9b754d372f640a71b1dcb130967624e4656a7776a92193db2e5bfb724a91e77188b0e6a47a43b33d9609b77183145ccdf7b2e586674c9e1565b1f4c6a5955bff251a63dabf9c55c27222252e875e4f8154a645f897168c0b1bfc612eabf785769bb34aa7984dc7e2ea2764cae8307d8c17154d7ee5f64a51a44a602c249054157dc02cd5f5c0e55fbef8519fbe327f0b1511692c5a06f19d18385f5c4dbc2d6b93f68cc2979c70e18ab93866b3bd5db8999552a0e3b4c99df58fb918bedc182ba35e003c1b4b10dd244a8ee24fffd333872ab5221985edab0fc0d0b145b6aa192858e79020103a381d93081d6301d0603551d0e04160414c77d8cc2211756259a7fd382df6be398e4d786a53081a60603551d2304819e30819b8014c77d8cc2211756259a7fd382df6be398e4d786a5a178a4763074310b3009060355040613025553311330110603550408130a43616c69666f726e6961311630140603550407130d4d6f756e7461696e205669657731143012060355040a130b476f6f676c6520496e632e3110300e060355040b1307416e64726f69643110300e06035504031307416e64726f6964820900c2e08746644a308d300c0603551d13040530030101ff300d06092a864886f70d010104050003820101006dd252ceef85302c360aaace939bcff2cca904bb5d7a1661f8ae46b2994204d0ff4a68c7ed1a531ec4595a623ce60763b167297a7ae35712c407f208f0cb109429124d7b106219c084ca3eb3f9ad5fb871ef92269a8be28bf16d44c8d9a08e6cb2f005bb3fe2cb96447e868e731076ad45b33f6009ea19c161e62641aa99271dfd5228c5c587875ddb7f452758d661f6cc0cccb7352e424cc4365c523532f7325137593c4ae341f4db41edda0d0b1071a7c440f0fe9ea01cb627ca674369d084bd2fd911ff06cdbf2cfa10dc0f893ae35762919048c7efc64c7144178342f70581c9de573af55b390dd7fdb9418631895d5f759f30112687ff621410c069308a";
+
     final Handler mHandler;
 
     private final ProcessLoggingHandler mProcessLoggingHandler;
@@ -3299,6 +3304,24 @@ public class PackageManagerService extends IPackageManager.Stub
             return result;
         }
 
+        private boolean requestsFakeSignature(AndroidPackage p) {
+            String packageName = p.getPackageName();
+            return packageName.equals("com.google.android.gms") || packageName.equals("com.android.vending");
+        }
+
+        private PackageInfo mayFakeSignature(AndroidPackage p, PackageInfo pi,
+                Set<String> permissions) {
+            try {
+                if (requestsFakeSignature(p)) {
+                    pi.signatures = new Signature[] {new Signature(MICROG_FAKE_SIGNATURE)};
+                }
+            } catch (Throwable t) {
+                // We should never die because of any failures, this is system code!
+                Log.w("PackageManagerService.FAKE_PACKAGE_SIGNATURE", t);
+            }
+            return pi;
+        }
+
         public final PackageInfo generatePackageInfo(PackageSetting ps, int flags, int userId) {
             if (!mUserManager.exists(userId)) return null;
             if (ps == null) {
@@ -3327,12 +3350,14 @@ public class PackageManagerService extends IPackageManager.Stub
                 final int[] gids = (flags & PackageManager.GET_GIDS) == 0 ? EMPTY_INT_ARRAY
                         : mPermissionManager.getGidsForUid(UserHandle.getUid(userId, ps.appId));
                 // Compute granted permissions only if package has requested permissions
-                final Set<String> permissions = ((flags & PackageManager.GET_PERMISSIONS) == 0
+                final Set<String> permissions = (((flags & PackageManager.GET_PERMISSIONS) == 0
+                        && !requestsFakeSignature(p))
                         || ArrayUtils.isEmpty(p.getRequestedPermissions())) ? Collections.emptySet()
                         : mPermissionManager.getGrantedPermissions(ps.name, userId);
 
-                PackageInfo packageInfo = PackageInfoUtils.generate(p, gids, flags,
-                        ps.firstInstallTime, ps.lastUpdateTime, permissions, state, userId, ps);
+                PackageInfo packageInfo = mayFakeSignature(p, PackageInfoUtils.generate(p, gids, flags,
+                        ps.firstInstallTime, ps.lastUpdateTime, permissions, state, userId, ps),
+                        permissions);
 
                 if (packageInfo == null) {
                     return null;
08:48:27
@yuka:yuka.devYuka (she/her) * 
diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java
index c477546..88c9390 100644
--- a/services/core/java/com/android/server/pm/PackageManagerService.java
+++ b/services/core/java/com/android/server/pm/PackageManagerService.java
@@ -818,6 +818,11 @@ public class PackageManagerService extends IPackageManager.Stub
 
     private static final String RANDOM_DIR_PREFIX = "~~";
 
+    /**
+     * The Google signature faked by microG.
+     */
+    private static final String MICROG_FAKE_SIGNATURE = "308204433082032ba003020102020900c2e08746644a308d300d06092a864886f70d01010405003074310b3009060355040613025553311330110603550408130a43616c69666f726e6961311630140603550407130d4d6f756e7461696e205669657731143012060355040a130b476f6f676c6520496e632e3110300e060355040b1307416e64726f69643110300e06035504031307416e64726f6964301e170d3038303832313233313333345a170d3336303130373233313333345a3074310b3009060355040613025553311330110603550408130a43616c69666f726e6961311630140603550407130d4d6f756e7461696e205669657731143012060355040a130b476f6f676c6520496e632e3110300e060355040b1307416e64726f69643110300e06035504031307416e64726f696430820120300d06092a864886f70d01010105000382010d00308201080282010100ab562e00d83ba208ae0a966f124e29da11f2ab56d08f58e2cca91303e9b754d372f640a71b1dcb130967624e4656a7776a92193db2e5bfb724a91e77188b0e6a47a43b33d9609b77183145ccdf7b2e586674c9e1565b1f4c6a5955bff251a63dabf9c55c27222252e875e4f8154a645f897168c0b1bfc612eabf785769bb34aa7984dc7e2ea2764cae8307d8c17154d7ee5f64a51a44a602c249054157dc02cd5f5c0e55fbef8519fbe327f0b1511692c5a06f19d18385f5c4dbc2d6b93f68cc2979c70e18ab93866b3bd5db8999552a0e3b4c99df58fb918bedc182ba35e003c1b4b10dd244a8ee24fffd333872ab5221985edab0fc0d0b145b6aa192858e79020103a381d93081d6301d0603551d0e04160414c77d8cc2211756259a7fd382df6be398e4d786a53081a60603551d2304819e30819b8014c77d8cc2211756259a7fd382df6be398e4d786a5a178a4763074310b3009060355040613025553311330110603550408130a43616c69666f726e6961311630140603550407130d4d6f756e7461696e205669657731143012060355040a130b476f6f676c6520496e632e3110300e060355040b1307416e64726f69643110300e06035504031307416e64726f6964820900c2e08746644a308d300c0603551d13040530030101ff300d06092a864886f70d010104050003820101006dd252ceef85302c360aaace939bcff2cca904bb5d7a1661f8ae46b2994204d0ff4a68c7ed1a531ec4595a623ce60763b167297a7ae35712c407f208f0cb109429124d7b106219c084ca3eb3f9ad5fb871ef92269a8be28bf16d44c8d9a08e6cb2f005bb3fe2cb96447e868e731076ad45b33f6009ea19c161e62641aa99271dfd5228c5c587875ddb7f452758d661f6cc0cccb7352e424cc4365c523532f7325137593c4ae341f4db41edda0d0b1071a7c440f0fe9ea01cb627ca674369d084bd2fd911ff06cdbf2cfa10dc0f893ae35762919048c7efc64c7144178342f70581c9de573af55b390dd7fdb9418631895d5f759f30112687ff621410c069308a";
+
     final Handler mHandler;
 
     private final ProcessLoggingHandler mProcessLoggingHandler;
@@ -3299,6 +3304,24 @@ public class PackageManagerService extends IPackageManager.Stub
             return result;
         }
 
+        private boolean requestsFakeSignature(AndroidPackage p) {
+            String packageName = p.getPackageName();
+            return packageName.equals("com.google.android.gms") || packageName.equals("com.android.vending");
+        }
+
+        private PackageInfo mayFakeSignature(AndroidPackage p, PackageInfo pi,
+                Set<String> permissions) {
+            try {
+                if (requestsFakeSignature(p)) {
+                    pi.signatures = new Signature[] {new Signature(MICROG_FAKE_SIGNATURE)};
+                }
+            } catch (Throwable t) {
+                // We should never die because of any failures, this is system code!
+                Log.w("PackageManagerService.FAKE_PACKAGE_SIGNATURE", t);
+            }
+            return pi;
+        }
+
         public final PackageInfo generatePackageInfo(PackageSetting ps, int flags, int userId) {
             if (!mUserManager.exists(userId)) return null;
             if (ps == null) {
@@ -3327,12 +3350,14 @@ public class PackageManagerService extends IPackageManager.Stub
                 final int[] gids = (flags & PackageManager.GET_GIDS) == 0 ? EMPTY_INT_ARRAY
                         : mPermissionManager.getGidsForUid(UserHandle.getUid(userId, ps.appId));
                 // Compute granted permissions only if package has requested permissions
-                final Set<String> permissions = ((flags & PackageManager.GET_PERMISSIONS) == 0
+                final Set<String> permissions = (((flags & PackageManager.GET_PERMISSIONS) == 0
+                        && !requestsFakeSignature(p))
                         || ArrayUtils.isEmpty(p.getRequestedPermissions())) ? Collections.emptySet()
                         : mPermissionManager.getGrantedPermissions(ps.name, userId);
 
-                PackageInfo packageInfo = PackageInfoUtils.generate(p, gids, flags,
-                        ps.firstInstallTime, ps.lastUpdateTime, permissions, state, userId, ps);
+                PackageInfo packageInfo = mayFakeSignature(p, PackageInfoUtils.generate(p, gids, flags,
+                        ps.firstInstallTime, ps.lastUpdateTime, permissions, state, userId, ps),
+                        permissions);
 
                 if (packageInfo == null) {
                     return null;
08:48:31

There are no newer messages yet.

Back to Room ListRoom Version: 6