!VRULIdgoKmKPzJZzjj:nixos.org

Nix Hackers

895 Members
For people hacking on the Nix package manager itself191 Servers

Load older messages


SenderMessageTime
7 Oct 2021
@niksnut:matrix.orgniksnutYeah, if they're not regressions12:54:38
@qyliss:fairydust.spaceAlyssa Rossisn't the musl issue a regression?14:07:06
@niksnut:matrix.orgniksnutDon't think so, since it was not part of the previous release iirc14:50:21
@niksnut:matrix.orgniksnutBut it would be great if somebody can look into it14:50:32
@balsoft:balsoft.rubalsoft While you're here sometimes I'm not getting any output even with -L on nix (Nix) 2.4pre20211001_4f49615 (and also I'm not getting the list of all derivation that failed), and it's a bit painful to reproduce. Is this a known bug that was fixed in the meantime? 14:51:33
@balsoft:balsoft.rubalsoftI would update and try to check on master, but I can't quite figure out when it happens14:51:46
@balsoft:balsoft.rubalsoftAnd also I would think it's a regression14:52:00
@sternenseemann:systemli.orgsterni niksnut: nixStatic 2.3.x is exposed top level in nixpkgs which does use musl 14:53:08
@niksnut:matrix.orgniksnut
In reply to @balsoft:balsoft.ru
While you're here sometimes I'm not getting any output even with -L on nix (Nix) 2.4pre20211001_4f49615 (and also I'm not getting the list of all derivation that failed), and it's a bit painful to reproduce. Is this a known bug that was fixed in the meantime?
Sounds like https://github.com/NixOS/nix/pull/5339
14:53:22
@balsoft:balsoft.rubalsoftNo, I think mine is different14:53:57
@balsoft:balsoft.rubalsoftIt's just in the regular terminal14:54:03
@balsoft:balsoft.rubalsoftAnd not consistently so14:54:19
@balsoft:balsoft.rubalsoft

E.g. two consequtive runs of nix-store --realise on the same derivation:

error: 1 dependencies of derivation '/nix/store/<...>-nixos-system-foo.drv' failed to build

And second one:

error: builder for '/nix/store/<...>-nginx.conf.drv' failed with exit code 1;
       last 10 log lines:
       >     }
       > }
       >
       > ==================== Summary ===================
       > Total issues:
       >     Unspecified: 0
       >     Low: 0
       >     Medium: 1
       >     High: 0
       >
       For full logs, run 'nix log /nix/store/<...>-nginx.conf.drv'.
error: 1 dependencies of derivation '/nix/store/<...>-unit-nginx.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/<...>-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/<...>-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/<...>-nixos-system-foo.drv' failed to build
14:56:18
@balsoft:balsoft.rubalsoft Also reproducible with passing -L to new nix commands 14:56:32
@balsoft:balsoft.rubalsoft(and by "reproducible" I mean it happens... sometimes)14:57:40
@andi:kack.itandi- Before diving into doing the change I had a thought yesterday while looking at related code: Any reason we don't implement Expr{Sub,Add,...} like we do for ExprNotOp etc? In the case of subtraction it could get rid of about 30k Symbol table looks, a few thousand new objects and execution wouldn't probably do a few less function calls. That would probably break overriding substraction by providing a __sub (or whatever) function in the current scope (if that even works right now). 14:58:58
@balsoft:balsoft.rubalsoft
In reply to @balsoft:balsoft.ru

E.g. two consequtive runs of nix-store --realise on the same derivation:

error: 1 dependencies of derivation '/nix/store/<...>-nixos-system-foo.drv' failed to build

And second one:

error: builder for '/nix/store/<...>-nginx.conf.drv' failed with exit code 1;
       last 10 log lines:
       >     }
       > }
       >
       > ==================== Summary ===================
       > Total issues:
       >     Unspecified: 0
       >     Low: 0
       >     Medium: 1
       >     High: 0
       >
       For full logs, run 'nix log /nix/store/<...>-nginx.conf.drv'.
error: 1 dependencies of derivation '/nix/store/<...>-unit-nginx.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/<...>-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/<...>-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/<...>-nixos-system-foo.drv' failed to build
Interestingly, I think it never happens once logs for the derivation were shown at least once
14:59:15
@andi:kack.itandi- * Before diving into doing the change I had a thought yesterday while looking at related code: Any reason we don't implement Expr{Sub,Add,...} like we do for ExprNotOp etc? In the case of subtraction it could get rid of about 30k Symbol table looks, a few thousand new objects (while building a NixOS test). And execution wouldn't probably do a few less function calls. That would probably break overriding substraction by providing a __sub (or whatever) function in the current scope (if that even works right now). 14:59:20
@balsoft:balsoft.rubalsoftI don't mind at all if this ends up in the release, but just wanted to note that it happens sometimes15:01:23
@baloo_:matrix.orgbaloo niksnut: any chance we could get a 2.3 release or merge this? https://github.com/NixOS/nixpkgs/pull/137197 I think it should fix the errors we're seeing on https://r13y.com 15:03:53
@niksnut:matrix.orgniksnutSure, I can do a release15:04:16
@niksnut:matrix.orgniksnut
In reply to @andi:kack.it
Before diving into doing the change I had a thought yesterday while looking at related code: Any reason we don't implement Expr{Sub,Add,...} like we do for ExprNotOp etc? In the case of subtraction it could get rid of about 30k Symbol table looks, a few thousand new objects (while building a NixOS test). And execution wouldn't probably do a few less function calls. That would probably break overriding substraction by providing a __sub (or whatever) function in the current scope (if that even works right now).
No, I think the reason it's implemented that way is because builtins.sub etc. already existed
15:14:19
@andi:kack.itandi-
In reply to @niksnut:matrix.org
No, I think the reason it's implemented that way is because builtins.sub etc. already existed

Would you see any downside to adding those implementations? I could have a go on the in one of the coming evenings.

I don't think that it will improve performance by a lot but I also haven't measured the time spent in those functions. I was just surprised that IIRC the sub primop was the most used one (by a few 10k) when I did eval a NixOS VM test.

15:16:49
@niksnut:matrix.orgniksnutThe only downside is that it's a bit more code15:17:36
@tomberek:matrix.orgtomberekmusl issue is related to: 499317415:19:43
@niksnut:matrix.orgniksnut
In reply to @niksnut:matrix.org
Sure, I can do a release
2.3.16 is up
15:36:21
@niksnut:matrix.orgniksnut
In reply to @tomberek:matrix.org
musl issue is related to: 4993174
Okay, we could revert that
15:37:09
@baloo_:matrix.orgbaloo niksnut: thank you so much! 15:54:59
@niksnut:matrix.orgniksnutI've created a 2.4-maintenance branch and a hydra jobset15:57:10
@niksnut:matrix.orgniksnutI'll do a rc1 release for testing15:57:19

There are no newer messages yet.


Back to Room ListRoom Version: 6