| 6 Nov 2022 |
hexa | cool! | 23:35:23 |
| 7 Nov 2022 |
Sandro | Can we still merge https://github.com/NixOS/nixpkgs/pull/196854 ? I think we need it to fix this https://github.com/NixOS/nixpkgs/issues/200022 | 13:58:25 |
hexa | probably via staging and backport into staging-22.11 | 13:59:38 |
hexa | or into staging-next now 🤔 | 13:59:54 |
hexa | * probably via staging and backport into staging-22.11(, but we're not quite there yet) | 14:00:59 |
Sandro | not sure if the pipewire build failure is related to SDL2 or another thing on staging right now | 14:04:10 |
Sandro | pipewire builds when picked ontop of staging-next and devolutionx is also fixed. | 14:21:04 |
Sandro | * pipewire builds when picked ontop of staging-next and devolutionx is also fixed. Going to retarget it to staging-next since it is a regression. | 14:21:17 |
hexa | yep, tested the same | 14:23:47 |
Sandro | Going to add the 2.24.2 release on top which has only bug fixes, one for wayland | 14:42:34 |
hexa | merged | 17:18:32 |
| 8 Nov 2022 |
Sandro | Can we still get https://github.com/NixOS/nixpkgs/pull/200064 in ? | 01:05:45 |
VladimÃr ÄŒunát | I see nothing against it in the rules. DEs even have an exception on "breaking changes". | 05:32:39 |
| 14 Nov 2022 |
@grahamc:nixos.org | hey folks, Linux Hackerman and I have just put together a bit of a cleanup to the NixOS AMI. It makes a breaking changes to the AMI, and it would be nice to get it in to the release if possible. We deleted code that would automatically:
swapon instance store volumes that were pre-formatted as swap
- mount ext3-formatted instance volumes to
/diskN
The only modern instances that have instance storage are very high-end, and it is unlikely that users of those instances would want us to impose this behavior.
Would anybody object to getting this into 22.11 (with accompanying release notes) or should we wait until next week after the branch-off? It would be nice to get it in if possible.
| 16:17:50 |
@linus:schreibt.jetzt | (code in question: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/amazon-image.nix#L105-L143 ) | 16:21:10 |
@linus:schreibt.jetzt | we'd also like to move the EC2 metadata fetcher into stage-2, since this is the only reason to have it in stage-1, and we can slim down the initramfs quite bit with that. | 16:22:24 |
@grahamc:nixos.org | note that this section is ultra legacy and not usable anymore, as we haven't produced instance-store AMIs in ages: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/amazon-image.nix#L130-L142 | 16:22:25 |
@grahamc:nixos.org | * note that deleting this section is not a breaking change, as it is ultra legacy and not usable anymore, as we haven't produced instance-store AMIs in ages: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/amazon-image.nix#L130-L142 | 16:22:36 |
@grahamc:nixos.org | my general expectation is this should impact ~0 users | 16:23:04 |
@grahamc:nixos.org | maybe we should put up a PR so we can be very specific about what we're talking about. | 16:25:24 |
hexa | I don't have a clue about our AMIs tbh | 16:33:53 |
Janne Heß | In reply to @hexa:lossy.network I don't have a clue about our AMIs tbh I only know that they need grub 1 for some reason 👀 | 16:34:15 |
hexa | 😄 | 16:34:19 |
hexa | maybe amine is a better judge of amazon amis? | 16:34:28 |
@linus:schreibt.jetzt | In reply to @janne.hess:helsinki-systems.de I only know that they need grub 1 for some reason 👀 not anymore :) | 16:34:29 |
@linus:schreibt.jetzt | (this is already the case, our PR isn't relevant to that) | 16:36:32 |
@grahamc:nixos.org | our PR does delete dead code which toggles to grub1 in an impossible circumstance | 16:37:44 |
hexa | put it up 😄 | 16:38:39 |
@linus:schreibt.jetzt | still writing the release notes 😅 | 16:38:48 |
Winter (she/her) | Linux Hackerman: please request either the RM team or Mic92 and I to go over the release notes :) | 17:26:24 |