| 29 Apr 2024 |
|  NixOS Moderation Botchanged room power levels. | 15:28:52 |
 Philip Taron (UTC-8) | Hello all, I wasn't able to find a Java team in nixos org, so I'll request reviews for https://github.com/NixOS/nixpkgs/pull/307783 here. | 15:44:13 |
| Philip Taron (UTC-8) | Infinidoge: you're the author of the PR I followed to add this. | 15:44:30 |
 Infinidoge | Yep I saw the notification, reminded me that I have my own JDK PR that I need to kick into actually being mergabke | 15:45:01 |
| Infinidoge | * Yep I saw the notification, reminded me that I have my own JDK PR that I need to kick into actually being mergable | 15:45:07 |
| Philip Taron (UTC-8) | I'll gladly give way if there's something more thorough in the works! | 15:45:27 |
| Infinidoge | In reply to @philiptaron:matrix.org
Hello all, I wasn't able to find a Java team in nixos org, so I'll request reviews for https://github.com/NixOS/nixpkgs/pull/307783 here. Looks good to me but haven't tested it yet, only small nitpick is the reformatting without being done not as its own commit, but also that doesn't matter that much | 15:46:27 |
| Infinidoge | In reply to @philiptaron:matrix.org
I'll gladly give way if there's something more thorough in the works! I have a massive bump PR that goes through basically every JDK in Nixpkgs, but it's so big that it's been stalled for months now lol | 15:47:13 |
| Infinidoge | Now that the semester is ending I'm kicking myself into actually finishing it | 15:47:26 |
| Philip Taron (UTC-8) | Figuring out how to split these things up is usually the most work. 😩 | 15:47:46 |
| Infinidoge | Yep | 15:47:55 |
| Philip Taron (UTC-8) | I appreciated the PR you made that had a nice split; it made me feel like it was possible to just increment my way toward a JVM bump. | 15:48:17 |
| Infinidoge | What we really need in nixpkgs is better automation for JDK bumps in general, and more code reuse between them | 15:48:50 |
| Infinidoge | Because right now it is a mess | 15:48:56 |
| Infinidoge | It's a sisyphean task though | 15:49:39 |
| Philip Taron (UTC-8) | It's pretty similar to the LLVM situation before https://matrix.to/#/@rosscomputerguy:matrix.org made https://github.com/NixOS/nixpkgs/pull/299807 | 15:50:55 |
| Philip Taron (UTC-8) | If you like how this PR tastes, I'm planning on doing the same update for semeru-bin. | 15:55:29 |
| Infinidoge | Wait | 16:37:55 |
| Infinidoge | Temurin bin 23 exists? | 16:38:01 |
| Infinidoge | OpenJDK 23 doesn't exist yet, how does temurin have a 23 release | 16:38:12 |
| Infinidoge | Unless that's just Java mainline | 16:39:03 |
| Infinidoge | The website only lists up to 22 | 16:39:30 |
| Philip Taron (UTC-8) | 🤔 | 16:39:48 |
| Philip Taron (UTC-8) | I marked the PR as draft because I messed up something and got an eval failure. I think it's related to the 23 thing. | 16:40:27 |
| Infinidoge | Yeah I'm pretty sure JDK 23 just doesn't exist lol | 16:41:00 |
| Infinidoge | The eval failure is probably because it didn't get any sources for 23 | 16:41:20 |
| Infinidoge | In reply to @philiptaron:matrix.org
I'll gladly give way if there's something more thorough in the works! If you would prefer, I can pull the JDK 22 bump into my PR and do an overall update sources there | 17:08:10 |
| Philip Taron (UTC-8) | Let's do that | 17:08:23 |
| Infinidoge | (Currently working on bumping Semeru which is why I ask) | 17:08:25 |
| Infinidoge | Would pretty much just cherrypick your commit but exclude the sources update, then update sources all at once | 17:08:47 |
