| 29 May 2024 |
 Jan Tojnar | * Looks like the pretty URLs does not do canonization. Here is a valid URL with HTML suffix – there is no redirect to strip it: https://nix.dev/manual/nix/2.13/language/constructs.html | 08:19:06 |
 fricklerhandwerk | The situation is pretty cursed due to how I messed up the situation before merging the (hopefully final) fix. Jan Tojnar and I just looked into it and there is no meaningful hotfix except waiting nixos.org to be deployed.
Redirects with .html suffixes seem not to work because maybe nix.dev doesn't have Netlify Pretty URLs enabled - or maybe the feature doesn't work as one would expect, or maybe it interacts in weird ways with redirects. This is all very confusing
| 08:51:24 |
| fricklerhandwerk | * The situation is pretty cursed due to how I messed up the situation before merging the (hopefully final) fix. Jan Tojnar and I just looked into it and there is no meaningful hotfix except waiting for nixos.org to be redeployed.
Redirects with .html suffixes seem not to work because maybe nix.dev doesn't have Netlify Pretty URLs enabled - or maybe the feature doesn't work as one would expect, or maybe it interacts in weird ways with redirects. This is all very confusing
| 08:51:35 |
| fricklerhandwerk | * The situation is pretty cursed due to how I messed it up before merging the (hopefully final) fix. Jan Tojnar and I just looked into it and there is no meaningful hotfix except waiting for nixos.org to be redeployed.
Redirects with .html suffixes seem not to work because maybe nix.dev doesn't have Netlify Pretty URLs enabled - or maybe the feature doesn't work as one would expect, or maybe it interacts in weird ways with redirects. This is all very confusing
| 08:52:17 |
|  hexa joined the room. | 09:06:16 |
 @janne.hess:helsinki-systems.de | Not sure if this has been reported already but google tends to give me URLs like https://nixos.org/manual/nix/unstable/language/builtins which redirect and 404 now | 09:55:14 |
| fricklerhandwerk | Janne Heß: Yes, literally the handful prior messages | 10:46:26 |
| fricklerhandwerk | * Janne Heß: Yes, literally the handful of prior messages | 10:46:35 |
| @janne.hess:helsinki-systems.de | In reply to @fricklerhandwerk:matrix.org
Janne Heß: Yes, literally the handful of prior messages Sorry, I was in a rush and overlooked them :/ | 10:54:20 |
|  raitobezarius changed their display name from raitobezarius to raitobezarius (DECT: 7248). | 17:10:53 |
| fricklerhandwerk | Seems to be fixed now, thanks to whoever! | 21:38:09 |
| 30 May 2024 |
| fricklerhandwerk | In reply to @jtojnar:matrix.org
Looks like intra-manual redirects are borked too: https://nix.dev/manual/nix/2.13/expressions/language-constructs.html#functions redirects to https://nix.dev/manual/nix/2.13/language/language-constructs.html#functions instead of https://nix.dev/manual/nix/2.13/language/constructs#functions That particular bit is still broken, will look into it in a quiet minute | 06:30:30 |
| 1 Jun 2024 |
|  kait changed their display name from kait/ to speepy. | 08:52:50 |
| 4 Jun 2024 |
|  infinisil changed their profile picture. | 02:43:57 |
| raitobezarius changed their display name from raitobezarius (DECT: 7248) to raitobezarius. | 11:14:06 |
| 5 Jun 2024 |
| kait changed their display name from speepy to kait. | 08:12:19 |
| 7 Jun 2024 |
|  @alex3829:matrix.org removed their display name real_z2. | 23:43:48 |
| 8 Jun 2024 |
 ris_ | think it's ok for me to backport https://github.com/NixOS/nixpkgs/pull/317575 to 24.05? it doesn't actually document anything new, all of these flags are already in 24.05 | 11:59:12 |
| fricklerhandwerk | In reply to @r_i_s:matrix.org
think it's ok for me to backport https://github.com/NixOS/nixpkgs/pull/317575 to 24.05? it doesn't actually document anything new, all of these flags are already in 24.05 Sure | 12:48:24 |
| 10 Jun 2024 |
|  NixOS Moderation Bot unbanned  jonringer. | 00:17:07 |
|  clvxaz joined the room. | 17:31:57 |
| 11 Jun 2024 |
|  camzer joined the room. | 23:51:53 |
| 12 Jun 2024 |
|  Lorenz Leutgeb removed their display name Lorenz Leutgeb. | 00:31:17 |
| Lorenz Leutgeb set their display name to Lorenz Leutgeb. | 00:32:51 |
| 15 Jun 2024 |
 getpsyched | I was wondering what's the status of PR review material in nixpkgs. So far, I've seen some points put in nixos/README.md and pkgs/README.md for reviewing contributions. Are there any other "official" or community efforts on this? | 12:04:37 |
| fricklerhandwerk | In reply to @getpsyched:matrix.org
I was wondering what's the status of PR review material in nixpkgs. So far, I've seen some points put in nixos/README.md and pkgs/README.md for reviewing contributions. Are there any other "official" or community efforts on this? These are the only places, to my knowledge. | 14:29:07 |
| getpsyched | Hmm. It might be worthwhile making a single resource where all of these things are combined as a comprehensive guide. I'm willing to take this on sometime soon. Wondering what would be a good place to put it; Maybe a dedicated project or, better yet, a wiki page 🤔 | 14:31:59 |
| getpsyched | * Hmm. It might be worthwhile making a single resource where all of these things are combined as a comprehensive guide. I'm willing to take this on sometime soon. Wondering what would be a good place to put it; Maybe a dedicated project or, better yet, a wiki page 🤔 | 14:32:06 |
 proofconstruction | Depends on what you mean by PR review materials, really. Guidelines for what to look for when reviewing? In any case, information scoped to a particular project should live in that project’s repo. | 20:47:06 |
| 16 Jun 2024 |
| getpsyched |
In any case, information scoped to a particular project should live in that project’s repo.
Yeah I don't mean project-specific quirks.
Guidelines for what to look for when reviewing?
At the crux of it, yes. Most of the basic conventions are known by most people but a lot of the relatively "newer" things like not overusing pname, or any other quirks specific to helper functions et al.
| 06:27:13 |
