| 20 Feb 2024 |
K900 | Because then we can just do package-v2.nix or whatever with the new API | 20:36:39 |
K900 | Without having to fight all-packages.nix merge conflicts for months | 20:36:59 |
Minijackson | note that weirdly enough, splicing is a solution to the flake packages.${arch} issue: https://github.com/szlend/nix-pkgset | 20:37:02 |
szlend | Yeah, this is just me trying to follow whatever patterns are established by nixpkgs because I didn't feel like reinventing the wheel | 20:37:39 |
K900 | It's not | 20:37:44 |
K900 | Well it kinda is | 20:37:51 |
K900 | But it's still a hack | 20:37:55 |
K900 | I have ideas but that's a conversation for much later | 20:38:06 |
| 26 Feb 2024 |
Philip Taron (UTC-8) | infinisil: I'm on deck to take a look through your by-name PR today. It's hefty! | 17:27:46 |
infinisil | Philip Taron (UTC-8): Thanks and agreed! | 17:29:10 |
Philip Taron (UTC-8) | At work, we use a approve-commits model, instead of an approve-PR model, which makes the review process substantially lighter. I'm sad that GitHub doesn't let that happen, since I only get the chance to review the whole squashed PRs. | 17:30:02 |
Philip Taron (UTC-8) | * At work, we use a approve-commits model, instead of an approve-PR model, which makes the review process substantially lighter. I'm sad that GitHub doesn't let that happen, since I only get the chance to review the whole squashed PR. | 17:30:04 |
infinisil | I should create smaller PRs than this really 😅 | 17:30:42 |
infinisil | Though if I do small PRs in parallel, I'd get a ton of merge conflicts. And if I do them in series, it would take a long time to make any progress | 17:31:38 |
infinisil | Some middle ground is probably best | 17:32:17 |
Philip Taron (UTC-8) | Yeah; I think the PR size is OK iff the reviewer can say yes/no on each commit. | 17:33:56 |
Philip Taron (UTC-8) | That powers you to make targeted fixes on each commit, which makes the merge conflicts lower, which enhances the whole PR, in my experience. | 17:34:41 |
infinisil | Oh yeah that sounds nice | 17:35:02 |
Philip Taron (UTC-8) | But since we're in "default GitHub" world, we must make do. | 17:35:05 |
Philip Taron (UTC-8) | It's OK. | 17:35:07 |
infinisil | Gotta work with the tools you have! | 17:35:47 |
infinisil | (up to a point!) | 17:35:52 |
Philip Taron (UTC-8) | In reply to @infinisil:matrix.org Gotta work with the tools you have! Did the work, PR reviewed. Biggest blocker is the non-reproducibility of the tests since they encode /home/tweagysil/src, then lots of English wordings and suggestions. | 21:04:11 |
| 29 Feb 2024 |
| @adam:robins.wtf joined the room. | 03:22:59 |
| @2xsaiko:tchncs.de joined the room. | 03:23:03 |
| @nscnt:matrix.org joined the room. | 07:07:56 |
| Jonas Chevalier joined the room. | 14:56:35 |
| 1 Mar 2024 |
| tomberek set a profile picture. | 15:20:36 |
| 2 Mar 2024 |
| @dooy:matrix.org left the room. | 11:27:53 |
| Qyriad joined the room. | 19:34:26 |