!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

227 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
3 Feb 2024
@raboof:matrix.orgraboof changed their display name from raboof to raboof @FOSDEM.07:38:34
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org

There is one remaining problem with the current pkgs/by-name check, and this fixes it: https://github.com/NixOS/nixpkgs/pull/285089

Quite a bit of Rust code there, would appreciate a review

Done. Many comments, but only a couple that I think are worthy of spending any work on.
19:05:17
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Thanks a lot! 20:17:58
@infinisil:matrix.orginfinisilI'll get to it next week :D20:18:11
@infinisil:matrix.orginfinisil(or maybe tomorrow)20:18:20
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
(or maybe tomorrow)
Sounds good
21:09:16
4 Feb 2024
@bjth:matrix.orgBryan Honof changed their profile picture.11:31:18
@raboof:matrix.orgraboof changed their display name from raboof @FOSDEM to raboof.17:41:16
5 Feb 2024
@k900:0upti.meK900This is not quite a NAT issue, but I'm adding another top level package set in https://github.com/NixOS/nixpkgs/pull/28652216:27:31
@k900:0upti.meK900Would appreciate some eyes on it16:27:53
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
Philip Taron (UTC-8): Thanks a lot!
✅ after your updates.
19:45:08
@infinisil:matrix.orginfinisil
In reply to @philiptaron:matrix.org
✅ after your updates.
🚀
19:47:16
@philiptaron:matrix.orgPhilip Taron (UTC-8)You still have to pin the new version, right?19:47:58
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Yup 19:50:25
@infinisil:matrix.orginfinisilGotta wait for Hydra now19:50:30
@infinisil:matrix.orginfinisilShould really move that codebase to a separate repo, add some versioning on top and then rely on automatic bot updates to pin it in Nixpkgs19:51:02
@philiptaron:matrix.orgPhilip Taron (UTC-8)I think that'd be a good idea.19:51:38
@philiptaron:matrix.orgPhilip Taron (UTC-8)nixos/nixpkgs-ratchet?19:51:50
@infinisil:matrix.orginfinisilNot exclusive to the ratchet checks, so probably something else19:52:23
@infinisil:matrix.orginfinisil And also it's well suited to handle CI for things outside pkgs/by-name too (like ensuring things evaluate) 19:52:44
@infinisil:matrix.orginfinisilCould be integrated into ofborg perhaps, though it's not quite the same19:53:29
@philiptaron:matrix.orgPhilip Taron (UTC-8)Yeah, true. I like "ratchet" because most of the checks there aren't binary pass/fail, but are incremental. But the name could be as general as "linter".19:53:52
@infinisil:matrix.orginfinisilMost checks are fairly binary actually!19:54:14
@infinisil:matrix.orginfinisilSee https://github.com/NixOS/nixpkgs/tree/master/pkgs/test/nixpkgs-check-by-name#validity-checks19:54:45
@infinisil:matrix.orginfinisilI guess people are most likely to run into the ratchet checks though :)19:55:29
@philiptaron:matrix.orgPhilip Taron (UTC-8)Yeah, agree.19:55:56
@philiptaron:matrix.orgPhilip Taron (UTC-8)Maybe "nixpkgs-vet" because it "vets" nixpkgs architecture?19:56:13
@infinisil:matrix.orginfinisilOh I like that19:56:37
@infinisil:matrix.orginfinisilOpened https://github.com/NixOS/nixpkgs/issues/28655920:11:51
@infinisil:matrix.orginfinisilWon't prioritise this right now, but at least it's tracked this way20:12:10

Show newer messages


Back to Room ListRoom Version: 9